From fb5ac3b3ae8aa4617bad2f44319bd10e99c0e305 Mon Sep 17 00:00:00 2001
From: DannyAAM <danny@saru.moe>
Date: Sat, 15 Jul 2023 04:41:01 +0800
Subject: [PATCH] add version validator

also make some variables const as they should
---
 assets/js/selecting.js | 52 +++++++++++++++++++++++++++++++-----------
 1 file changed, 39 insertions(+), 13 deletions(-)

diff --git a/assets/js/selecting.js b/assets/js/selecting.js
index b422ac1742..aef0af30f2 100644
--- a/assets/js/selecting.js
+++ b/assets/js/selecting.js
@@ -8,6 +8,36 @@
 const DEVICE_N3DS = 1;
 const DEVICE_O3DS = 0;
 
+// Possible max minor for each major, major as key
+const major_minor_map = {
+    0: -1, // invalidate all 0.x
+    1: 1,
+    2: 2,
+    3: 1,
+    4: 5,
+    5: 1,
+    6: 4,
+    7: 2,
+    8: 1,
+    9: 9,
+    10: 7,
+    11: 17
+}
+
+// Validate version
+function validate_version(major, minor, native, region, model) {
+    if (model == DEVICE_N3DS && ["C", "T"].includes(region)) {
+        return false;
+    }
+
+    const minor_max = major_minor_map[major];
+    if (!isNaN(minor_max) && minor > minor_max) {
+        return false;
+    }
+
+    return true;
+}
+
 // Soundhax
 // 1.0-11.3, all regions, all consoles
 function can_soundhax(major, minor, native, region, model) {
@@ -221,12 +251,12 @@ function is_o3ds_1117(major, minor, native, region, model) {
         - Use alternate exploits; can't hack without any extra stuff
 */
 function redirect() {
-    let major = document.getElementById("major");
-    let minor = document.getElementById("minor");
-    let nver = document.getElementById("nver");
-    let region = document.getElementById("region");
-    let isN3DS = document.getElementById("new3DS").checked;
-    let isO3DS = document.getElementById("old3DS").checked;
+    const major = document.getElementById("major").value;
+    const minor = document.getElementById("minor").value;
+    const nver = document.getElementById("nver").value;
+    const region = document.getElementById("region").value;
+    const isN3DS = document.getElementById("new3DS").checked;
+    const isO3DS = document.getElementById("old3DS").checked;
     document.getElementById("result_noneSelected").style.display = "none";
     document.getElementById("result_invalidVersion").style.display = "none";
     document.getElementById("result_methodUnavailable").style.display = "none";
@@ -234,22 +264,18 @@ function redirect() {
         document.getElementById("result_noneSelected").style.display = "block";
         return;
     }
-    else if (major.value == 0) {
-        document.getElementById("result_invalidVersion").style.display = "block";
-        return;
-    }
 
     // Realistically only one of these should be possible with the given elements
     let model = -1;
     if(isO3DS) model = DEVICE_O3DS
     else if(isN3DS) model = DEVICE_N3DS;
 
-    if (model == DEVICE_N3DS && ["C", "T"].includes(region.value)) {
+    if (!validate_version(major, minor, nver, region, model)) {
         document.getElementById("result_invalidVersion").style.display = "block";
         return;
     }
 
-    let redirected = [
+    const redirected = [
       can_soundhax,
       can_ssloth,
       can_safecerthax,
@@ -257,7 +283,7 @@ function redirect() {
       can_seedminer,
       can_superskaterhax,
       is_o3ds_1117
-    ].some(func => func(major.value, minor.value, nver.value, region.value, model));
+    ].some(func => func(major, minor, nver, region, model));
     if (redirected) return true;
 
     // if it actually got to this point, there is no exploit available.