Preserve image types for shader bindless surface instructions (.D variants) (#2779)

* Preserve image types for SULD/SUST .D variants

* Make format unknown for surface atomic if bindless and not sized
This commit is contained in:
gdkchan 2021-10-24 19:40:20 -03:00 committed by GitHub
parent 51fa1b2cb0
commit 04dfb86fde
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 10 deletions

View file

@ -264,8 +264,8 @@ namespace Ryujinx.Graphics.Shader.Instructions
} }
// TODO: FP and 64-bit formats. // TODO: FP and 64-bit formats.
TextureFormat format = !isBindless && (size == SuatomSize.Sd32 || size == SuatomSize.Sd64) TextureFormat format = size == SuatomSize.Sd32 || size == SuatomSize.Sd64
? context.Config.GetTextureFormatAtomic(imm) ? (isBindless ? TextureFormat.Unknown : context.Config.GetTextureFormatAtomic(imm))
: GetTextureFormat(size); : GetTextureFormat(size);
if (compareAndSwap) if (compareAndSwap)
@ -516,8 +516,8 @@ namespace Ryujinx.Graphics.Shader.Instructions
} }
// TODO: FP and 64-bit formats. // TODO: FP and 64-bit formats.
TextureFormat format = !isBindless && (size == SuatomSize.Sd32 || size == SuatomSize.Sd64) TextureFormat format = size == SuatomSize.Sd32 || size == SuatomSize.Sd64
? context.Config.GetTextureFormatAtomic(imm) ? (isBindless ? TextureFormat.Unknown : context.Config.GetTextureFormatAtomic(imm))
: GetTextureFormat(size); : GetTextureFormat(size);
sourcesList.Add(Rb()); sourcesList.Add(Rb());

View file

@ -128,13 +128,16 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
int cbufOffset = src0.GetCbufOffset(); int cbufOffset = src0.GetCbufOffset();
int cbufSlot = src0.GetCbufSlot(); int cbufSlot = src0.GetCbufSlot();
if (texOp.Inst == Instruction.ImageAtomic) if (texOp.Format == TextureFormat.Unknown)
{ {
texOp.Format = config.GetTextureFormatAtomic(cbufOffset, cbufSlot); if (texOp.Inst == Instruction.ImageAtomic)
} {
else texOp.Format = config.GetTextureFormatAtomic(cbufOffset, cbufSlot);
{ }
texOp.Format = config.GetTextureFormat(cbufOffset, cbufSlot); else
{
texOp.Format = config.GetTextureFormat(cbufOffset, cbufSlot);
}
} }
SetHandle(config, texOp, cbufOffset, cbufSlot, false); SetHandle(config, texOp, cbufOffset, cbufSlot, false);