N-archive/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Update to LibHac 0.12.0 (#1485)

Browse source 
* Update to LibHac 0.12.0

* Auto-formatting. Fixed a bug in SetApplicationCopyrightImage
This commit is contained in:
Alex Barney 2020-09-01 13:08:59 -07:00 committed by GitHub
parent 6cc187da59
commit 1bb7fdaca4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 122 additions and 110 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Ryujinx.HLE/FileSystem/Content/ContentManager.cs
View file

@ -1,6 +1,7 @@
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using LibHac.Ncm; using LibHac.Ncm;
@ -827,7 +828,7 @@ namespace Ryujinx.HLE.FileSystem.Content
LibHac.Crypto.Sha256.GenerateSha256Hash(content, hash); LibHac.Crypto.Sha256.GenerateSha256Hash(content, hash);
if (LibHac.Util.ArraysEqual(hash.ToArray(), meta.ContentEntries[0].Hash)) if (LibHac.Utilities.ArraysEqual(hash.ToArray(), meta.ContentEntries[0].Hash))
{ {
updateNcas.Remove(metaEntry.TitleId); updateNcas.Remove(metaEntry.TitleId);
} }
@ -962,7 +963,7 @@ namespace Ryujinx.HLE.FileSystem.Content
LibHac.Crypto.Sha256.GenerateSha256Hash(content, hash); LibHac.Crypto.Sha256.GenerateSha256Hash(content, hash);
if (LibHac.Util.ArraysEqual(hash.ToArray(), meta.ContentEntries[0].Hash)) if (LibHac.Utilities.ArraysEqual(hash.ToArray(), meta.ContentEntries[0].Hash))
{ {
updateNcas.Remove(metaEntry.TitleId); updateNcas.Remove(metaEntry.TitleId);
} }

2
Ryujinx.HLE/FileSystem/SaveHelper.cs
View file

@ -1,4 +1,4 @@
using LibHac.Fs; using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using Ryujinx.HLE.HOS; using Ryujinx.HLE.HOS;
using System.IO; using System.IO;

3
Ryujinx.HLE/FileSystem/VirtualFileSystem.cs
View file

@ -1,7 +1,8 @@
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.FsService; using LibHac.Fs.Fsa;
using LibHac.FsSrv;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.Spl; using LibHac.Spl;
using Ryujinx.Common.Configuration; using Ryujinx.Common.Configuration;

15
Ryujinx.HLE/HOS/ApplicationLoader.cs
View file

@ -3,9 +3,9 @@ using LibHac;
using LibHac.Account; using LibHac.Account;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using LibHac.Ncm;
using LibHac.Ns; using LibHac.Ns;
using Ryujinx.Common.Configuration; using Ryujinx.Common.Configuration;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;
@ -20,6 +20,7 @@ using System.Linq;
using System.Reflection; using System.Reflection;
using static LibHac.Fs.ApplicationSaveDataManagement; using static LibHac.Fs.ApplicationSaveDataManagement;
using ApplicationId = LibHac.Ncm.ApplicationId;
namespace Ryujinx.HLE.HOS namespace Ryujinx.HLE.HOS
{ {
@ -73,7 +74,7 @@ namespace Ryujinx.HLE.HOS
if (TitleId != 0) if (TitleId != 0)
{ {
EnsureSaveData(new TitleId(TitleId)); EnsureSaveData(new ApplicationId(TitleId));
} }
LoadExeFs(codeFs, metaData); LoadExeFs(codeFs, metaData);
@ -333,7 +334,7 @@ namespace Ryujinx.HLE.HOS
if (TitleId != 0) if (TitleId != 0)
{ {
EnsureSaveData(new TitleId(TitleId)); EnsureSaveData(new ApplicationId(TitleId));
} }
LoadExeFs(codeFs, metaData); LoadExeFs(codeFs, metaData);
@ -549,7 +550,7 @@ namespace Ryujinx.HLE.HOS
} }
} }
private Result EnsureSaveData(TitleId titleId) private Result EnsureSaveData(ApplicationId applicationId)
{ {
Logger.Info?.Print(LogClass.Application, "Ensuring required savedata exists."); Logger.Info?.Print(LogClass.Application, "Ensuring required savedata exists.");
@ -557,7 +558,7 @@ namespace Ryujinx.HLE.HOS
ref ApplicationControlProperty control = ref ControlData.Value; ref ApplicationControlProperty control = ref ControlData.Value;
if (Util.IsEmpty(ControlData.ByteSpan)) if (LibHac.Utilities.IsEmpty(ControlData.ByteSpan))
{ {
// If the current application doesn't have a loaded control property, create a dummy one // If the current application doesn't have a loaded control property, create a dummy one
// and set the savedata sizes so a user savedata will be created. // and set the savedata sizes so a user savedata will be created.
@ -573,7 +574,7 @@ namespace Ryujinx.HLE.HOS
FileSystemClient fs = _fileSystem.FsClient; FileSystemClient fs = _fileSystem.FsClient;
Result rc = fs.EnsureApplicationCacheStorage(out _, titleId, ref control); Result rc = fs.EnsureApplicationCacheStorage(out _, applicationId, ref control);
if (rc.IsFailure()) if (rc.IsFailure())
{ {
@ -582,7 +583,7 @@ namespace Ryujinx.HLE.HOS
return rc; return rc;
} }
rc = EnsureApplicationSaveData(fs, out _, titleId, ref control, ref user); rc = EnsureApplicationSaveData(fs, out _, applicationId, ref control, ref user);
if (rc.IsFailure()) if (rc.IsFailure())
{ {

2
Ryujinx.HLE/HOS/Font/SharedFontManager.cs
View file

@ -1,8 +1,8 @@
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using Ryujinx.Common.Logging;
using Ryujinx.HLE.Exceptions; using Ryujinx.HLE.Exceptions;
using Ryujinx.HLE.FileSystem; using Ryujinx.HLE.FileSystem;
using Ryujinx.HLE.FileSystem.Content; using Ryujinx.HLE.FileSystem.Content;

1
Ryujinx.HLE/HOS/ModLoader.cs
View file

@ -1,5 +1,6 @@
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.RomFs; using LibHac.FsSystem.RomFs;
using Ryujinx.Common.Configuration; using Ryujinx.Common.Configuration;

38
Ryujinx.HLE/HOS/Services/Am/AppletOE/ApplicationProxyService/ApplicationProxy/IApplicationFunctions.cs
View file

@ -2,7 +2,6 @@ using LibHac;
using LibHac.Account; using LibHac.Account;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Ncm;
using LibHac.Ns; using LibHac.Ns;
using Ryujinx.Common; using Ryujinx.Common;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;
@ -18,6 +17,7 @@ using System.Numerics;
using static LibHac.Fs.ApplicationSaveDataManagement; using static LibHac.Fs.ApplicationSaveDataManagement;
using AccountUid = Ryujinx.HLE.HOS.Services.Account.Acc.UserId; using AccountUid = Ryujinx.HLE.HOS.Services.Account.Acc.UserId;
using ApplicationId = LibHac.Ncm.ApplicationId;
namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.ApplicationProxy namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.ApplicationProxy
{ {
@ -29,9 +29,9 @@ namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.Applicati
public IApplicationFunctions(Horizon system) public IApplicationFunctions(Horizon system)
{ {
_gpuErrorDetectedSystemEvent = new KEvent(system.KernelContext); _gpuErrorDetectedSystemEvent = new KEvent(system.KernelContext);
_friendInvitationStorageChannelEvent = new KEvent(system.KernelContext); _friendInvitationStorageChannelEvent = new KEvent(system.KernelContext);
_notificationStorageChannelEvent = new KEvent(system.KernelContext); _notificationStorageChannelEvent = new KEvent(system.KernelContext);
} }
[Command(1)] [Command(1)]
@ -48,28 +48,28 @@ namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.Applicati
// EnsureSaveData(nn::account::Uid) -> u64 // EnsureSaveData(nn::account::Uid) -> u64
public ResultCode EnsureSaveData(ServiceCtx context) public ResultCode EnsureSaveData(ServiceCtx context)
{ {
Uid userId = context.RequestData.ReadStruct<AccountUid>().ToLibHacUid(); Uid userId = context.RequestData.ReadStruct<AccountUid>().ToLibHacUid();
TitleId titleId = new TitleId(context.Process.TitleId); ApplicationId applicationId = new ApplicationId(context.Process.TitleId);
BlitStruct<ApplicationControlProperty> controlHolder = context.Device.Application.ControlData; BlitStruct<ApplicationControlProperty> controlHolder = context.Device.Application.ControlData;
ref ApplicationControlProperty control = ref controlHolder.Value; ref ApplicationControlProperty control = ref controlHolder.Value;
if (Util.IsEmpty(controlHolder.ByteSpan)) if (LibHac.Utilities.IsEmpty(controlHolder.ByteSpan))
{ {
// If the current application doesn't have a loaded control property, create a dummy one // If the current application doesn't have a loaded control property, create a dummy one
// and set the savedata sizes so a user savedata will be created. // and set the savedata sizes so a user savedata will be created.
control = ref new BlitStruct<ApplicationControlProperty>(1).Value; control = ref new BlitStruct<ApplicationControlProperty>(1).Value;
// The set sizes don't actually matter as long as they're non-zero because we use directory savedata. // The set sizes don't actually matter as long as they're non-zero because we use directory savedata.
control.UserAccountSaveDataSize = 0x4000; control.UserAccountSaveDataSize = 0x4000;
control.UserAccountSaveDataJournalSize = 0x4000; control.UserAccountSaveDataJournalSize = 0x4000;
Logger.Warning?.Print(LogClass.ServiceAm, Logger.Warning?.Print(LogClass.ServiceAm,
"No control file was found for this game. Using a dummy one instead. This may cause inaccuracies in some games."); "No control file was found for this game. Using a dummy one instead. This may cause inaccuracies in some games.");
} }
Result result = EnsureApplicationSaveData(context.Device.FileSystem.FsClient, out long requiredSize, titleId, Result result = EnsureApplicationSaveData(context.Device.FileSystem.FsClient, out long requiredSize, applicationId,
ref control, ref userId); ref control, ref userId);
context.ResponseData.Write(requiredSize); context.ResponseData.Write(requiredSize);
@ -210,10 +210,10 @@ namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.Applicati
// InitializeApplicationCopyrightFrameBuffer(s32 width, s32 height, handle<copy, transfer_memory> transfer_memory, u64 transfer_memory_size) // InitializeApplicationCopyrightFrameBuffer(s32 width, s32 height, handle<copy, transfer_memory> transfer_memory, u64 transfer_memory_size)
public ResultCode InitializeApplicationCopyrightFrameBuffer(ServiceCtx context) public ResultCode InitializeApplicationCopyrightFrameBuffer(ServiceCtx context)
{ {
int width = context.RequestData.ReadInt32(); int width = context.RequestData.ReadInt32();
int height = context.RequestData.ReadInt32(); int height = context.RequestData.ReadInt32();
ulong transferMemorySize = context.RequestData.ReadUInt64(); ulong transferMemorySize = context.RequestData.ReadUInt64();
int transferMemoryHandle = context.Request.HandleDesc.ToCopy[0]; int transferMemoryHandle = context.Request.HandleDesc.ToCopy[0];
ulong transferMemoryAddress = context.Process.HandleTable.GetObject<KTransferMemory>(transferMemoryHandle).Address; ulong transferMemoryAddress = context.Process.HandleTable.GetObject<KTransferMemory>(transferMemoryHandle).Address;
ResultCode resultCode = ResultCode.InvalidParameters; ResultCode resultCode = ResultCode.InvalidParameters;
@ -258,12 +258,12 @@ namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.Applicati
// SetApplicationCopyrightImage(buffer<bytes, 0x45> frame_buffer, s32 x, s32 y, s32 width, s32 height, s32 window_origin_mode) // SetApplicationCopyrightImage(buffer<bytes, 0x45> frame_buffer, s32 x, s32 y, s32 width, s32 height, s32 window_origin_mode)
public ResultCode SetApplicationCopyrightImage(ServiceCtx context) public ResultCode SetApplicationCopyrightImage(ServiceCtx context)
{ {
long frameBufferPos = context.Request.SendBuff[0].Position; long frameBufferPos = context.Request.SendBuff[0].Position;
long frameBufferSize = context.Request.SendBuff[0].Size; long frameBufferSize = context.Request.SendBuff[0].Size;
int x = context.RequestData.ReadInt32(); int x = context.RequestData.ReadInt32();
int y = context.RequestData.ReadInt32(); int y = context.RequestData.ReadInt32();
int width = context.RequestData.ReadInt32(); int width = context.RequestData.ReadInt32();
int height = context.RequestData.ReadInt32(); int height = context.RequestData.ReadInt32();
uint windowOriginMode = context.RequestData.ReadUInt32(); uint windowOriginMode = context.RequestData.ReadUInt32();
ResultCode resultCode = ResultCode.InvalidParameters; ResultCode resultCode = ResultCode.InvalidParameters;
@ -272,7 +272,7 @@ namespace Ryujinx.HLE.HOS.Services.Am.AppletOE.ApplicationProxyService.Applicati
{ {
ResultCode result = SetApplicationCopyrightImageImpl(x, y, width, height, frameBufferPos, frameBufferSize, windowOriginMode); ResultCode result = SetApplicationCopyrightImageImpl(x, y, width, height, frameBufferPos, frameBufferSize, windowOriginMode);
if (resultCode != ResultCode.Success) if (result != ResultCode.Success)
{ {
resultCode = result; resultCode = result;
} }

8
Ryujinx.HLE/HOS/Services/Fs/FileSystemProxy/FileSystemProxyHelper.cs
View file

@ -44,7 +44,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
return ResultCode.PartitionNotFound; return ResultCode.PartitionNotFound;
} }
LibHac.Fs.IFileSystem fileSystem = nca.OpenFileSystem(NcaSectionType.Data, context.Device.System.FsIntegrityCheckLevel); LibHac.Fs.Fsa.IFileSystem fileSystem = nca.OpenFileSystem(NcaSectionType.Data, context.Device.System.FsIntegrityCheckLevel);
openedFileSystem = new IFileSystem(fileSystem); openedFileSystem = new IFileSystem(fileSystem);
} }
@ -82,7 +82,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
string filename = fullPath.Replace(archivePath.FullName, string.Empty).TrimStart('\\'); string filename = fullPath.Replace(archivePath.FullName, string.Empty).TrimStart('\\');
Result result = nsp.OpenFile(out LibHac.Fs.IFile ncaFile, filename.ToU8Span(), OpenMode.Read); Result result = nsp.OpenFile(out LibHac.Fs.Fsa.IFile ncaFile, filename.ToU8Span(), OpenMode.Read);
if (result.IsFailure()) if (result.IsFailure())
{ {
return (ResultCode)result.Value; return (ResultCode)result.Value;
@ -99,11 +99,11 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
return ResultCode.PathDoesNotExist; return ResultCode.PathDoesNotExist;
} }
public static void ImportTitleKeysFromNsp(LibHac.Fs.IFileSystem nsp, Keyset keySet) public static void ImportTitleKeysFromNsp(LibHac.Fs.Fsa.IFileSystem nsp, Keyset keySet)
{ {
foreach (DirectoryEntryEx ticketEntry in nsp.EnumerateEntries("/", "*.tik")) foreach (DirectoryEntryEx ticketEntry in nsp.EnumerateEntries("/", "*.tik"))
{ {
Result result = nsp.OpenFile(out LibHac.Fs.IFile ticketFile, ticketEntry.FullPath.ToU8Span(), OpenMode.Read); Result result = nsp.OpenFile(out LibHac.Fs.Fsa.IFile ticketFile, ticketEntry.FullPath.ToU8Span(), OpenMode.Read);
if (result.IsSuccess()) if (result.IsSuccess())
{ {

4
Ryujinx.HLE/HOS/Services/Fs/FileSystemProxy/IDirectory.cs
View file

@ -7,9 +7,9 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
{ {
class IDirectory : IpcService class IDirectory : IpcService
{ {
private LibHac.Fs.IDirectory _baseDirectory; private LibHac.Fs.Fsa.IDirectory _baseDirectory;
public IDirectory(LibHac.Fs.IDirectory directory) public IDirectory(LibHac.Fs.Fsa.IDirectory directory)
{ {
_baseDirectory = directory; _baseDirectory = directory;
} }

8
Ryujinx.HLE/HOS/Services/Fs/FileSystemProxy/IFile.cs
View file

@ -6,9 +6,9 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
{ {
class IFile : IpcService, IDisposable class IFile : IpcService, IDisposable
{ {
private LibHac.Fs.IFile _baseFile; private LibHac.Fs.Fsa.IFile _baseFile;
public IFile(LibHac.Fs.IFile baseFile) public IFile(LibHac.Fs.Fsa.IFile baseFile)
{ {
_baseFile = baseFile; _baseFile = baseFile;
} }
@ -19,7 +19,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
{ {
long position = context.Request.ReceiveBuff[0].Position; long position = context.Request.ReceiveBuff[0].Position;
ReadOption readOption = (ReadOption)context.RequestData.ReadInt32(); ReadOption readOption = new ReadOption(context.RequestData.ReadInt32());
context.RequestData.BaseStream.Position += 4; context.RequestData.BaseStream.Position += 4;
long offset = context.RequestData.ReadInt64(); long offset = context.RequestData.ReadInt64();
@ -42,7 +42,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
{ {
long position = context.Request.SendBuff[0].Position; long position = context.Request.SendBuff[0].Position;
WriteOption writeOption = (WriteOption)context.RequestData.ReadInt32(); WriteOption writeOption = new WriteOption(context.RequestData.ReadInt32());
context.RequestData.BaseStream.Position += 4; context.RequestData.BaseStream.Position += 4;
long offset = context.RequestData.ReadInt64(); long offset = context.RequestData.ReadInt64();

12
Ryujinx.HLE/HOS/Services/Fs/FileSystemProxy/IFileSystem.cs
View file

@ -1,21 +1,21 @@
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using static Ryujinx.HLE.Utilities.StringUtils; using static Ryujinx.HLE.Utilities.StringUtils;
namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
{ {
class IFileSystem : IpcService class IFileSystem : IpcService
{ {
private LibHac.Fs.IFileSystem _fileSystem; private LibHac.Fs.Fsa.IFileSystem _fileSystem;
public IFileSystem(LibHac.Fs.IFileSystem provider) public IFileSystem(LibHac.Fs.Fsa.IFileSystem provider)
{ {
_fileSystem = provider; _fileSystem = provider;
} }
public LibHac.Fs.IFileSystem GetBaseFileSystem() public LibHac.Fs.Fsa.IFileSystem GetBaseFileSystem()
{ {
return _fileSystem; return _fileSystem;
} }
@ -111,7 +111,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
U8Span name = ReadUtf8Span(context); U8Span name = ReadUtf8Span(context);
Result result = _fileSystem.OpenFile(out LibHac.Fs.IFile file, name, mode); Result result = _fileSystem.OpenFile(out LibHac.Fs.Fsa.IFile file, name, mode);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -131,7 +131,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs.FileSystemProxy
U8Span name = ReadUtf8Span(context); U8Span name = ReadUtf8Span(context);
Result result = _fileSystem.OpenDirectory(out LibHac.Fs.IDirectory dir, name, mode); Result result = _fileSystem.OpenDirectory(out LibHac.Fs.Fsa.IDirectory dir, name, mode);
if (result.IsSuccess()) if (result.IsSuccess())
{ {

6
Ryujinx.HLE/HOS/Services/Fs/IDeviceOperator.cs
View file

@ -1,13 +1,13 @@
using LibHac; using LibHac;
using LibHac.FsService; using LibHac.FsSrv;
namespace Ryujinx.HLE.HOS.Services.Fs namespace Ryujinx.HLE.HOS.Services.Fs
{ {
class IDeviceOperator : IpcService class IDeviceOperator : IpcService
{ {
private LibHac.FsService.IDeviceOperator _baseOperator; private LibHac.FsSrv.IDeviceOperator _baseOperator;
public IDeviceOperator(LibHac.FsService.IDeviceOperator baseOperator) public IDeviceOperator(LibHac.FsSrv.IDeviceOperator baseOperator)
{ {
_baseOperator = baseOperator; _baseOperator = baseOperator;
} }

55
Ryujinx.HLE/HOS/Services/Fs/IFileSystemProxy.cs
View file

@ -1,6 +1,6 @@
using LibHac; using LibHac;
using LibHac.Fs; using LibHac.Fs;
using LibHac.FsService; using LibHac.FsSrv;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using LibHac.Ncm; using LibHac.Ncm;
@ -18,7 +18,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
[Service("fsp-srv")] [Service("fsp-srv")]
class IFileSystemProxy : IpcService class IFileSystemProxy : IpcService
{ {
private LibHac.FsService.IFileSystemProxy _baseFileSystemProxy; private LibHac.FsSrv.IFileSystemProxy _baseFileSystemProxy;
public IFileSystemProxy(ServiceCtx context) public IFileSystemProxy(ServiceCtx context)
{ {
@ -97,7 +97,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
Result rc = FileSystemProxyHelper.ReadFsPath(out FsPath path, context); Result rc = FileSystemProxyHelper.ReadFsPath(out FsPath path, context);
if (rc.IsFailure()) return (ResultCode)rc.Value; if (rc.IsFailure()) return (ResultCode)rc.Value;
rc = _baseFileSystemProxy.OpenBisFileSystem(out LibHac.Fs.IFileSystem fileSystem, ref path, bisPartitionId); rc = _baseFileSystemProxy.OpenBisFileSystem(out LibHac.Fs.Fsa.IFileSystem fileSystem, ref path, bisPartitionId);
if (rc.IsFailure()) return (ResultCode)rc.Value; if (rc.IsFailure()) return (ResultCode)rc.Value;
MakeObject(context, new FileSystemProxy.IFileSystem(fileSystem)); MakeObject(context, new FileSystemProxy.IFileSystem(fileSystem));
@ -109,7 +109,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// OpenSdCardFileSystem() -> object<nn::fssrv::sf::IFileSystem> // OpenSdCardFileSystem() -> object<nn::fssrv::sf::IFileSystem>
public ResultCode OpenSdCardFileSystem(ServiceCtx context) public ResultCode OpenSdCardFileSystem(ServiceCtx context)
{ {
Result rc = _baseFileSystemProxy.OpenSdCardFileSystem(out LibHac.Fs.IFileSystem fileSystem); Result rc = _baseFileSystemProxy.OpenSdCardFileSystem(out LibHac.Fs.Fsa.IFileSystem fileSystem);
if (rc.IsFailure()) return (ResultCode)rc.Value; if (rc.IsFailure()) return (ResultCode)rc.Value;
MakeObject(context, new FileSystemProxy.IFileSystem(fileSystem)); MakeObject(context, new FileSystemProxy.IFileSystem(fileSystem));
@ -136,17 +136,17 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// TODO: There's currently no program registry for FS to reference. // TODO: There's currently no program registry for FS to reference.
// Workaround that by setting the application ID and owner ID if they're not already set // Workaround that by setting the application ID and owner ID if they're not already set
if (attribute.TitleId == TitleId.Zero) if (attribute.ProgramId == ProgramId.InvalidId)
{ {
attribute.TitleId = new TitleId(context.Process.TitleId); attribute.ProgramId = new ProgramId(context.Process.TitleId);
} }
if (creationInfo.OwnerId == TitleId.Zero) if (creationInfo.OwnerId == 0)
{ {
creationInfo.OwnerId = new TitleId(context.Process.TitleId); creationInfo.OwnerId = 0;
} }
Logger.Info?.Print(LogClass.ServiceFs, $"Creating save with title ID {attribute.TitleId.Value:x16}"); Logger.Info?.Print(LogClass.ServiceFs, $"Creating save with title ID {attribute.ProgramId.Value:x16}");
Result result = _baseFileSystemProxy.CreateSaveDataFileSystem(ref attribute, ref creationInfo, ref metaCreateInfo); Result result = _baseFileSystemProxy.CreateSaveDataFileSystem(ref attribute, ref creationInfo, ref metaCreateInfo);
@ -213,14 +213,14 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// TODO: There's currently no program registry for FS to reference. // TODO: There's currently no program registry for FS to reference.
// Workaround that by setting the application ID and owner ID if they're not already set // Workaround that by setting the application ID and owner ID if they're not already set
if (attribute.TitleId == TitleId.Zero) if (attribute.ProgramId == ProgramId.InvalidId)
{ {
attribute.TitleId = new TitleId(context.Process.TitleId); attribute.ProgramId = new ProgramId(context.Process.TitleId);
} }
if (creationInfo.OwnerId == TitleId.Zero) if (creationInfo.OwnerId == 0)
{ {
creationInfo.OwnerId = new TitleId(context.Process.TitleId); creationInfo.OwnerId = 0;
} }
Result result = _baseFileSystemProxy.CreateSaveDataFileSystemWithHashSalt(ref attribute, ref creationInfo, ref metaCreateInfo, ref hashSalt); Result result = _baseFileSystemProxy.CreateSaveDataFileSystemWithHashSalt(ref attribute, ref creationInfo, ref metaCreateInfo, ref hashSalt);
@ -237,12 +237,12 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// TODO: There's currently no program registry for FS to reference. // TODO: There's currently no program registry for FS to reference.
// Workaround that by setting the application ID if it's not already set // Workaround that by setting the application ID if it's not already set
if (attribute.TitleId == TitleId.Zero) if (attribute.ProgramId == ProgramId.InvalidId)
{ {
attribute.TitleId = new TitleId(context.Process.TitleId); attribute.ProgramId = new ProgramId(context.Process.TitleId);
} }
Result result = _baseFileSystemProxy.OpenSaveDataFileSystem(out LibHac.Fs.IFileSystem fileSystem, spaceId, ref attribute); Result result = _baseFileSystemProxy.OpenSaveDataFileSystem(out LibHac.Fs.Fsa.IFileSystem fileSystem, spaceId, ref attribute);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -259,7 +259,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
SaveDataSpaceId spaceId = (SaveDataSpaceId)context.RequestData.ReadInt64(); SaveDataSpaceId spaceId = (SaveDataSpaceId)context.RequestData.ReadInt64();
SaveDataAttribute attribute = context.RequestData.ReadStruct<SaveDataAttribute>(); SaveDataAttribute attribute = context.RequestData.ReadStruct<SaveDataAttribute>();
Result result = _baseFileSystemProxy.OpenSaveDataFileSystemBySystemSaveDataId(out LibHac.Fs.IFileSystem fileSystem, spaceId, ref attribute); Result result = _baseFileSystemProxy.OpenSaveDataFileSystemBySystemSaveDataId(out LibHac.Fs.Fsa.IFileSystem fileSystem, spaceId, ref attribute);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -278,12 +278,12 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// TODO: There's currently no program registry for FS to reference. // TODO: There's currently no program registry for FS to reference.
// Workaround that by setting the application ID if it's not already set // Workaround that by setting the application ID if it's not already set
if (attribute.TitleId == TitleId.Zero) if (attribute.ProgramId == ProgramId.InvalidId)
{ {
attribute.TitleId = new TitleId(context.Process.TitleId); attribute.ProgramId = new ProgramId(context.Process.TitleId);
} }
Result result = _baseFileSystemProxy.OpenReadOnlySaveDataFileSystem(out LibHac.Fs.IFileSystem fileSystem, spaceId, ref attribute); Result result = _baseFileSystemProxy.OpenReadOnlySaveDataFileSystem(out LibHac.Fs.Fsa.IFileSystem fileSystem, spaceId, ref attribute);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -296,7 +296,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
[Command(60)] [Command(60)]
public ResultCode OpenSaveDataInfoReader(ServiceCtx context) public ResultCode OpenSaveDataInfoReader(ServiceCtx context)
{ {
Result result = _baseFileSystemProxy.OpenSaveDataInfoReader(out LibHac.FsService.ISaveDataInfoReader infoReader); Result result = _baseFileSystemProxy.OpenSaveDataInfoReader(out ReferenceCountedDisposable<LibHac.FsSrv.ISaveDataInfoReader> infoReader);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -311,7 +311,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
{ {
SaveDataSpaceId spaceId = (SaveDataSpaceId)context.RequestData.ReadByte(); SaveDataSpaceId spaceId = (SaveDataSpaceId)context.RequestData.ReadByte();
Result result = _baseFileSystemProxy.OpenSaveDataInfoReaderBySaveDataSpaceId(out LibHac.FsService.ISaveDataInfoReader infoReader, spaceId); Result result = _baseFileSystemProxy.OpenSaveDataInfoReaderBySaveDataSpaceId(out ReferenceCountedDisposable<LibHac.FsSrv.ISaveDataInfoReader> infoReader, spaceId);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -326,12 +326,12 @@ namespace Ryujinx.HLE.HOS.Services.Fs
{ {
SaveDataFilter filter = new SaveDataFilter(); SaveDataFilter filter = new SaveDataFilter();
filter.SetSaveDataType(SaveDataType.Cache); filter.SetSaveDataType(SaveDataType.Cache);
filter.SetProgramId(new TitleId(context.Process.TitleId)); filter.SetProgramId(new ProgramId(context.Process.TitleId));
// FS would query the User and SdCache space IDs to find where the existing cache is (if any). // FS would query the User and SdCache space IDs to find where the existing cache is (if any).
// We always have the SD card inserted, so we can always use SdCache for now. // We always have the SD card inserted, so we can always use SdCache for now.
Result result = _baseFileSystemProxy.OpenSaveDataInfoReaderBySaveDataSpaceId( Result result = _baseFileSystemProxy.OpenSaveDataInfoReaderBySaveDataSpaceId(
out LibHac.FsService.ISaveDataInfoReader infoReader, SaveDataSpaceId.SdCache); out ReferenceCountedDisposable<LibHac.FsSrv.ISaveDataInfoReader> infoReader, SaveDataSpaceId.SdCache);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -366,7 +366,8 @@ namespace Ryujinx.HLE.HOS.Services.Fs
SaveDataSpaceId spaceId = (SaveDataSpaceId)context.RequestData.ReadInt64(); SaveDataSpaceId spaceId = (SaveDataSpaceId)context.RequestData.ReadInt64();
SaveDataFilter filter = context.RequestData.ReadStruct<SaveDataFilter>(); SaveDataFilter filter = context.RequestData.ReadStruct<SaveDataFilter>();
Result result = _baseFileSystemProxy.OpenSaveDataInfoReaderWithFilter(out LibHac.FsService.ISaveDataInfoReader infoReader, spaceId, ref filter); Result result = _baseFileSystemProxy.OpenSaveDataInfoReaderWithFilter(
out ReferenceCountedDisposable<LibHac.FsSrv.ISaveDataInfoReader> infoReader, spaceId, ref filter);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -478,7 +479,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// OpenDataStorageByCurrentProcess() -> object<nn::fssrv::sf::IStorage> dataStorage // OpenDataStorageByCurrentProcess() -> object<nn::fssrv::sf::IStorage> dataStorage
public ResultCode OpenDeviceOperator(ServiceCtx context) public ResultCode OpenDeviceOperator(ServiceCtx context)
{ {
Result result = _baseFileSystemProxy.OpenDeviceOperator(out LibHac.FsService.IDeviceOperator deviceOperator); Result result = _baseFileSystemProxy.OpenDeviceOperator(out LibHac.FsSrv.IDeviceOperator deviceOperator);
if (result.IsSuccess()) if (result.IsSuccess())
{ {
@ -558,7 +559,7 @@ namespace Ryujinx.HLE.HOS.Services.Fs
// OpenMultiCommitManager() -> object<nn::fssrv::sf::IMultiCommitManager> // OpenMultiCommitManager() -> object<nn::fssrv::sf::IMultiCommitManager>
public ResultCode OpenMultiCommitManager(ServiceCtx context) public ResultCode OpenMultiCommitManager(ServiceCtx context)
{ {
Result result = _baseFileSystemProxy.OpenMultiCommitManager(out LibHac.FsService.IMultiCommitManager commitManager); Result result = _baseFileSystemProxy.OpenMultiCommitManager(out LibHac.FsSrv.IMultiCommitManager commitManager);
if (result.IsSuccess()) if (result.IsSuccess())
{ {

4
Ryujinx.HLE/HOS/Services/Fs/IMultiCommitManager.cs
View file

@ -5,9 +5,9 @@ namespace Ryujinx.HLE.HOS.Services.Fs
{ {
class IMultiCommitManager : IpcService // 6.0.0+ class IMultiCommitManager : IpcService // 6.0.0+
{ {
private LibHac.FsService.IMultiCommitManager _baseCommitManager; private LibHac.FsSrv.IMultiCommitManager _baseCommitManager;
public IMultiCommitManager(LibHac.FsService.IMultiCommitManager baseCommitManager) public IMultiCommitManager(LibHac.FsSrv.IMultiCommitManager baseCommitManager)
{ {
_baseCommitManager = baseCommitManager; _baseCommitManager = baseCommitManager;
} }

16
Ryujinx.HLE/HOS/Services/Fs/ISaveDataInfoReader.cs
View file

@ -1,12 +1,13 @@
using LibHac; using System;
using LibHac;
namespace Ryujinx.HLE.HOS.Services.Fs namespace Ryujinx.HLE.HOS.Services.Fs
{ {
class ISaveDataInfoReader : IpcService class ISaveDataInfoReader : IpcService, IDisposable
{ {
private LibHac.FsService.ISaveDataInfoReader _baseReader; private ReferenceCountedDisposable<LibHac.FsSrv.ISaveDataInfoReader> _baseReader;
public ISaveDataInfoReader(LibHac.FsService.ISaveDataInfoReader baseReader) public ISaveDataInfoReader(ReferenceCountedDisposable<LibHac.FsSrv.ISaveDataInfoReader> baseReader)
{ {
_baseReader = baseReader; _baseReader = baseReader;
} }
@ -20,12 +21,17 @@ namespace Ryujinx.HLE.HOS.Services.Fs
byte[] infoBuffer = new byte[bufferLen]; byte[] infoBuffer = new byte[bufferLen];
Result result = _baseReader.ReadSaveDataInfo(out long readCount, infoBuffer); Result result = _baseReader.Target.Read(out long readCount, infoBuffer);
context.Memory.Write((ulong)bufferPosition, infoBuffer); context.Memory.Write((ulong)bufferPosition, infoBuffer);
context.ResponseData.Write(readCount); context.ResponseData.Write(readCount);
return (ResultCode)result.Value; return (ResultCode)result.Value;
} }
public void Dispose()
{
_baseReader.Dispose();
}
} }
} }

4
Ryujinx.HLE/HOS/Services/Mii/MiiDatabaseManager.cs
View file

@ -2,7 +2,6 @@
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Shim; using LibHac.Fs.Shim;
using LibHac.Ncm;
using Ryujinx.HLE.HOS.Services.Mii.Types; using Ryujinx.HLE.HOS.Services.Mii.Types;
using System.Runtime.CompilerServices; using System.Runtime.CompilerServices;
@ -137,7 +136,8 @@ namespace Ryujinx.HLE.HOS.Services.Mii
{ {
// TODO: We're currently always specifying the owner ID because FS doesn't have a way of // TODO: We're currently always specifying the owner ID because FS doesn't have a way of
// knowing which process called it // knowing which process called it
result = _filesystemClient.CreateSystemSaveData(targetSaveDataId, new TitleId(targetTitleId), 0x10000, 0x10000, SaveDataFlags.KeepAfterResettingSystemSaveDataWithoutUserSaveData); result = _filesystemClient.CreateSystemSaveData(targetSaveDataId, targetTitleId, 0x10000,
0x10000, SaveDataFlags.KeepAfterResettingSystemSaveDataWithoutUserSaveData);
if (result.IsFailure()) return result; if (result.IsFailure()) return result;
result = _filesystemClient.MountSystemSaveData(mountName, SaveDataSpaceId.System, targetSaveDataId); result = _filesystemClient.MountSystemSaveData(mountName, SaveDataSpaceId.System, targetSaveDataId);

2
Ryujinx.HLE/HOS/Services/Mii/Types/StoreData.cs
View file

@ -73,7 +73,7 @@ namespace Ryujinx.HLE.HOS.Services.Mii.Types
private ReadOnlySpan<byte> AsSpan() private ReadOnlySpan<byte> AsSpan()
{ {
return MemoryMarshal.AsBytes(SpanHelpers.CreateReadOnlySpan(ref this, 1)); return MemoryMarshal.AsBytes(SpanHelpers.CreateReadOnlySpan(in this, 1));
} }
private ReadOnlySpan<byte> AsSpanWithoutCrc() private ReadOnlySpan<byte> AsSpanWithoutCrc()

1
Ryujinx.HLE/HOS/Services/Settings/ISystemSettingsServer.cs
View file

@ -1,6 +1,7 @@
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;

1
Ryujinx.HLE/HOS/Services/Time/TimeZone/TimeZoneContentManager.cs
View file

@ -1,6 +1,7 @@
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;

7
Ryujinx.HLE/Loaders/Executables/KipExecutable.cs
View file

@ -1,5 +1,5 @@
using LibHac.Fs; using LibHac.Fs;
using LibHac.Loader; using LibHac.Kernel;
using System; using System;
namespace Ryujinx.HLE.Loaders.Executables namespace Ryujinx.HLE.Loaders.Executables
@ -31,6 +31,7 @@ namespace Ryujinx.HLE.Loaders.Executables
public byte IdealCoreId { get; } public byte IdealCoreId { get; }
public int Version { get; } public int Version { get; }
public string Name { get; } public string Name { get; }
public KipExecutable(IStorage inStorage) public KipExecutable(IStorage inStorage)
{ {
KipReader reader = new KipReader(); KipReader reader = new KipReader();
@ -70,11 +71,11 @@ namespace Ryujinx.HLE.Loaders.Executables
DataSize = DecompressSection(reader, KipReader.SegmentType.Data, DataOffset, Program); DataSize = DecompressSection(reader, KipReader.SegmentType.Data, DataOffset, Program);
} }
private static int DecompressSection(KipReader reader, KipReader.SegmentType segmentType, int offset, byte[] Program) private static int DecompressSection(KipReader reader, KipReader.SegmentType segmentType, int offset, byte[] program)
{ {
reader.GetSegmentSize(segmentType, out int uncompressedSize).ThrowIfFailure(); reader.GetSegmentSize(segmentType, out int uncompressedSize).ThrowIfFailure();
var span = Program.AsSpan().Slice(offset, uncompressedSize); var span = program.AsSpan().Slice(offset, uncompressedSize);
reader.ReadSegment(segmentType, span).ThrowIfFailure(); reader.ReadSegment(segmentType, span).ThrowIfFailure();

2
Ryujinx.HLE/Ryujinx.HLE.csproj
View file

@ -46,7 +46,7 @@
<ItemGroup> <ItemGroup>
<PackageReference Include="Concentus" Version="1.1.7" /> <PackageReference Include="Concentus" Version="1.1.7" />
<PackageReference Include="LibHac" Version="0.11.3" /> <PackageReference Include="LibHac" Version="0.12.0" />
<PackageReference Include="MsgPack.Cli" Version="1.0.1" /> <PackageReference Include="MsgPack.Cli" Version="1.0.1" />
</ItemGroup> </ItemGroup>

9
Ryujinx/Ui/ApplicationLibrary.cs
View file

@ -1,12 +1,10 @@
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Shim; using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using LibHac.Ncm;
using LibHac.Ns; using LibHac.Ns;
using LibHac.Spl;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;
using Ryujinx.Common.Configuration; using Ryujinx.Common.Configuration;
using Ryujinx.Configuration.System; using Ryujinx.Configuration.System;
@ -14,13 +12,11 @@ using Ryujinx.HLE.FileSystem;
using Ryujinx.HLE.Loaders.Npdm; using Ryujinx.HLE.Loaders.Npdm;
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Globalization;
using System.IO; using System.IO;
using System.Reflection; using System.Reflection;
using System.Text; using System.Text;
using System.Text.Json; using System.Text.Json;
using RightsId = LibHac.Fs.RightsId;
using JsonHelper = Ryujinx.Common.Utilities.JsonHelper; using JsonHelper = Ryujinx.Common.Utilities.JsonHelper;
namespace Ryujinx.Ui namespace Ryujinx.Ui
@ -212,9 +208,6 @@ namespace Ryujinx.Ui
ReadControlData(controlFs, controlHolder.ByteSpan); ReadControlData(controlFs, controlHolder.ByteSpan);
// Creates NACP class from the NACP file
controlFs.OpenFile(out IFile controlNacpFile, "/control.nacp".ToU8Span(), OpenMode.Read).ThrowIfFailure();
// Get the title name, title ID, developer name and version number from the NACP // Get the title name, title ID, developer name and version number from the NACP
version = IsUpdateApplied(titleId, out string updateVersion) ? updateVersion : controlHolder.Value.DisplayVersion.ToString(); version = IsUpdateApplied(titleId, out string updateVersion) ? updateVersion : controlHolder.Value.DisplayVersion.ToString();

3
Ryujinx/Ui/DlcWindow.cs
View file

@ -1,9 +1,10 @@
using Gtk; using Gtk;
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.FsSystem.NcaUtils;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils;
using Ryujinx.Common.Configuration; using Ryujinx.Common.Configuration;
using Ryujinx.Common.Logging; using Ryujinx.Common.Logging;
using Ryujinx.HLE.FileSystem; using Ryujinx.HLE.FileSystem;

13
Ryujinx/Ui/GameTableContextMenu.cs
View file

@ -3,6 +3,7 @@ using LibHac;
using LibHac.Account; using LibHac.Account;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.Fs.Shim; using LibHac.Fs.Shim;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
@ -45,19 +46,19 @@ namespace Ryujinx.Ui
MenuItem openSaveUserDir = new MenuItem("Open User Save Directory") MenuItem openSaveUserDir = new MenuItem("Open User Save Directory")
{ {
Sensitive = !Util.IsEmpty(controlData.ByteSpan) && controlData.Value.UserAccountSaveDataSize > 0, Sensitive = !Utilities.IsEmpty(controlData.ByteSpan) && controlData.Value.UserAccountSaveDataSize > 0,
TooltipText = "Open the directory which contains Application's User Saves." TooltipText = "Open the directory which contains Application's User Saves."
}; };
MenuItem openSaveDeviceDir = new MenuItem("Open Device Save Directory") MenuItem openSaveDeviceDir = new MenuItem("Open Device Save Directory")
{ {
Sensitive = !Util.IsEmpty(controlData.ByteSpan) && controlData.Value.DeviceSaveDataSize > 0, Sensitive = !Utilities.IsEmpty(controlData.ByteSpan) && controlData.Value.DeviceSaveDataSize > 0,
TooltipText = "Open the directory which contains Application's Device Saves." TooltipText = "Open the directory which contains Application's Device Saves."
}; };
MenuItem openSaveBcatDir = new MenuItem("Open BCAT Save Directory") MenuItem openSaveBcatDir = new MenuItem("Open BCAT Save Directory")
{ {
Sensitive = !Util.IsEmpty(controlData.ByteSpan) && controlData.Value.BcatDeliveryCacheStorageSize > 0, Sensitive = !Utilities.IsEmpty(controlData.ByteSpan) && controlData.Value.BcatDeliveryCacheStorageSize > 0,
TooltipText = "Open the directory which contains Application's BCAT Saves." TooltipText = "Open the directory which contains Application's BCAT Saves."
}; };
@ -175,7 +176,7 @@ namespace Ryujinx.Ui
ref ApplicationControlProperty control = ref controlHolder.Value; ref ApplicationControlProperty control = ref controlHolder.Value;
if (LibHac.Util.IsEmpty(controlHolder.ByteSpan)) if (LibHac.Utilities.IsEmpty(controlHolder.ByteSpan))
{ {
// If the current application doesn't have a loaded control property, create a dummy one // If the current application doesn't have a loaded control property, create a dummy one
// and set the savedata sizes so a user savedata will be created. // and set the savedata sizes so a user savedata will be created.
@ -191,7 +192,7 @@ namespace Ryujinx.Ui
Uid user = new Uid(1, 0); Uid user = new Uid(1, 0);
result = EnsureApplicationSaveData(_virtualFileSystem.FsClient, out _, new TitleId(titleId), ref control, ref user); result = EnsureApplicationSaveData(_virtualFileSystem.FsClient, out _, new LibHac.Ncm.ApplicationId(titleId), ref control, ref user);
if (result.IsFailure()) if (result.IsFailure())
{ {
@ -539,7 +540,7 @@ namespace Ryujinx.Ui
private void OpenSaveDir(string titleName, ulong titleId, SaveDataFilter filter) private void OpenSaveDir(string titleName, ulong titleId, SaveDataFilter filter)
{ {
filter.SetProgramId(new TitleId(titleId)); filter.SetProgramId(new ProgramId(titleId));
if (!TryFindSaveData(titleName, titleId, _controlData, filter, out ulong saveDataId)) if (!TryFindSaveData(titleName, titleId, _controlData, filter, out ulong saveDataId))
{ {

8
Ryujinx/Ui/SaveImporter.cs
View file

@ -11,6 +11,8 @@ using System.IO;
using System.Linq; using System.Linq;
using System.Runtime.CompilerServices; using System.Runtime.CompilerServices;
using ApplicationId = LibHac.Ncm.ApplicationId;
namespace Ryujinx.Ui namespace Ryujinx.Ui
{ {
internal class SaveImporter internal class SaveImporter
@ -57,7 +59,7 @@ namespace Ryujinx.Ui
{ {
SaveDataAttribute key = save.Attribute; SaveDataAttribute key = save.Attribute;
Result result = fs.CreateSaveData(key.TitleId, key.UserId, key.TitleId, 0, 0, 0); Result result = fs.CreateSaveData(new ApplicationId(key.ProgramId.Value), key.UserId, key.ProgramId.Value, 0, 0, 0);
if (result.IsFailure()) return result; if (result.IsFailure()) return result;
bool isOldMounted = false; bool isOldMounted = false;
@ -70,7 +72,7 @@ namespace Ryujinx.Ui
isOldMounted = true; isOldMounted = true;
result = fs.MountSaveData("NewSave".ToU8Span(), key.TitleId, key.UserId); result = fs.MountSaveData("NewSave".ToU8Span(), new ApplicationId(key.ProgramId.Value), key.UserId);
if (result.IsFailure()) return result; if (result.IsFailure()) return result;
isNewMounted = true; isNewMounted = true;
@ -132,7 +134,7 @@ namespace Ryujinx.Ui
{ {
Type = SaveDataType.Account, Type = SaveDataType.Account,
UserId = userId, UserId = userId,
TitleId = new TitleId(titleId) ProgramId = new ProgramId(titleId)
}; };
SaveToImport save = new SaveToImport(dataPath, attribute); SaveToImport save = new SaveToImport(dataPath, attribute);

1
Ryujinx/Ui/TitleUpdateWindow.cs
View file

@ -2,6 +2,7 @@ using Gtk;
using LibHac; using LibHac;
using LibHac.Common; using LibHac.Common;
using LibHac.Fs; using LibHac.Fs;
using LibHac.Fs.Fsa;
using LibHac.FsSystem; using LibHac.FsSystem;
using LibHac.FsSystem.NcaUtils; using LibHac.FsSystem.NcaUtils;
using LibHac.Ns; using LibHac.Ns;