From 456fc04007b7274f6e75d6348c5a4e955f85b488 Mon Sep 17 00:00:00 2001 From: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com> Date: Thu, 1 Dec 2022 11:53:13 -0500 Subject: [PATCH] Better SDL2 Audio Init Error Logging (#3967) * Better SDL2 Audio Init Error Logging * Update Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs Co-authored-by: Mary-nyan * Update Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs Co-authored-by: Mary-nyan * Update Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs Co-authored-by: Mary-nyan * Update Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs Co-authored-by: Ac_K * Update Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs Co-authored-by: Ac_K * Update SDL2HardwareDeviceDriver.cs * Update SDL2HardwareDeviceDriver.cs Co-authored-by: Mary-nyan Co-authored-by: Ac_K --- Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs | 5 +++++ Ryujinx.SDL2.Common/SDL2Driver.cs | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs b/Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs index 3953b809e..b190b4c83 100644 --- a/Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs +++ b/Ryujinx.Audio.Backends.SDL2/SDL2HardwareDeviceDriver.cs @@ -1,5 +1,6 @@ using Ryujinx.Audio.Common; using Ryujinx.Audio.Integration; +using Ryujinx.Common.Logging; using Ryujinx.Memory; using Ryujinx.SDL2.Common; using System; @@ -112,6 +113,9 @@ namespace Ryujinx.Audio.Backends.SDL2 if (device == 0) { + Logger.Error?.Print(LogClass.Application, + $"SDL2 open audio device initialization failed with error \"{SDL_GetError()}\""); + return 0; } @@ -119,6 +123,7 @@ namespace Ryujinx.Audio.Backends.SDL2 if (!isValid) { + Logger.Error?.Print(LogClass.Application, "SDL2 open audio device is not valid"); SDL_CloseAudioDevice(device); return 0; diff --git a/Ryujinx.SDL2.Common/SDL2Driver.cs b/Ryujinx.SDL2.Common/SDL2Driver.cs index 4a30523c3..9d8dacf84 100644 --- a/Ryujinx.SDL2.Common/SDL2Driver.cs +++ b/Ryujinx.SDL2.Common/SDL2Driver.cs @@ -69,7 +69,7 @@ namespace Ryujinx.SDL2.Common if (SDL_Init(SdlInitFlags) != 0) { - string errorMessage = $"SDL2 initlaization failed with error \"{SDL_GetError()}\""; + string errorMessage = $"SDL2 initialization failed with error \"{SDL_GetError()}\""; Logger.Error?.Print(LogClass.Application, errorMessage);