From 6345786ea5471686c2b1a8fe9f1a22e38aa564c5 Mon Sep 17 00:00:00 2001 From: sunshineinabox Date: Sat, 18 May 2024 14:57:53 -0700 Subject: [PATCH] Add Some Comments --- src/Ryujinx.Graphics.Vulkan/PipelineState.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Ryujinx.Graphics.Vulkan/PipelineState.cs b/src/Ryujinx.Graphics.Vulkan/PipelineState.cs index b1b4fd92c7..e1f3f373aa 100644 --- a/src/Ryujinx.Graphics.Vulkan/PipelineState.cs +++ b/src/Ryujinx.Graphics.Vulkan/PipelineState.cs @@ -452,6 +452,7 @@ namespace Ryujinx.Graphics.Vulkan primitiveRestartEnable &= topologySupportsRestart; + //Cannot disable primitveRestartEnable for these Topoligies on MacOS if ((Topology == PrimitiveTopology.LineStrip || Topology == PrimitiveTopology.TriangleStrip || Topology == PrimitiveTopology.LineStripWithAdjacency || Topology == PrimitiveTopology.TriangleStripWithAdjacency) && isMoltenVk) @@ -690,6 +691,7 @@ namespace Ryujinx.Graphics.Vulkan if (!isMoltenVk) { + //LineWidth is only supported on MacOS when using Metal Private API on newer version of MoltenVK dynamicStates[currentIndex++] = DynamicState.LineWidth; } @@ -697,6 +699,7 @@ namespace Ryujinx.Graphics.Vulkan { if (!isMoltenVk) { + //Requires Metal 3.1 dynamicStates[currentIndex++] = DynamicState.VertexInputBindingStrideExt; } dynamicStates[currentIndex++] = DynamicState.CullModeExt;