From 6c76bc3bc0ecd1d3a86cf4e8c396c71370274ba1 Mon Sep 17 00:00:00 2001 From: riperiperi Date: Fri, 20 Aug 2021 22:09:30 +0100 Subject: [PATCH] Change disabled vertex attribute value to (0, 0, 0, 1) (#2573) This seems to be the default value when the vertex attribute is disabled, or components aren't defined. This fixes a regression from #2307 in SMO where a plant in the Wooded Kingdom would draw slightly differently in the depth prepass, leading to depth test failing later on. GDK has stated that the specific case in Gundam only expects x and y to be 0, and Vulkan's undefined value for z does appear to be 0 when a vertex attribute type does not have that component, hence the value (0, 0, 0, 1). This worked in Vulkan despite also providing an all 0s attribute due to the vertex attribute binding being R32Float, so the other values were undefined. It should be changed there separately. --- Ryujinx.Graphics.OpenGL/VertexArray.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Ryujinx.Graphics.OpenGL/VertexArray.cs b/Ryujinx.Graphics.OpenGL/VertexArray.cs index b31bf723b5..f2fcba1f0b 100644 --- a/Ryujinx.Graphics.OpenGL/VertexArray.cs +++ b/Ryujinx.Graphics.OpenGL/VertexArray.cs @@ -176,7 +176,7 @@ namespace Ryujinx.Graphics.OpenGL { _vertexAttribsInUse &= ~mask; GL.DisableVertexAttribArray(index); - GL.VertexAttrib4(index, 0f, 0f, 0f, 0f); + GL.VertexAttrib4(index, 0f, 0f, 0f, 1f); } }