From e2cfe6fe44b62d7aba1425ae2e621f50045f406c Mon Sep 17 00:00:00 2001 From: gdkchan Date: Sun, 10 Sep 2023 22:22:18 -0300 Subject: [PATCH] Fix shader GlobalToStorage pass when base address comes from local or shared memory (#5668) * Fix shader GlobalToStorage pass when base address comes from local or shared memory * Shader cache version bump --- .../Shader/DiskCache/DiskCacheHostStorage.cs | 2 +- .../Translation/Optimizations/GlobalToStorage.cs | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Ryujinx.Graphics.Gpu/Shader/DiskCache/DiskCacheHostStorage.cs b/src/Ryujinx.Graphics.Gpu/Shader/DiskCache/DiskCacheHostStorage.cs index 99ef89ed92..4b99bb0970 100644 --- a/src/Ryujinx.Graphics.Gpu/Shader/DiskCache/DiskCacheHostStorage.cs +++ b/src/Ryujinx.Graphics.Gpu/Shader/DiskCache/DiskCacheHostStorage.cs @@ -22,7 +22,7 @@ namespace Ryujinx.Graphics.Gpu.Shader.DiskCache private const ushort FileFormatVersionMajor = 1; private const ushort FileFormatVersionMinor = 2; private const uint FileFormatVersionPacked = ((uint)FileFormatVersionMajor << 16) | FileFormatVersionMinor; - private const uint CodeGenVersion = 5551; + private const uint CodeGenVersion = 5668; private const string SharedTocFileName = "shared.toc"; private const string SharedDataFileName = "shared.data"; diff --git a/src/Ryujinx.Graphics.Shader/Translation/Optimizations/GlobalToStorage.cs b/src/Ryujinx.Graphics.Shader/Translation/Optimizations/GlobalToStorage.cs index 0f043f772b..e426d54de1 100644 --- a/src/Ryujinx.Graphics.Shader/Translation/Optimizations/GlobalToStorage.cs +++ b/src/Ryujinx.Graphics.Shader/Translation/Optimizations/GlobalToStorage.cs @@ -1126,7 +1126,7 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations // so we want to get the byte offset back, since each one of those word // offsets are a new "local variable" which will not match. - if (operation.GetSource(0).AsgOp is Operation shiftRightOp && + if (operation.GetSource(1).AsgOp is Operation shiftRightOp && shiftRightOp.Inst == Instruction.ShiftRightU32 && shiftRightOp.GetSource(1).Type == OperandType.Constant && shiftRightOp.GetSource(1).Value == 2) @@ -1158,9 +1158,11 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations private static bool TryGetLocalMemoryOffset(Operation operation, out int constOffset) { - if (operation.GetSource(0).Type == OperandType.Constant) + Operand offset = operation.GetSource(1); + + if (offset.Type == OperandType.Constant) { - constOffset = operation.GetSource(0).Value; + constOffset = offset.Value; return true; }