From eeecd894b920701e728eecf41a3f2baa88e3776d Mon Sep 17 00:00:00 2001 From: sunshineinabox Date: Sat, 18 May 2024 14:57:53 -0700 Subject: [PATCH] Add Some Comments --- src/Ryujinx.Graphics.Vulkan/PipelineState.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Ryujinx.Graphics.Vulkan/PipelineState.cs b/src/Ryujinx.Graphics.Vulkan/PipelineState.cs index e4fe002d95..57b531575a 100644 --- a/src/Ryujinx.Graphics.Vulkan/PipelineState.cs +++ b/src/Ryujinx.Graphics.Vulkan/PipelineState.cs @@ -451,6 +451,7 @@ namespace Ryujinx.Graphics.Vulkan primitiveRestartEnable &= topologySupportsRestart; + //Cannot disable primitveRestartEnable for these Topoligies on MacOS if ((Topology == PrimitiveTopology.LineStrip || Topology == PrimitiveTopology.TriangleStrip || Topology == PrimitiveTopology.LineStripWithAdjacency || Topology == PrimitiveTopology.TriangleStripWithAdjacency) && isMoltenVk) @@ -675,6 +676,7 @@ namespace Ryujinx.Graphics.Vulkan if (!isMoltenVk) { + //LineWidth is only supported on MacOS when using Metal Private API on newer version of MoltenVK dynamicStates[currentIndex++] = DynamicState.LineWidth; } @@ -682,6 +684,7 @@ namespace Ryujinx.Graphics.Vulkan { if (!isMoltenVk) { + //Requires Metal 3.1 dynamicStates[currentIndex++] = DynamicState.VertexInputBindingStrideExt; } dynamicStates[currentIndex++] = DynamicState.CullModeExt;