f23b2878cc
We have a conversion from LDG on the compute shader to a special constant buffer binding that's used to exceed hardware limits on compute, but it was only running if the byte offset could be identified. The fallback that checks all of the bindings at runtime only checks the storage buffers. This PR adds checking ube ranges to the LoadGlobal fallback. This extends the changes in #4011 to only check ube entries which are accessed by the shader. Fixes particles affected by the wind in The Legend of Zelda: Breath of the Wild. May fix other weird issues with compute shaders in some games. Try a bunch of games and drivers to make sure they don't blow up loading constants willynilly from searchable buffers.
57 lines
No EOL
2.2 KiB
C#
57 lines
No EOL
2.2 KiB
C#
using Ryujinx.Graphics.Shader.IntermediateRepresentation;
|
|
|
|
namespace Ryujinx.Graphics.Shader.Translation
|
|
{
|
|
static class GlobalMemory
|
|
{
|
|
private const int StorageDescsBaseOffset = 0x44; // In words.
|
|
|
|
public const int StorageDescSize = 4; // In words.
|
|
public const int StorageMaxCount = 16;
|
|
|
|
public const int StorageDescsSize = StorageDescSize * StorageMaxCount;
|
|
|
|
public const int UbeBaseOffset = 0x98; // In words.
|
|
public const int UbeMaxCount = 9;
|
|
public const int UbeDescsSize = StorageDescSize * UbeMaxCount;
|
|
public const int UbeFirstCbuf = 8;
|
|
|
|
public static bool UsesGlobalMemory(Instruction inst)
|
|
{
|
|
return (inst.IsAtomic() && IsGlobalMr(inst)) ||
|
|
inst == Instruction.LoadGlobal ||
|
|
inst == Instruction.StoreGlobal ||
|
|
inst == Instruction.StoreGlobal16 ||
|
|
inst == Instruction.StoreGlobal8;
|
|
}
|
|
|
|
private static bool IsGlobalMr(Instruction inst)
|
|
{
|
|
return (inst & Instruction.MrMask) == Instruction.MrGlobal;
|
|
}
|
|
|
|
public static int GetStorageCbOffset(ShaderStage stage, int slot)
|
|
{
|
|
return GetStorageBaseCbOffset(stage) + slot * StorageDescSize;
|
|
}
|
|
|
|
public static int GetStorageBaseCbOffset(ShaderStage stage)
|
|
{
|
|
return stage switch
|
|
{
|
|
ShaderStage.Compute => StorageDescsBaseOffset + 2 * StorageDescsSize,
|
|
ShaderStage.Vertex => StorageDescsBaseOffset,
|
|
ShaderStage.TessellationControl => StorageDescsBaseOffset + 1 * StorageDescsSize,
|
|
ShaderStage.TessellationEvaluation => StorageDescsBaseOffset + 2 * StorageDescsSize,
|
|
ShaderStage.Geometry => StorageDescsBaseOffset + 3 * StorageDescsSize,
|
|
ShaderStage.Fragment => StorageDescsBaseOffset + 4 * StorageDescsSize,
|
|
_ => 0
|
|
};
|
|
}
|
|
|
|
public static int GetConstantUbeOffset(int slot)
|
|
{
|
|
return UbeBaseOffset + slot * StorageDescSize;
|
|
}
|
|
}
|
|
} |