From 129b8935097f76fc10ccd404006bdb6caa45c34f Mon Sep 17 00:00:00 2001 From: wwylele Date: Fri, 18 May 2018 14:08:12 +0300 Subject: [PATCH] gl_stream_buffer: update the information about the AMD hack --- src/video_core/renderer_opengl/gl_stream_buffer.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/video_core/renderer_opengl/gl_stream_buffer.cpp b/src/video_core/renderer_opengl/gl_stream_buffer.cpp index 5bd0f21a8..1957cfbcc 100644 --- a/src/video_core/renderer_opengl/gl_stream_buffer.cpp +++ b/src/video_core/renderer_opengl/gl_stream_buffer.cpp @@ -17,9 +17,10 @@ OGLStreamBuffer::OGLStreamBuffer(GLenum target, GLsizeiptr size, bool prefer_coh GLsizeiptr allocate_size = size; if (target == GL_ARRAY_BUFFER) { // On AMD GPU there is a strange crash in indexed drawing. The crash happens when the buffer - // read position is near the end and the crash looks like an out-of-bound access. Doubling - // the allocation size for the vertex buffer seems to avoid the crash. - // TODO (wwylele): investigate what actually happens here. + // read position is near the end and is an out-of-bound access to the vertex buffer. This is + // probably a bug in the driver and is related to the usage of vec3 attributes in the + // vertex array. Doubling the allocation size for the vertex buffer seems to avoid the + // crash. allocate_size *= 2; }