Address review comments

This commit is contained in:
FearlessTobi 2019-09-22 20:48:32 +02:00
parent a5d880979c
commit 1e93f568b5
3 changed files with 4 additions and 3 deletions

View file

@ -109,7 +109,7 @@ void ConfigureGraphics::updateShaders(bool anaglyph) {
} }
} }
void ConfigureGraphics::UpdateBackgroundColorButton(QColor color) { void ConfigureGraphics::UpdateBackgroundColorButton(const QColor& color) {
bg_color = color; bg_color = color;
QPixmap pixmap(ui->bg_button->size()); QPixmap pixmap(ui->bg_button->size());

View file

@ -22,7 +22,7 @@ public:
void RetranslateUI(); void RetranslateUI();
void SetConfiguration(); void SetConfiguration();
void UpdateBackgroundColorButton(QColor color); void UpdateBackgroundColorButton(const QColor& color);
std::unique_ptr<Ui::ConfigureGraphics> ui; std::unique_ptr<Ui::ConfigureGraphics> ui;
QColor bg_color; QColor bg_color;

View file

@ -4,7 +4,6 @@
#pragma once #pragma once
#include <QList>
#include <QMenu> #include <QMenu>
#include <QString> #include <QString>
#include <QVector> #include <QVector>
@ -21,6 +20,8 @@ class QFileSystemWatcher;
class QHBoxLayout; class QHBoxLayout;
class QLabel; class QLabel;
class QLineEdit; class QLineEdit;
template <typename>
class QList;
class QModelIndex; class QModelIndex;
class QStandardItem; class QStandardItem;
class QStandardItemModel; class QStandardItemModel;