Fix compilation problems and code issues

src/citra_qt/main.cpp

@@ -79,6 +79,7 @@
 #include "common/memory_detect.h"
 #include "common/scm_rev.h"
 #include "common/scope_exit.h"
+#include "common/string_util.h"
 #if CITRA_ARCH(x86_64)
 #include "common/x64/cpu_detect.h"
 #endif

src/citra_qt/main.h

@@ -5,7 +5,6 @@
 #pragma once
 
 #include <array>
-#include <filesystem>
 #include <memory>
 #include <vector>
 #include <QMainWindow>
@@ -22,6 +21,9 @@
 #include <QDBusObjectPath>
 #endif
 
+// Needs to be included at the end due to https://bugreports.qt.io/browse/QTBUG-73263
+#include <filesystem>
+
 class AboutDialog;
 class Config;
 class ClickableLabel;

src/citra_qt/util/util.cpp

@@ -43,7 +43,7 @@ QPixmap CreateCirclePixmapFromColor(const QColor& color) {
     return circle_pixmap;
 }
 
-QPixmap GetQPixmapFromSMDH(std::vector<u8>& smdh_data) {
+QPixmap GetQPixmapFromSMDH(const std::vector<u8>& smdh_data) {
     Loader::SMDH smdh;
     std::memcpy(&smdh, smdh_data.data(), sizeof(Loader::SMDH));
 

src/citra_qt/util/util.h

@@ -26,7 +26,7 @@ QPixmap CreateCirclePixmapFromColor(const QColor& color);
  * @param smdh_data SMDH data
  * @return QPixmap game icon
  */
-QPixmap GetQPixmapFromSMDH(std::vector<u8>& smdh_data);
+QPixmap GetQPixmapFromSMDH(const std::vector<u8>& smdh_data);
 
 /**
  * Saves a windows icon to a file

src/common/file_util.h

@@ -10,6 +10,7 @@
 #include <ios>
 #include <limits>
 #include <optional>
+#include <span>
 #include <string>
 #include <string_view>
 #include <type_traits>