N-archive/citra
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

sw_rasterizer: don't include the bias in the barycentric coords

Browse source
This commit is contained in:
Vitor Kiguchi 2024-02-05 17:13:56 -03:00
parent 5a9bb045d7
commit 265ed7ec14
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/video_core/renderer_software/sw_rasterizer.cpp
View file

@ -30,7 +30,7 @@ using Pica::Texture::TextureInfo;
// negative/positive z values when computing with f32 precision, // negative/positive z values when computing with f32 precision,
// causing some vertices to get erroneously clipped. To workaround this problem, // causing some vertices to get erroneously clipped. To workaround this problem,
// we can use a very small epsilon value for clip plane comparison. // we can use a very small epsilon value for clip plane comparison.
constexpr f32 EPSILON_Z = 0.00000001f; constexpr f32 EPSILON_Z = 0.f;
struct Vertex : Pica::OutputVertex { struct Vertex : Pica::OutputVertex {
Vertex(const OutputVertex& v) : OutputVertex(v) {} Vertex(const OutputVertex& v) : OutputVertex(v) {}
@ -286,11 +286,11 @@ void RasterizerSoftware::ProcessTriangle(const Vertex& v0, const Vertex& v1, con
max_y = ((max_y + Fix12P4::FracMask()) & Fix12P4::IntMask()); max_y = ((max_y + Fix12P4::FracMask()) & Fix12P4::IntMask());
const int bias0 = const int bias0 =
IsRightSideOrFlatBottomEdge(vtxpos[0].xy(), vtxpos[1].xy(), vtxpos[2].xy()) ? -1 : 0; IsRightSideOrFlatBottomEdge(vtxpos[0].xy(), vtxpos[1].xy(), vtxpos[2].xy()) ? 1 : 0;
const int bias1 = const int bias1 =
IsRightSideOrFlatBottomEdge(vtxpos[1].xy(), vtxpos[2].xy(), vtxpos[0].xy()) ? -1 : 0; IsRightSideOrFlatBottomEdge(vtxpos[1].xy(), vtxpos[2].xy(), vtxpos[0].xy()) ? 1 : 0;
const int bias2 = const int bias2 =
IsRightSideOrFlatBottomEdge(vtxpos[2].xy(), vtxpos[0].xy(), vtxpos[1].xy()) ? -1 : 0; IsRightSideOrFlatBottomEdge(vtxpos[2].xy(), vtxpos[0].xy(), vtxpos[1].xy()) ? 1 : 0;
const auto w_inverse = Common::MakeVec(v0.pos.w, v1.pos.w, v2.pos.w); const auto w_inverse = Common::MakeVec(v0.pos.w, v1.pos.w, v2.pos.w);
@ -313,13 +313,13 @@ void RasterizerSoftware::ProcessTriangle(const Vertex& v0, const Vertex& v1, con
} }
// Calculate the barycentric coordinates w0, w1 and w2 // Calculate the barycentric coordinates w0, w1 and w2
const s32 w0 = bias0 + SignedArea(vtxpos[1].xy(), vtxpos[2].xy(), {x, y}); const s32 w0 = SignedArea(vtxpos[1].xy(), vtxpos[2].xy(), {x, y});
const s32 w1 = bias1 + SignedArea(vtxpos[2].xy(), vtxpos[0].xy(), {x, y}); const s32 w1 = SignedArea(vtxpos[2].xy(), vtxpos[0].xy(), {x, y});
const s32 w2 = bias2 + SignedArea(vtxpos[0].xy(), vtxpos[1].xy(), {x, y}); const s32 w2 = SignedArea(vtxpos[0].xy(), vtxpos[1].xy(), {x, y});
const s32 wsum = w0 + w1 + w2; const s32 wsum = w0 + w1 + w2;
// If current pixel is not covered by the current primitive // If current pixel is not covered by the current primitive
if (w0 < 0 || w1 < 0 || w2 < 0) { if (w0 < bias0 || w1 < bias1 || w2 < bias2) {
continue; continue;
} }