From 8e2d9f48f5b90893c7ffd43ec745283fe6308bab Mon Sep 17 00:00:00 2001 From: Subv Date: Sun, 1 Oct 2017 21:59:38 -0500 Subject: [PATCH] Kernel/IPC: Remove dead buffer translation code. This is all implemented elsewhere, HLERequestContext for HLE requests, and svcReplyAndReceive for LLE requests. --- src/core/hle/kernel/server_session.cpp | 9 --------- src/core/hle/kernel/server_session.h | 9 --------- 2 files changed, 18 deletions(-) diff --git a/src/core/hle/kernel/server_session.cpp b/src/core/hle/kernel/server_session.cpp index 337896abf..87d2d1ecb 100644 --- a/src/core/hle/kernel/server_session.cpp +++ b/src/core/hle/kernel/server_session.cpp @@ -61,12 +61,7 @@ ResultCode ServerSession::HandleSyncRequest(SharedPtr thread) { // If this ServerSession has an associated HLE handler, forward the request to it. if (hle_handler != nullptr) { - // Attempt to translate the incoming request's command buffer. - ResultCode result = TranslateHLERequest(this); - if (result.IsError()) - return result; hle_handler->HandleSyncRequest(SharedPtr(this)); - // TODO(Subv): Translate the response command buffer. } else { // Add the thread to the list of threads that have issued a sync request with this // server. @@ -96,8 +91,4 @@ ServerSession::SessionPair ServerSession::CreateSessionPair(const std::string& n return std::make_tuple(std::move(server_session), std::move(client_session)); } -ResultCode TranslateHLERequest(ServerSession* server_session) { - // TODO(Subv): Implement this function once multiple concurrent processes are supported. - return RESULT_SUCCESS; -} } // namespace Kernel diff --git a/src/core/hle/kernel/server_session.h b/src/core/hle/kernel/server_session.h index f4360ddf3..cff8e7f86 100644 --- a/src/core/hle/kernel/server_session.h +++ b/src/core/hle/kernel/server_session.h @@ -104,13 +104,4 @@ private: static ResultVal> Create(std::string name = "Unknown"); }; -/** - * Performs command buffer translation for an HLE IPC request. - * The command buffer from the ServerSession thread's TLS is copied into a - * buffer and all descriptors in the buffer are processed. - * TODO(Subv): Implement this function, currently we do not support multiple processes running at - * once, but once that is implemented we'll need to properly translate all descriptors - * in the command buffer. - */ -ResultCode TranslateHLERequest(ServerSession* server_session); }