From 9c0c817e6ff0b1f8baa14b2c27315964519afe7f Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sun, 2 Dec 2018 14:06:39 -0500
Subject: [PATCH] yuzu/configuration/configure_input: Default destructor in the
 cpp file

The previous code could potentially be a compilation issue waiting to
occur, given we forward declare the type for a std::unique_ptr. If the
complete definition of the forward declared type isn't visible in a
translation unit that the class is used in, then it would fail to
compile.

Defaulting the destructor in a cpp file ensures the std::unique_ptr's
destructor is only invoked where its complete type is known.
---
 src/citra_qt/configuration/configure_input.cpp | 2 ++
 src/citra_qt/configuration/configure_input.h   | 1 +
 2 files changed, 3 insertions(+)

diff --git a/src/citra_qt/configuration/configure_input.cpp b/src/citra_qt/configuration/configure_input.cpp
index c0c9aaeb1..b0cc53395 100644
--- a/src/citra_qt/configuration/configure_input.cpp
+++ b/src/citra_qt/configuration/configure_input.cpp
@@ -221,6 +221,8 @@ ConfigureInput::ConfigureInput(QWidget* parent)
     ui->buttonHome->setEnabled(false);
 }
 
+ConfigureInput::~ConfigureInput() = default;
+
 void ConfigureInput::applyConfiguration() {
     std::transform(buttons_param.begin(), buttons_param.end(), Settings::values.buttons.begin(),
                    [](const Common::ParamPackage& param) { return param.Serialize(); });
diff --git a/src/citra_qt/configuration/configure_input.h b/src/citra_qt/configuration/configure_input.h
index 0f8ce7d1b..aa3cce7a5 100644
--- a/src/citra_qt/configuration/configure_input.h
+++ b/src/citra_qt/configuration/configure_input.h
@@ -30,6 +30,7 @@ class ConfigureInput : public QWidget {
 
 public:
     explicit ConfigureInput(QWidget* parent = nullptr);
+    ~ConfigureInput() override;
 
     /// Save all button configurations to settings file
     void applyConfiguration();