Address a bunch of review comments

This commit is contained in:
fearlessTobi 2018-09-17 17:16:01 +02:00 committed by Weiyi Wang
parent 1de63f9b16
commit b0aed19823
10 changed files with 21 additions and 14 deletions

View file

@ -25,7 +25,11 @@ CompatDB::CompatDB(QWidget* parent)
CompatDB::~CompatDB() = default; CompatDB::~CompatDB() = default;
enum class CompatDBPage { Intro = 0, Selection = 1, Final = 2 }; enum class CompatDBPage {
Intro = 0,
Selection = 1,
Final = 2,
};
void CompatDB::Submit() { void CompatDB::Submit() {
QButtonGroup* compatibility = new QButtonGroup(this); QButtonGroup* compatibility = new QButtonGroup(this);

View file

@ -21,7 +21,6 @@ public:
private: private:
std::unique_ptr<Ui::CompatDB> ui; std::unique_ptr<Ui::CompatDB> ui;
private slots:
void Submit(); void Submit();
void EnableNext(); void EnableNext();
}; };

View file

@ -25,7 +25,7 @@ ConfigureWeb::ConfigureWeb(QWidget* parent)
this->setConfiguration(); this->setConfiguration();
} }
ConfigureWeb::~ConfigureWeb() {} ConfigureWeb::~ConfigureWeb() = default;
void ConfigureWeb::setConfiguration() { void ConfigureWeb::setConfiguration() {
ui->web_credentials_disclaimer->setWordWrap(true); ui->web_credentials_disclaimer->setWordWrap(true);

View file

@ -11,7 +11,7 @@ namespace DiscordRPC {
class DiscordImpl : public DiscordInterface { class DiscordImpl : public DiscordInterface {
public: public:
DiscordImpl(); DiscordImpl();
~DiscordImpl(); ~DiscordImpl() override;
void Pause() override; void Pause() override;
void Update() override; void Update() override;

View file

@ -92,7 +92,7 @@ void GMainWindow::ShowTelemetryCallout() {
} }
UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry); UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry);
static const QString telemetry_message = const QString telemetry_message =
tr("<a href='https://citra-emu.org/entry/telemetry-and-why-thats-a-good-thing/'>Anonymous " tr("<a href='https://citra-emu.org/entry/telemetry-and-why-thats-a-good-thing/'>Anonymous "
"data is collected</a> to help improve Citra. " "data is collected</a> to help improve Citra. "
"<br/><br/>Would you like to share your usage data with us?"); "<br/><br/>Would you like to share your usage data with us?");

View file

@ -82,7 +82,7 @@ u64 RegenerateTelemetryId() {
return new_telemetry_id; return new_telemetry_id;
} }
bool VerifyLogin(std::string username, std::string token) { bool VerifyLogin(const std::string& username, const std::string& token) {
#ifdef ENABLE_WEB_SERVICE #ifdef ENABLE_WEB_SERVICE
return WebService::VerifyLogin(Settings::values.web_api_url, username, token); return WebService::VerifyLogin(Settings::values.web_api_url, username, token);
#else #else

View file

@ -56,6 +56,6 @@ u64 RegenerateTelemetryId();
* @param func A function that gets exectued when the verification is finished * @param func A function that gets exectued when the verification is finished
* @returns Future with bool indicating whether the verification succeeded * @returns Future with bool indicating whether the verification succeeded
*/ */
bool VerifyLogin(std::string username, std::string token); bool VerifyLogin(const std::string& username, const std::string& token);
} // namespace Core } // namespace Core

View file

@ -10,6 +10,11 @@
namespace WebService { namespace WebService {
TelemetryJson::TelemetryJson(const std::string& host, const std::string& username,
const std::string& token)
: host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
TelemetryJson::~TelemetryJson() = default;
template <class T> template <class T>
void TelemetryJson::Serialize(Telemetry::FieldType type, const std::string& name, T value) { void TelemetryJson::Serialize(Telemetry::FieldType type, const std::string& name, T value) {
sections[static_cast<u8>(type)][name] = value; sections[static_cast<u8>(type)][name] = value;

View file

@ -18,9 +18,8 @@ namespace WebService {
*/ */
class TelemetryJson : public Telemetry::VisitorInterface { class TelemetryJson : public Telemetry::VisitorInterface {
public: public:
TelemetryJson(const std::string& host, const std::string& username, const std::string& token) TelemetryJson(const std::string& host, const std::string& username, const std::string& token);
: host(host), username(username), token(token) {} ~TelemetryJson();
~TelemetryJson() = default;
void Visit(const Telemetry::Field<bool>& field) override; void Visit(const Telemetry::Field<bool>& field) override;
void Visit(const Telemetry::Field<double>& field) override; void Visit(const Telemetry::Field<double>& field) override;

View file

@ -13,12 +13,12 @@
namespace WebService { namespace WebService {
static constexpr char API_VERSION[]{"1"}; constexpr char API_VERSION[]{"1"};
constexpr int HTTP_PORT = 80; constexpr u32 HTTP_PORT = 80;
constexpr int HTTPS_PORT = 443; constexpr u32 HTTPS_PORT = 443;
constexpr int TIMEOUT_SECONDS = 30; constexpr u32 TIMEOUT_SECONDS = 30;
Client::JWTCache Client::jwt_cache{}; Client::JWTCache Client::jwt_cache{};