From b80911162f6863335082786c46e51c39ad0ca1cc Mon Sep 17 00:00:00 2001 From: Subv Date: Fri, 10 Apr 2020 18:39:40 -0500 Subject: [PATCH] Warnings/QtMotionControls: There is no need to use std::move after std::make_unique. This fixes a Clang warning about the move preventing copy elision (-Wpessimizing-move) --- src/citra_qt/configuration/configure_motion_touch.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/citra_qt/configuration/configure_motion_touch.cpp b/src/citra_qt/configuration/configure_motion_touch.cpp index c1961d71e..a5457cdf7 100644 --- a/src/citra_qt/configuration/configure_motion_touch.cpp +++ b/src/citra_qt/configuration/configure_motion_touch.cpp @@ -30,7 +30,7 @@ CalibrationConfigurationDialog::CalibrationConfigurationDialog(QWidget* parent, setLayout(layout); using namespace InputCommon::CemuhookUDP; - job = std::move(std::make_unique( + job = std::make_unique( host, port, pad_index, client_id, [this](CalibrationConfigurationJob::Status status) { QString text; @@ -56,7 +56,7 @@ CalibrationConfigurationDialog::CalibrationConfigurationDialog(QWidget* parent, min_y = min_y_; max_x = max_x_; max_y = max_y_; - })); + }); } CalibrationConfigurationDialog::~CalibrationConfigurationDialog() = default;