N-archive/citra
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText

Browse source 
Just a trivial modernization that potentially avoids copying strings in certain scenarios.
This commit is contained in:
Lioncash 2018-12-05 15:59:48 -05:00 committed by fearlessTobi
parent d2003dae4a
commit c2790a3f86
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/citra_qt/debugger/wait_tree.cpp
View file

@ -61,7 +61,8 @@ std::vector<std::unique_ptr<WaitTreeThread>> WaitTreeItem::MakeThreadItemList()
return item_list; return item_list;
} }
WaitTreeText::WaitTreeText(const QString& t) : text(t) {} WaitTreeText::WaitTreeText(QString t) : text(std::move(t)) {}
WaitTreeText::~WaitTreeText() = default;
QString WaitTreeText::GetText() const { QString WaitTreeText::GetText() const {
return text; return text;

4
src/citra_qt/debugger/wait_tree.h
View file

@ -50,7 +50,9 @@ private:
class WaitTreeText : public WaitTreeItem { class WaitTreeText : public WaitTreeItem {
Q_OBJECT Q_OBJECT
public: public:
explicit WaitTreeText(const QString& text); explicit WaitTreeText(QString text);
~WaitTreeText() override;
QString GetText() const override; QString GetText() const override;
private: private: