fearlessTobi
cf8b1726df
Address review comments
2018-09-06 00:00:21 +02:00
fearlessTobi
cb3ef488c7
Fixup! string_util: Remove StringFromFormat() and related functions
2018-09-06 00:00:21 +02:00
Lioncash
3284bef360
string_util: Remove StringFromFormat() and related functions
...
Given we utilize fmt, we don't need to provide our own functions for formatting anymore
2018-09-06 00:00:21 +02:00
Weiyi Wang
22e172946b
Merge pull request #4132 from FearlessTobi/port-966
...
Port #966 and #414 from yuzu (Cleanups in common and file_util) & Make bitfield assignment operator public
2018-09-05 18:03:36 +03:00
fearlessTobi
c7d8ffd14f
Make bitfield assignment operator public
...
This change needs to be made to get the code compiling again. It was suggested after a conversation with Lioncash.
The conversation can be seen here: https://user-images.githubusercontent.com/20753089/45064197-b6107800-b0b2-11e8-9db8-f696299fb86a.PNG
2018-09-05 02:24:44 +02:00
fearlessTobi
f3f4871275
Fix compilation errors
2018-09-05 02:19:55 +02:00
Weiyi Wang
ae6007bf9d
Merge pull request #4069 from B3n30/wait_for_service_register
...
Service::SM: Wait till client is registered
2018-09-04 01:57:28 +03:00
Weiyi Wang
fffa55b5d8
Merge pull request #4139 from tgsm/hid-update-table
...
Service/HID: update function table
2018-09-04 01:47:26 +03:00
Weiyi Wang
2396e58ee4
Merge pull request #4170 from FearlessTobi/port-stupid-fixes
...
citra_qt: Backport some review fixes of Lioncash
2018-09-04 01:47:03 +03:00
Weiyi Wang
12bba80d48
Merge pull request #4174 from wwylele/proctex-round-fix
...
gl_rasiterzer/proctex: revert back to round() for Nearest sampling
2018-09-04 01:36:16 +03:00
B3n30
cfd81be661
fixup! fixup! Service::SM: Wait till client is registered
2018-09-02 22:50:13 +02:00
B3n30
ae37b404c6
fixup! fixup! Service::SM: Wait till client is registered
2018-09-02 16:42:41 +02:00
Merry
978611e51e
Merge pull request #4086 from MerryMage/dynarmic-update-201808
...
externals: Update dynarmic
2018-09-02 09:55:32 +01:00
Merry
f1b8d091db
Merge pull request #4157 from FearlessTobi/port-1048
...
Port #1048 from yuzu: "kernel/object: Tighten object against data races"
2018-09-02 09:54:49 +01:00
Merry
b130dd6842
Merge pull request #4161 from FearlessTobi/port-1139
...
Port #1139 from yuzu: "bit_field: Convert ToBool() into explicit operator bool"
2018-09-02 09:53:50 +01:00
Merry
85e0553a1f
Merge pull request #4165 from B3n30/log_ncch_load
...
NCCH_Container: Add file_path log to Load()
2018-09-02 09:52:30 +01:00
Merry
c99d197ff7
Merge pull request #4156 from FearlessTobi/port-1060
...
Port #1060 from yuzu: "logging/backend: Use const reference to refer to log filter"
2018-09-02 09:50:57 +01:00
Merry
f03cc09998
Merge pull request #4168 from MerryMage/cubeb-lock
...
cubeb_sink: Protect queue against multithreaded access
2018-09-02 09:49:12 +01:00
fearlessTobi
488694d01f
Replace ToBool() with static_cast()
2018-09-01 15:50:57 +02:00
Lioncash
6c3737a786
bit_field: Convert ToBool() into explicit operator bool
...
Gets rid of a TODO that is long overdue.
2018-09-01 15:44:09 +02:00
fearlessTobi
2f6f232965
Backport some review fixes of Lioncash
2018-09-01 15:41:46 +02:00
Weiyi Wang
99f4ea999c
gl_rasiterzer/proctex: revert back to round() for Nearest sampling
...
This change to floor() was made in 2927c88
, which was a result of doing some hwtest. It turned out that it was buggy edge cases in PICA, and for most cases round() still applies
2018-09-01 09:11:15 -04:00
Weiyi Wang
b4fdce0c2c
Merge pull request #4171 from zhaowenlan1779/remove-glad-hack
...
Tests: Remove glad test OS X work-around
2018-09-01 15:30:06 +03:00
Pengfei Zhu
3b3b0bbdf5
Merge pull request #4152 from citra-emu/port-1030
...
Port yuzu-emu/yuzu#1030 from yuzu: "externals: Update to SDL2-2.0.8"
2018-09-01 12:08:13 +08:00
Yuri Kunde Schlesner
23506e8eae
Tests: Remove glad test OS X work-around
2018-09-01 11:44:24 +08:00
Pengfei Zhu
987e1279a3
Merge pull request #4155 from FearlessTobi/port-1062
...
Port yuzu-emu/yuzu#1062 from yuzu: "common: Remove unused old breakpoint source files"
2018-09-01 10:27:18 +08:00
Tobias
c8bcd35b7a
Port #1030 from yuzu: "externals: Update to SDL2-2.0.8"
2018-09-01 08:12:06 +08:00
Lioncash
664e92d6ae
common: Remove unused old breakpoint source files
...
These currently aren't used and contain commented out source code that
corresponds to Dolphin's JIT. Given our CPU code is organized quite
differently, we shouldn't be keeping this around (at the moment it just
adds to compile times marginally).
2018-09-01 00:04:25 +02:00
Weiyi Wang
ffd78b635e
Merge pull request #4163 from FearlessTobi/port-1097
...
Port #1097 from yuzu: "renderer_opengl: Treat OpenGL errors as critical."
2018-08-31 21:43:52 +03:00
MerryMage
7daed185cb
cubeb_sink: Protect queue against multithreaded access
2018-08-31 18:44:19 +01:00
Pengfei Zhu
ac419c8612
Merge pull request #4159 from FearlessTobi/port-1067
...
Port yuzu-emu/yuzu#1067 from yuzu: "emu_window: Ensure WindowConfig members are always initialized"
2018-08-31 19:44:33 +08:00
Pengfei Zhu
13f2cc9964
Merge pull request #4162 from FearlessTobi/port-1126
...
Port yuzu-emu/yuzu#1126 from yuzu: "Don't allocate std::string instances for program lifetime in GetTelemetryId() and RegenerateTelemetryId()"
2018-08-31 17:39:49 +08:00
B3n30
bfbb6f13b4
NCCH_COntainer: Add file_path log to Load()
2018-08-31 11:00:34 +02:00
Pengfei Zhu
1016d288c5
Merge pull request #4160 from FearlessTobi/port-1133
...
Port #1133 from yuzu: "gl_stream_buffer: Add missing header guard"
2018-08-31 16:18:10 +08:00
Pengfei Zhu
0fe57d075a
Merge pull request #4158 from FearlessTobi/port-933
...
Port #933 from yuzu: Multiple cleanups in memory
2018-08-31 14:38:43 +08:00
Pengfei Zhu
270155066c
Merge pull request #4154 from FearlessTobi/port-1063
...
Port #1063 from yuzu: "common/xbyak_abi: Mark defined functions in header as inline "
2018-08-31 12:59:29 +08:00
Pengfei Zhu
f82517f91d
Merge pull request #4153 from FearlessTobi/port-1066
...
Port #1066 from yuzu: "CMakeLists: Add architecture detection for AArch64"
2018-08-31 12:56:58 +08:00
Weiyi Wang
a62e830ebf
Merge pull request #4151 from FearlessTobi/port-987
...
Port #987 from yuzu: "vector_math: Use variable template version of is_signed in Vec classes"
2018-08-31 07:10:43 +03:00
bunnei
ffdc27351a
renderer_opengl: Treat OpenGL errors as critical.
2018-08-31 01:56:38 +02:00
Lioncash
893f6e9766
telemetry_session: Don't allocate std::string instances for program lifetime in GetTelemetryId() and RegenerateTelemetryId()
...
Given these functions aren't intended to be used frequently, there's no
need to keep the std::string instances allocated for the whole lifetime
of the program. It's just a waste of memory.
2018-08-31 01:51:32 +02:00
Lioncash
6d280cb49a
gl_stream_buffer: Add missing header guard
...
Prevents potential compilation errors from occuring due to multiple
inclusions
2018-08-31 01:45:44 +02:00
Lioncash
d82ecb67f7
emu_window: Ensure WindowConfig members are always initialized
...
Previously we weren't always initializing all members of the struct.
Prevents potentially wonky behavior from occurring.
2018-08-31 00:55:04 +02:00
Lioncash
8fa861c2c6
memory: Make prototype parameter names match their definitions
...
Keeps the code consistent.
2018-08-31 00:33:20 +02:00
Lioncash
379b8c65b9
memory: Remove unnecessary const qualifiers in prototypes
...
These aren't necessary, as value-wise const only matters in the
definition.
2018-08-31 00:22:55 +02:00
Lioncash
c47e1db46d
kernel/object: Tighten object against data races
...
Despite being covered by a global mutex, we should still ensure that the
class handles its reference counts properly. This avoids potential
shenanigans when it comes to data races.
Given this is the root object that drives quite a bit of the kernel
object hierarchy, ensuring we always have the correct behavior (and no
races) is a good thing.
2018-08-31 00:14:48 +02:00
Lioncash
8fbfd0f7fa
logging/backend: Use const reference to refer to log filter
...
The filter is returned via const reference, so this was making a
pointless copy of the entire filter every time a message was being
pushed into the logger instance.
2018-08-31 00:13:15 +02:00
Lioncash
0fbae792cf
common/xbyak_abi: Mark defined functions in header as inline
...
Avoids potential One Definition Rule violations when these are used in
the future.
2018-08-31 00:08:42 +02:00
Lioncash
d6bf1b31c8
common/xbyak: Use nested namespace specifiers where applicable
2018-08-31 00:08:34 +02:00
Lioncash
ce472144ff
CMakeLists: Add architecture detection for AArch64
...
We already have an equivalent in place for the 32-bit ARM architecture, so we
should also have one for the newer 64-bit ARM architecture as well.
2018-08-31 00:07:01 +02:00
Lioncash
ff1f7555de
vector_math: Use variable template version of is_signed in Vec classes
...
Same behavior, less code
2018-08-30 23:38:32 +02:00