N-archive/hacks-guide-minimal-mistakes-theme
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use css padding for author urls to fix underline hover state (#2472)

Browse source 
* Use scss padding for sidebar author urls

* rename .text to .label
This commit is contained in:
Ali Farooq 2020-03-30 16:26:24 -04:00 committed by GitHub
parent b4ccaa6ae2
commit 7790757722
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
_includes/author-profile.html
View file

@ -40,7 +40,7 @@
{% if author.links %} {% if author.links %}
{% for link in author.links %} {% for link in author.links %}
{% if link.label and link.url %} {% if link.label and link.url %}
<li><a href="{{ link.url }}" rel="nofollow noopener noreferrer"><i class="{{ link.icon | default: 'fas fa-link' }}" aria-hidden="true"></i> {{ link.label }}</a></li> <li><a href="{{ link.url }}" rel="nofollow noopener noreferrer"><i class="{{ link.icon | default: 'fas fa-link' }}" aria-hidden="true"></i><span class="label">{{ link.label }}</span></a></li>
{% endif %} {% endif %}
{% endfor %} {% endfor %}
{% endif %} {% endif %}
@ -48,7 +48,7 @@
{% if author.uri %} {% if author.uri %}
<li> <li>
<a href="{{ author.uri }}" itemprop="url"> <a href="{{ author.uri }}" itemprop="url">
<i class="fas fa-fw fa-link" aria-hidden="true"></i> {{ site.data.ui-text[site.locale].website_label | default: "Website" }} <i class="fas fa-fw fa-link" aria-hidden="true"></i><span class="label">{{ site.data.ui-text[site.locale].website_label | default: "Website" }}</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -57,7 +57,7 @@
<li> <li>
<a href="mailto:{{ author.email }}"> <a href="mailto:{{ author.email }}">
<meta itemprop="email" content="{{ author.email }}" /> <meta itemprop="email" content="{{ author.email }}" />
<i class="fas fa-fw fa-envelope-square" aria-hidden="true"></i> {{ site.data.ui-text[site.locale].email_label | default: "Email" }} <i class="fas fa-fw fa-envelope-square" aria-hidden="true"></i><span class="label">{{ site.data.ui-text[site.locale].email_label | default: "Email" }}</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -65,7 +65,7 @@
{% if author.keybase %} {% if author.keybase %}
<li> <li>
<a href="https://keybase.io/{{ author.keybase }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://keybase.io/{{ author.keybase }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fas fa-fw fa-key" aria-hidden="true"></i> Keybase <i class="fas fa-fw fa-key" aria-hidden="true"></i><span class="label">Keybase</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -73,7 +73,7 @@
{% if author.twitter %} {% if author.twitter %}
<li> <li>
<a href="https://twitter.com/{{ author.twitter }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://twitter.com/{{ author.twitter }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-twitter-square" aria-hidden="true"></i> Twitter <i class="fab fa-fw fa-twitter-square" aria-hidden="true"></i><span class="label">Twitter</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -81,7 +81,7 @@
{% if author.facebook %} {% if author.facebook %}
<li> <li>
<a href="https://www.facebook.com/{{ author.facebook }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.facebook.com/{{ author.facebook }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-facebook-square" aria-hidden="true"></i> Facebook <i class="fab fa-fw fa-facebook-square" aria-hidden="true"></i><span class="label">Facebook</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -89,7 +89,7 @@
{% if author.linkedin %} {% if author.linkedin %}
<li> <li>
<a href="https://www.linkedin.com/in/{{ author.linkedin }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.linkedin.com/in/{{ author.linkedin }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-linkedin" aria-hidden="true"></i> LinkedIn <i class="fab fa-fw fa-linkedin" aria-hidden="true"></i><span class="label">LinkedIn</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -97,7 +97,7 @@
{% if author.xing %} {% if author.xing %}
<li> <li>
<a href="https://www.xing.com/profile/{{ author.xing }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.xing.com/profile/{{ author.xing }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-xing-square" aria-hidden="true"></i> XING <i class="fab fa-fw fa-xing-square" aria-hidden="true"></i><span class="label">XING</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -105,7 +105,7 @@
{% if author.instagram %} {% if author.instagram %}
<li> <li>
<a href="https://instagram.com/{{ author.instagram }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://instagram.com/{{ author.instagram }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-instagram" aria-hidden="true"></i> Instagram <i class="fab fa-fw fa-instagram" aria-hidden="true"></i><span class="label">Instagram</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -113,7 +113,7 @@
{% if author.tumblr %} {% if author.tumblr %}
<li> <li>
<a href="https://{{ author.tumblr }}.tumblr.com" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://{{ author.tumblr }}.tumblr.com" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-tumblr-square" aria-hidden="true"></i> Tumblr <i class="fab fa-fw fa-tumblr-square" aria-hidden="true"></i><span class="label">Tumblr</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -121,7 +121,7 @@
{% if author.bitbucket %} {% if author.bitbucket %}
<li> <li>
<a href="https://bitbucket.org/{{ author.bitbucket }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://bitbucket.org/{{ author.bitbucket }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-bitbucket" aria-hidden="true"></i> Bitbucket <i class="fab fa-fw fa-bitbucket" aria-hidden="true"></i><span class="label">Bitbucket</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -129,7 +129,7 @@
{% if author.github %} {% if author.github %}
<li> <li>
<a href="https://github.com/{{ author.github }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://github.com/{{ author.github }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-github" aria-hidden="true"></i> GitHub <i class="fab fa-fw fa-github" aria-hidden="true"></i><span class="label">GitHub</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -137,7 +137,7 @@
{% if author.gitlab %} {% if author.gitlab %}
<li> <li>
<a href="https://gitlab.com/{{ author.gitlab }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://gitlab.com/{{ author.gitlab }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-gitlab" aria-hidden="true"></i> GitLab <i class="fab fa-fw fa-gitlab" aria-hidden="true"></i><span class="label">GitLab</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -145,7 +145,7 @@
{% if author.stackoverflow %} {% if author.stackoverflow %}
<li> <li>
<a href="https://stackoverflow.com/users/{{ author.stackoverflow }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://stackoverflow.com/users/{{ author.stackoverflow }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-stack-overflow" aria-hidden="true"></i> Stack Overflow <i class="fab fa-fw fa-stack-overflow" aria-hidden="true"></i><span class="label">Stack Overflow</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -153,7 +153,7 @@
{% if author.lastfm %} {% if author.lastfm %}
<li> <li>
<a href="https://last.fm/user/{{ author.lastfm }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://last.fm/user/{{ author.lastfm }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-lastfm-square" aria-hidden="true"></i> Last.fm <i class="fab fa-fw fa-lastfm-square" aria-hidden="true"></i><span class="label">Last.fm</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -161,7 +161,7 @@
{% if author.dribbble %} {% if author.dribbble %}
<li> <li>
<a href="https://dribbble.com/{{ author.dribbble }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://dribbble.com/{{ author.dribbble }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-dribbble" aria-hidden="true"></i> Dribbble <i class="fab fa-fw fa-dribbble" aria-hidden="true"></i><span class="label">Dribbble</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -169,7 +169,7 @@
{% if author.pinterest %} {% if author.pinterest %}
<li> <li>
<a href="https://www.pinterest.com/{{ author.pinterest }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.pinterest.com/{{ author.pinterest }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-pinterest" aria-hidden="true"></i> Pinterest <i class="fab fa-fw fa-pinterest" aria-hidden="true"></i><span class="label">Pinterest</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -177,7 +177,7 @@
{% if author.foursquare %} {% if author.foursquare %}
<li> <li>
<a href="https://foursquare.com/{{ author.foursquare }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://foursquare.com/{{ author.foursquare }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-foursquare" aria-hidden="true"></i> Foursquare <i class="fab fa-fw fa-foursquare" aria-hidden="true"></i><span class="label">Foursquare</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -185,7 +185,7 @@
{% if author.steam %} {% if author.steam %}
<li> <li>
<a href="https://steamcommunity.com/id/{{ author.steam }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://steamcommunity.com/id/{{ author.steam }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-steam" aria-hidden="true"></i> Steam <i class="fab fa-fw fa-steam" aria-hidden="true"></i><span class="label">Steam</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -194,13 +194,13 @@
{% if author.youtube contains "://" %} {% if author.youtube contains "://" %}
<li> <li>
<a href="{{ author.youtube }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="{{ author.youtube }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-youtube" aria-hidden="true"></i> YouTube <i class="fab fa-fw fa-youtube" aria-hidden="true"></i><span class="label">YouTube</span>
</a> </a>
</li> </li>
{% elsif author.youtube %} {% elsif author.youtube %}
<li> <li>
<a href="https://www.youtube.com/user/{{ author.youtube }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.youtube.com/user/{{ author.youtube }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-youtube" aria-hidden="true"></i> YouTube <i class="fab fa-fw fa-youtube" aria-hidden="true"></i><span class="label">YouTube</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -209,7 +209,7 @@
{% if author.soundcloud %} {% if author.soundcloud %}
<li> <li>
<a href="https://soundcloud.com/{{ author.soundcloud }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://soundcloud.com/{{ author.soundcloud }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-soundcloud" aria-hidden="true"></i> SoundCloud <i class="fab fa-fw fa-soundcloud" aria-hidden="true"></i><span class="label">SoundCloud</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -217,7 +217,7 @@
{% if author.weibo %} {% if author.weibo %}
<li> <li>
<a href="https://www.weibo.com/{{ author.weibo }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.weibo.com/{{ author.weibo }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-weibo" aria-hidden="true"></i> Weibo <i class="fab fa-fw fa-weibo" aria-hidden="true"></i><span class="label">Weibo</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -225,7 +225,7 @@
{% if author.flickr %} {% if author.flickr %}
<li> <li>
<a href="https://www.flickr.com/{{ author.flickr }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://www.flickr.com/{{ author.flickr }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-flickr" aria-hidden="true"></i> Flickr <i class="fab fa-fw fa-flickr" aria-hidden="true"></i><span class="label">Flickr</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -233,7 +233,7 @@
{% if author.codepen %} {% if author.codepen %}
<li> <li>
<a href="https://codepen.io/{{ author.codepen }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://codepen.io/{{ author.codepen }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-codepen" aria-hidden="true"></i> CodePen <i class="fab fa-fw fa-codepen" aria-hidden="true"></i><span class="label">CodePen</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}
@ -241,7 +241,7 @@
{% if author.vine %} {% if author.vine %}
<li> <li>
<a href="https://vine.co/u/{{ author.vine }}" itemprop="sameAs" rel="nofollow noopener noreferrer"> <a href="https://vine.co/u/{{ author.vine }}" itemprop="sameAs" rel="nofollow noopener noreferrer">
<i class="fab fa-fw fa-vine" aria-hidden="true"></i> Vine <i class="fab fa-fw fa-vine" aria-hidden="true"></i><span class="label">{{ site.data.ui-text[site.locale].email_label | default: "Email" }}</span>
</a> </a>
</li> </li>
{% endif %} {% endif %}

6
_sass/minimal-mistakes/_sidebar.scss
View file

@ -194,6 +194,12 @@
} }
} }
.author__urls {
span.label {
padding-left: 5px;
}
}
@include breakpoint($large) { @include breakpoint($large) {
display: block; display: block;
} }