N-archive/hacks-guide-minimal-mistakes-theme
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove buggy conditional around related posts header (#901)

Browse source 
This removes a buggy conditional that checks if `related_label` is
available in translations before displaying the header for related
posts but this header already handle missing translation by using a
default string.

With this fix the header is displayed even if the translation for this
label isn't available.

Fix #900
This commit is contained in:
Nicolas Cavigneaux 2017-03-16 15:21:13 +01:00 committed by Michael Rose
parent 7719679fea
commit 958b399741
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
_layouts/single.html
View file

@ -63,9 +63,7 @@ layout: default
{% comment %}<!-- only show related on a post page when not disabled -->{% endcomment %} {% comment %}<!-- only show related on a post page when not disabled -->{% endcomment %}
{% if page.id and page.related and site.related_posts.size > 0 %} {% if page.id and page.related and site.related_posts.size > 0 %}
<div class="page__related"> <div class="page__related">
{% if site.data.ui-text[site.locale].related_label %} <h4 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h4>
<h4 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h4>
{% endif %}
<div class="grid__wrapper"> <div class="grid__wrapper">
{% for post in site.related_posts limit:4 %} {% for post in site.related_posts limit:4 %}
{% include archive-single.html type="grid" %} {% include archive-single.html type="grid" %}

4
docs/_layouts/single.html
View file

@ -63,9 +63,7 @@ layout: default
{% comment %}<!-- only show related on a post page when not disabled -->{% endcomment %} {% comment %}<!-- only show related on a post page when not disabled -->{% endcomment %}
{% if page.id and page.related and site.related_posts.size > 0 %} {% if page.id and page.related and site.related_posts.size > 0 %}
<div class="page__related"> <div class="page__related">
{% if site.data.ui-text[site.locale].related_label %} <h4 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h4>
<h4 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h4>
{% endif %}
<div class="grid__wrapper"> <div class="grid__wrapper">
{% for post in site.related_posts limit:4 %} {% for post in site.related_posts limit:4 %}
{% include archive-single.html type="grid" %} {% include archive-single.html type="grid" %}