N-archive/hacks-guide-minimal-mistakes-theme
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix empty <img> when site_logo is not assigned

Browse source 
Ref: https://github.com/mmistakes/minimal-mistakes/pull/2026#issuecomment-454809876
This commit is contained in:
Michael Rose 2019-01-16 11:06:54 -05:00
parent c44e65cdec
commit afd8cfd99e
13 changed files with 26 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
CHANGELOG.md
View file

@ -1,3 +1,9 @@
## [4.15.1](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1)
### Bug Fixes
- Fix empty `<img>` when `site_logo` is not assigned. [#2026](https://github.com/mmistakes/minimal-mistakes/pull/2026#issuecomment-454809876)
## [4.15.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.0) ## [4.15.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.0)
### Enhancements ### Enhancements

2
README.md
View file

@ -126,7 +126,7 @@ To install:
bundle bundle
``` ```
4. Add `remote_theme: "mmistakes/minimal-mistakes@4.15.0"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry. 4. Add `remote_theme: "mmistakes/minimal-mistakes@4.15.1"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry.
## Usage ## Usage

2
_includes/masthead.html
View file

@ -8,7 +8,7 @@
<div class="masthead__inner-wrap"> <div class="masthead__inner-wrap">
<div class="masthead__menu"> <div class="masthead__menu">
<nav id="site-nav" class="greedy-nav"> <nav id="site-nav" class="greedy-nav">
{% if logo_path %}<a class="site-logo" href="{{ '/' | relative_url }}"><img src="{{ logo_path }}"></a>{% endif %} {% if site.logo %}<a class="site-logo" href="{{ '/' | relative_url }}"><img src="{{ logo_path }}"></a>{% endif %}
<a class="site-title" href="{{ '/' | relative_url }}">{{ site.masthead_title | default: site.title }}</a> <a class="site-title" href="{{ '/' | relative_url }}">{{ site.masthead_title | default: site.title }}</a>
<ul class="visible-links"> <ul class="visible-links">
{%- for link in site.data.navigation.main -%} {%- for link in site.data.navigation.main -%}

2
_layouts/default.html
View file

@ -3,7 +3,7 @@
<!doctype html> <!doctype html>
<!-- <!--
Minimal Mistakes Jekyll Theme 4.15.0 by Michael Rose Minimal Mistakes Jekyll Theme 4.15.1 by Michael Rose
Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes
Free for personal and commercial use under the MIT license Free for personal and commercial use under the MIT license
https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE

2
_sass/minimal-mistakes.scss
View file

@ -1,5 +1,5 @@
/*! /*!
* Minimal Mistakes Jekyll Theme 4.15.0 by Michael Rose * Minimal Mistakes Jekyll Theme 4.15.1 by Michael Rose
* Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes * Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes
* Licensed under MIT (https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE) * Licensed under MIT (https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE)
*/ */

2
assets/js/main.min.js vendored
View file

@ -1,5 +1,5 @@
/*! /*!
* Minimal Mistakes Jekyll Theme 4.15.0 by Michael Rose * Minimal Mistakes Jekyll Theme 4.15.1 by Michael Rose
* Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes * Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes
* Licensed under MIT * Licensed under MIT
*/ */

2
docs/_docs/01-quick-start-guide.md
View file

@ -74,7 +74,7 @@ To install as a remote theme:
bundle bundle
``` ```
4. Add `remote_theme: "mmistakes/minimal-mistakes@4.15.0"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry. 4. Add `remote_theme: "mmistakes/minimal-mistakes@4.15.1"` to your `_config.yml` file. Remove any other `theme:` or `remote_theme:` entry.
You may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref (e.g., `mmistakes/minimal-mistakes@4.9.0` or `mmistakes/minimal-mistakes@bbf3cbc5fd64a3e1885f3f99eb90ba92af84063d`). This is useful when rolling back to older versions of the theme. If you don't specify a Git ref, the latest on `master` will be used. You may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref (e.g., `mmistakes/minimal-mistakes@4.9.0` or `mmistakes/minimal-mistakes@bbf3cbc5fd64a3e1885f3f99eb90ba92af84063d`). This is useful when rolling back to older versions of the theme. If you don't specify a Git ref, the latest on `master` will be used.

6
docs/_docs/04-upgrading.md
View file

@ -12,7 +12,7 @@ To check which version you are currently using, view the source of your built si
``` ```
<!-- <!--
Minimal Mistakes Jekyll Theme 4.15.0 by Michael Rose Minimal Mistakes Jekyll Theme 4.15.1 by Michael Rose
Copyright 2013-2018 Michael Rose - mademistakes.com | @mmistakes Copyright 2013-2018 Michael Rose - mademistakes.com | @mmistakes
Free for personal and commercial use under the MIT license Free for personal and commercial use under the MIT license
https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE
@ -28,14 +28,14 @@ Simply run `bundle update` if you're using Bundler (have a `Gemfile`) or `gem up
When using Bundler you can downgrade or lock the theme to a specific release ([tag](https://github.com/mmistakes/minimal-mistakes/tags)), branch, or commit. Instead of `gem "minimal-mistakes-jekyll"` you'd add the following to your `Gemfile`: When using Bundler you can downgrade or lock the theme to a specific release ([tag](https://github.com/mmistakes/minimal-mistakes/tags)), branch, or commit. Instead of `gem "minimal-mistakes-jekyll"` you'd add the following to your `Gemfile`:
```ruby ```ruby
gem "minimal-mistakes-jekyll", :git => "https://github.com/mmistakes/minimal-mistakes.git", :tag => "4.15.0" gem "minimal-mistakes-jekyll", :git => "https://github.com/mmistakes/minimal-mistakes.git", :tag => "4.15.1"
``` ```
For more information on [installing gems from git repositories](http://bundler.io/v1.16/guides/git.html) consult Bundler's documentation. For more information on [installing gems from git repositories](http://bundler.io/v1.16/guides/git.html) consult Bundler's documentation.
## Remote theme ## Remote theme
When setting `remote_theme: "mmistakes/minimal-mistakes@4.15.0"` in your `_config.yml` you may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref. When setting `remote_theme: "mmistakes/minimal-mistakes@4.15.1"` in your `_config.yml` you may also optionally specify a branch, [tag](https://github.com/mmistakes/minimal-mistakes/tags), or commit to use by appending an @ and the Git ref.
For example you can roll back to release 4.8.1 with `mmistakes/minimal-mistakes@4.8.1` or a specific commit with `mmistakes/minimal-mistakes@bbf3cbc5fd64a3e1885f3f99eb90ba92af84063d`). For a complete list of theme versions consult the [releases page](https://github.com/mmistakes/minimal-mistakes/releases). For example you can roll back to release 4.8.1 with `mmistakes/minimal-mistakes@4.8.1` or a specific commit with `mmistakes/minimal-mistakes@bbf3cbc5fd64a3e1885f3f99eb90ba92af84063d`). For a complete list of theme versions consult the [releases page](https://github.com/mmistakes/minimal-mistakes/releases).

8
docs/_docs/18-history.md
View file

@ -4,10 +4,16 @@ permalink: /docs/history/
excerpt: "Change log of enhancements and bug fixes made to the theme." excerpt: "Change log of enhancements and bug fixes made to the theme."
sidebar: sidebar:
nav: docs nav: docs
last_modified_at: 2019-01-16T08:24:36-05:00 last_modified_at: 2019-01-16T11:06:09-05:00
toc: true toc: true
--- ---
## [4.15.1](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1)
### Bug Fixes
- Fix empty `<img>` when `site_logo` is not assigned. [#2026](https://github.com/mmistakes/minimal-mistakes/pull/2026#issuecomment-454809876)
## [4.15.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.0) ## [4.15.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.0)
### Enhancements ### Enhancements

2
docs/_layouts/default.html
View file

@ -3,7 +3,7 @@
<!doctype html> <!doctype html>
<!-- <!--
Minimal Mistakes Jekyll Theme 4.15.0 by Michael Rose Minimal Mistakes Jekyll Theme 4.15.1 by Michael Rose
Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes Copyright 2013-2019 Michael Rose - mademistakes.com | @mmistakes
Free for personal and commercial use under the MIT license Free for personal and commercial use under the MIT license
https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE

2
docs/_pages/home.md
View file

@ -9,7 +9,7 @@ header:
url: "/docs/quick-start-guide/" url: "/docs/quick-start-guide/"
excerpt: > excerpt: >
A flexible two-column Jekyll theme. Perfect for building personal sites, blogs, and portfolios.<br /> A flexible two-column Jekyll theme. Perfect for building personal sites, blogs, and portfolios.<br />
<small><a href="https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.0">Latest release v4.15.0</a></small> <small><a href="https://github.com/mmistakes/minimal-mistakes/releases/tag/4.15.1">Latest release v4.15.1</a></small>
feature_row: feature_row:
- image_path: /assets/images/mm-customizable-feature.png - image_path: /assets/images/mm-customizable-feature.png
alt: "customizable" alt: "customizable"

2
minimal-mistakes-jekyll.gemspec
View file

@ -2,7 +2,7 @@
Gem::Specification.new do |spec| Gem::Specification.new do |spec|
spec.name = "minimal-mistakes-jekyll" spec.name = "minimal-mistakes-jekyll"
spec.version = "4.15.0" spec.version = "4.15.1"
spec.authors = ["Michael Rose"] spec.authors = ["Michael Rose"]
spec.summary = %q{A flexible two-column Jekyll theme.} spec.summary = %q{A flexible two-column Jekyll theme.}

2
package.json
View file

@ -1,6 +1,6 @@
{ {
"name": "minimal-mistakes", "name": "minimal-mistakes",
"version": "4.15.0", "version": "4.15.1",
"description": "Minimal Mistakes 2 column Jekyll theme.", "description": "Minimal Mistakes 2 column Jekyll theme.",
"repository": { "repository": {
"type": "git", "type": "git",