From d1dd94246cc0be4894c22d15edf13b793bd307b3 Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Mon, 2 Nov 2020 11:54:08 -0500 Subject: [PATCH] Fix Font Awesome icon color in various skins Close #2724 --- CHANGELOG.md | 6 ++++++ _sass/minimal-mistakes/skins/_contrast.scss | 3 ++- _sass/minimal-mistakes/skins/_dark.scss | 4 +++- _sass/minimal-mistakes/skins/_mint.scss | 1 + _sass/minimal-mistakes/skins/_neon.scss | 4 +++- _sass/minimal-mistakes/skins/_plum.scss | 4 +++- _sass/minimal-mistakes/skins/_sunrise.scss | 6 ++++-- docs/_docs/18-history.md | 8 +++++++- 8 files changed, 29 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9560623c..da37d4a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## Unreleased + +### Bug Fixes + +- Fix Font Awesome icon color in `contrast`, `dark`, `mint`, `neon`, `plum`, and `sunrise` skins. [#2724](https://github.com/mmistakes/minimal-mistakes/issues/2724) + ## [4.21.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.21.0) ### Bug Fixes diff --git a/_sass/minimal-mistakes/skins/_contrast.scss b/_sass/minimal-mistakes/skins/_contrast.scss index 4635e533..38283b8f 100644 --- a/_sass/minimal-mistakes/skins/_contrast.scss +++ b/_sass/minimal-mistakes/skins/_contrast.scss @@ -46,6 +46,7 @@ $base0f: #b18a3d !default; color: #fff !important; // override } -.page__footer-follow .social-icons .svg-inline--fa { +.page__footer-follow .social-icons i, +.page__footer-follow .social-icons .svg-inline--fa { color: inherit; } diff --git a/_sass/minimal-mistakes/skins/_dark.scss b/_sass/minimal-mistakes/skins/_dark.scss index 44f1bda0..d3d24ef7 100644 --- a/_sass/minimal-mistakes/skins/_dark.scss +++ b/_sass/minimal-mistakes/skins/_dark.scss @@ -18,8 +18,10 @@ $masthead-link-color: $text-color !default; $masthead-link-color-hover: mix(#000, $text-color, 20%) !default; $navicon-link-color-hover: mix(#000, $background-color, 30%) !default; +.author__urls.social-icons i, .author__urls.social-icons .svg-inline--fa, -.page__footer-follow .social-icons .svg-inline--fa { +.page__footer-follow .social-icons i, +.page__footer-follow .social-icons .svg-inline--fa { color: inherit; } diff --git a/_sass/minimal-mistakes/skins/_mint.scss b/_sass/minimal-mistakes/skins/_mint.scss index 575e977d..28557a3a 100644 --- a/_sass/minimal-mistakes/skins/_mint.scss +++ b/_sass/minimal-mistakes/skins/_mint.scss @@ -18,6 +18,7 @@ $navicon-link-color-hover: mix(#fff, $text-color, 80%) !default; color: #fff !important; // override } +.page__footer-follow .social-icons i, .page__footer-follow .social-icons .svg-inline--fa { color: inherit; } diff --git a/_sass/minimal-mistakes/skins/_neon.scss b/_sass/minimal-mistakes/skins/_neon.scss index 649cbff2..737e6b40 100644 --- a/_sass/minimal-mistakes/skins/_neon.scss +++ b/_sass/minimal-mistakes/skins/_neon.scss @@ -36,8 +36,10 @@ $base0d: #3777e6 !default; $base0e: #ad00a1 !default; $base0f: #cc6633 !default; +.author__urls.social-icons i, .author__urls.social-icons .svg-inline--fa, -.page__footer-follow .social-icons .svg-inline--fa { +.page__footer-follow .social-icons i, +.page__footer-follow .social-icons .svg-inline--fa { color: inherit; } diff --git a/_sass/minimal-mistakes/skins/_plum.scss b/_sass/minimal-mistakes/skins/_plum.scss index 67975d50..135db900 100644 --- a/_sass/minimal-mistakes/skins/_plum.scss +++ b/_sass/minimal-mistakes/skins/_plum.scss @@ -36,8 +36,10 @@ $base0d: #3777e6 !default; $base0e: #ad00a1 !default; $base0f: #cc6633 !default; +.author__urls.social-icons i, .author__urls.social-icons .svg-inline--fa, -.page__footer-follow .social-icons .svg-inline--fa { +.page__footer-follow .social-icons i, +.page__footer-follow .social-icons .svg-inline--fa { color: inherit; } diff --git a/_sass/minimal-mistakes/skins/_sunrise.scss b/_sass/minimal-mistakes/skins/_sunrise.scss index 1f0dca39..f23d4f96 100644 --- a/_sass/minimal-mistakes/skins/_sunrise.scss +++ b/_sass/minimal-mistakes/skins/_sunrise.scss @@ -38,7 +38,9 @@ $base0d: #81a2be !default; $base0e: #b294bb !default; $base0f: #a3685a !default; -.author__urls.social-icons .fa, -.page__footer-follow .social-icons .svg-inline--fa { +.author__urls.social-icons i, +.author__urls.social-icons .svg-inline--fa, +.page__footer-follow .social-icons i, +.page__footer-follow .social-icons .svg-inline--fa { color: inherit; } diff --git a/docs/_docs/18-history.md b/docs/_docs/18-history.md index d5229f28..ca986972 100644 --- a/docs/_docs/18-history.md +++ b/docs/_docs/18-history.md @@ -5,10 +5,16 @@ permalink: /docs/history/ excerpt: "Change log of enhancements and bug fixes made to the theme." sidebar: nav: docs -last_modified_at: 2020-11-02T11:34:40-05:00 +last_modified_at:2020-11-02T11:53:43-05:00 toc: false --- +## Unreleased + +### Bug Fixes + +- Fix Font Awesome icon color in `contrast`, `dark`, `mint`, `neon`, `plum`, and `sunrise` skins. [#2724](https://github.com/mmistakes/minimal-mistakes/issues/2724) + ## [4.21.0](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.21.0) ### Bug Fixes