Commit graph

5 commits

Author SHA1 Message Date
Leo
c2c05b9b67
Fix closing tag of figures without captions in lists (#2697)
When the figure helper is used in a list, which can be either ordered or
unordered, and no caption is specified, a line with text "</figure>"
will be shown below the figure on the rendered page.

This is because, if the '{% if include.caption %}' evaluates to false,
the lines between that 'if' statement and '{% endif %}' will be emptied,
not removed, so the block will be filled by empty lines.

HTML ignores redundant empty lines, but Markdown takes them seriously.
In addition, Markdown expects proper indentation of lines inside lists,
and the closing '</figure>' tag is not indented.  When combined, the
empty space and absence of indentation cause Markdown to process the
'</figure>' tag as a separate paragraph instead of an HTML tag, thus the
text for the tag is directly rendered on the page.

The fix for this issue is very simple: remove the empty space when
'include.caption' is false.  As described in
<https://shopify.github.io/liquid/basics/whitespace/>, this can be done
by adding hyphens to the 'if' and 'endif' tags.
2020-10-28 14:43:09 -04:00
iBug ♦
bcd6126612
Use relative_url and absolute_url where possible (#2387)
* Use relative_url and absolute_url where possible

Drops the `contains "://"` check, adopt Jekyll 3.7
Ref: https://github.com/mmistakes/minimal-mistakes/pull/2385#issuecomment-579882236

* One more unneeded {% assign %}

* Remove one more assign as noted by mmistakes

* Consolidate 4 more captures

* Consolidate an extra assign on "active" class
2020-03-06 15:37:07 -05:00
Luis Puerto
a1ff46cc59 Fix figures when they are inside of a list (#2094) 2019-03-22 16:05:48 -04:00
Michael Rose
c8226a32a6 Replace absolute_url with relative_url
Where it makes sense replace asset paths and navigation related paths with `relative_url` filter.

Leave SEO related `<head>` elements and social sharing links as `absolute_url`.

Fixes #1588
2018-03-20 11:35:36 -04:00
Michael Rose
749c780736 Rename image helper to figure 2016-11-15 12:12:14 -05:00
Renamed from _includes/image (Browse further)