From fe90c4fd7bfbe783e9fc7291026ef9a92423c1b1 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 28 Aug 2020 19:09:43 -0300 Subject: [PATCH] vk_device: Blacklist AMD proprietary from VK_EXT_extended_dynamic_state Vertex binding's is bugged on AMD's proprietary drivers when using VK_EXT_extended_dynamic_state. Blacklist it for now while we investigate how to report this issue to AMD. --- src/video_core/renderer_vulkan/vk_device.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/video_core/renderer_vulkan/vk_device.cpp b/src/video_core/renderer_vulkan/vk_device.cpp index ebcfaa0e3e..030b4dbd36 100644 --- a/src/video_core/renderer_vulkan/vk_device.cpp +++ b/src/video_core/renderer_vulkan/vk_device.cpp @@ -691,7 +691,12 @@ std::vector VKDevice::LoadExtensions() { } } - if (has_ext_extended_dynamic_state) { + if (has_ext_extended_dynamic_state && driver_id == VK_DRIVER_ID_AMD_PROPRIETARY) { + // AMD's proprietary driver supports VK_EXT_extended_dynamic_state but the field + // seems to be bugged. Blacklisting it for now. + LOG_WARNING(Render_Vulkan, + "Blacklisting AMD proprietary from VK_EXT_extended_dynamic_state"); + } else if (has_ext_extended_dynamic_state) { VkPhysicalDeviceExtendedDynamicStateFeaturesEXT dynamic_state; dynamic_state.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_EXTENDED_DYNAMIC_STATE_FEATURES_EXT; dynamic_state.pNext = nullptr;