N-archive/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu.git synced 2024-12-24 17:30:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Common: Fix a potential infinite loop in StringUtil's ReplaceAll

Browse source
This commit is contained in:
Lioncash 2014-09-08 14:48:59 -04:00
parent 335082e74e
commit 2f6ef914db
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/common/string_util.cpp
View file

@ -283,12 +283,17 @@ std::string TabsToSpaces(int tab_size, const std::string &in)
std::string ReplaceAll(std::string result, const std::string& src, const std::string& dest) std::string ReplaceAll(std::string result, const std::string& src, const std::string& dest)
{ {
while(1) size_t pos = 0;
if (src == dest)
return result;
while ((pos = result.find(src, pos)) != std::string::npos)
{ {
size_t pos = result.find(src);
if (pos == std::string::npos) break;
result.replace(pos, src.size(), dest); result.replace(pos, src.size(), dest);
pos += dest.length();
} }
return result; return result;
} }