memory_hook: Default virtual destructor in the cpp file

Prevents creating multiple copies of the vtable in every translation unit that uses the class.
Also silences a -Wweak-vtables warning
This commit is contained in:
Lioncash 2018-05-03 08:06:44 -04:00
parent 1147db9dd1
commit 732a77d0e8
No known key found for this signature in database
GPG key ID: 4E3C3CC1031BA9C7
3 changed files with 13 additions and 1 deletions

View file

@ -253,6 +253,7 @@ add_library(core STATIC
loader/nso.h loader/nso.h
memory.cpp memory.cpp
memory.h memory.h
memory_hook.cpp
memory_hook.h memory_hook.h
memory_setup.h memory_setup.h
perf_stats.cpp perf_stats.cpp

11
src/core/memory_hook.cpp Normal file
View file

@ -0,0 +1,11 @@
// Copyright 2018 Citra Emulator Project
// Licensed under GPLv2 or any later version
// Refer to the license.txt file included.
#include "core/memory_hook.h"
namespace Memory {
MemoryHook::~MemoryHook() = default;
} // namespace Memory

View file

@ -23,7 +23,7 @@ namespace Memory {
*/ */
class MemoryHook { class MemoryHook {
public: public:
virtual ~MemoryHook() = default; virtual ~MemoryHook();
virtual boost::optional<bool> IsValidAddress(VAddr addr) = 0; virtual boost::optional<bool> IsValidAddress(VAddr addr) = 0;