N-archive/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu.git synced 2024-11-22 23:02:47 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

common: fs: file: Remove redundant call to WriteStringToFile

Browse source 
The Append open mode will create a new file if said file does not exist at a given path, making this call redundant.
This commit is contained in:
Morph 2021-06-13 10:55:59 -04:00
parent 0f48292de1
commit 74790e4f33
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/common/fs/file.cpp
View file

@ -183,10 +183,6 @@ size_t WriteStringToFile(const std::filesystem::path& path, FileType type,
size_t AppendStringToFile(const std::filesystem::path& path, FileType type, size_t AppendStringToFile(const std::filesystem::path& path, FileType type,
std::string_view string) { std::string_view string) {
if (!Exists(path)) {
return WriteStringToFile(path, type, string);
}
if (!IsFile(path)) { if (!IsFile(path)) {
return 0; return 0;
} }

3
src/common/fs/file.h
View file

@ -71,7 +71,7 @@ template <typename Path>
/** /**
* Writes a string to a file at path and returns the number of characters successfully written. * Writes a string to a file at path and returns the number of characters successfully written.
* If an file already exists at path, its contents will be erased. * If a file already exists at path, its contents will be erased.
* If the filesystem object at path is not a file, this function returns 0. * If the filesystem object at path is not a file, this function returns 0.
* *
* @param path Filesystem path * @param path Filesystem path
@ -95,7 +95,6 @@ template <typename Path>
/** /**
* Appends a string to a file at path and returns the number of characters successfully written. * Appends a string to a file at path and returns the number of characters successfully written.
* If a file does not exist at path, WriteStringToFile is called instead.
* If the filesystem object at path is not a file, this function returns 0. * If the filesystem object at path is not a file, this function returns 0.
* *
* @param path Filesystem path * @param path Filesystem path