N-archive/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu.git synced 2024-11-21 14:22:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: image views segfaulting

Browse source
This commit is contained in:
Samuliak 2024-10-06 19:35:15 +02:00
parent d6148b194e
commit 79e86ed1b6
No known key found for this signature in database
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/video_core/renderer_metal/mtl_texture_cache.cpp
View file

@ -122,17 +122,16 @@ ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::ImageViewI
ImageId image_id_, Image& image) ImageId image_id_, Image& image)
: VideoCommon::ImageViewBase{info, image.info, image_id_, image.gpu_addr} { : VideoCommon::ImageViewBase{info, image.info, image_id_, image.gpu_addr} {
using Shader::TextureType; using Shader::TextureType;
if (image.GetHandle()) { texture = image.GetHandle();
texture = image.GetHandle()->retain();
}
// TODO: create texture view // TODO: implement
} }
// TODO: save slot images
ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::ImageViewInfo& info, ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::ImageViewInfo& info,
ImageId image_id_, Image& image, const SlotVector<Image>& slot_imgs) ImageId image_id_, Image& image, const SlotVector<Image>& slot_imgs)
: ImageView(runtime, info, image_id_, image) { : ImageView(runtime, info, image_id_, image) {
// TODO: save slot images texture = image.GetHandle();
} }
ImageView::ImageView(TextureCacheRuntime&, const VideoCommon::ImageInfo& info, ImageView::ImageView(TextureCacheRuntime&, const VideoCommon::ImageInfo& info,
@ -147,9 +146,8 @@ ImageView::ImageView(TextureCacheRuntime& runtime, const VideoCommon::NullImageV
} }
ImageView::~ImageView() { ImageView::~ImageView() {
if (texture) { // TODO: uncomment
texture->release(); // texture->release();
}
} }
Sampler::Sampler(TextureCacheRuntime& runtime, const Tegra::Texture::TSCEntry& tsc) { Sampler::Sampler(TextureCacheRuntime& runtime, const Tegra::Texture::TSCEntry& tsc) {