N-archive/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu.git synced 2024-11-27 01:02:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

k_auto_object: Fix data race

Browse source 
Change the memory order to acqure-release when we decrement the
reference count. Prevents a race with line 89 reported by TSan.
This commit is contained in:
lat9nq 2022-04-01 19:54:35 -04:00
parent 6bcbbb29e7
commit 983916e919
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/hle/kernel/k_auto_object.h
View file

@ -163,7 +163,7 @@ public:
do { do {
ASSERT(cur_ref_count > 0); ASSERT(cur_ref_count > 0);
} while (!m_ref_count.compare_exchange_weak(cur_ref_count, cur_ref_count - 1, } while (!m_ref_count.compare_exchange_weak(cur_ref_count, cur_ref_count - 1,
std::memory_order_relaxed)); std::memory_order_acq_rel));
// If ref count hits zero, destroy the object. // If ref count hits zero, destroy the object.
if (cur_ref_count - 1 == 0) { if (cur_ref_count - 1 == 0) {