N-archive/suyu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #5902 from lioncash/core-warn

Browse source 
core: Silence various warnings on Clang 12
This commit is contained in:
bunnei 2021-02-11 18:57:23 -08:00 committed by GitHub
commit a0379c2db5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/core/hle/service/am/applets/controller.cpp
View file

@ -211,7 +211,8 @@ void Controller::Execute() {
case ControllerSupportMode::ShowControllerFirmwareUpdate: case ControllerSupportMode::ShowControllerFirmwareUpdate:
UNIMPLEMENTED_MSG("ControllerSupportMode={} is not implemented", UNIMPLEMENTED_MSG("ControllerSupportMode={} is not implemented",
controller_private_arg.mode); controller_private_arg.mode);
[[fallthrough]]; ConfigurationComplete();
break;
default: { default: {
ConfigurationComplete(); ConfigurationComplete();
break; break;

2
src/core/hle/service/nfp/nfp.cpp
View file

@ -215,7 +215,7 @@ private:
const auto& amiibo = nfp_interface.GetAmiiboBuffer(); const auto& amiibo = nfp_interface.GetAmiiboBuffer();
const TagInfo tag_info{ const TagInfo tag_info{
.uuid = amiibo.uuid, .uuid = amiibo.uuid,
.uuid_length = static_cast<u8>(tag_info.uuid.size()), .uuid_length = static_cast<u8>(amiibo.uuid.size()),
.padding_1 = {}, .padding_1 = {},
.protocol = 1, // TODO(ogniK): Figure out actual values .protocol = 1, // TODO(ogniK): Figure out actual values
.tag_type = 2, .tag_type = 2,

6
src/core/hle/service/sockets/bsd.cpp
View file

@ -453,7 +453,8 @@ std::pair<s32, Errno> BSD::SocketImpl(Domain domain, Type type, Protocol protoco
return {-1, Errno::MFILE}; return {-1, Errno::MFILE};
} }
FileDescriptor& descriptor = file_descriptors[fd].emplace(); file_descriptors[fd] = FileDescriptor{};
FileDescriptor& descriptor = *file_descriptors[fd];
// ENONMEM might be thrown here // ENONMEM might be thrown here
LOG_INFO(Service, "New socket fd={}", fd); LOG_INFO(Service, "New socket fd={}", fd);
@ -548,7 +549,8 @@ std::pair<s32, Errno> BSD::AcceptImpl(s32 fd, std::vector<u8>& write_buffer) {
return {-1, Translate(bsd_errno)}; return {-1, Translate(bsd_errno)};
} }
FileDescriptor& new_descriptor = file_descriptors[new_fd].emplace(); file_descriptors[new_fd] = FileDescriptor{};
FileDescriptor& new_descriptor = *file_descriptors[new_fd];
new_descriptor.socket = std::move(result.socket); new_descriptor.socket = std::move(result.socket);
new_descriptor.is_connection_based = descriptor.is_connection_based; new_descriptor.is_connection_based = descriptor.is_connection_based;