N-archive/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu.git synced 2024-11-14 19:02:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

thread: Remove unnecessary memset from ResetThreadContext()

Browse source 
Regular value initialization is adequate here for zeroing out data. It
also has the benefit of not invoking undefined behavior if a non-trivial
type is ever added to the struct for whatever reason.
This commit is contained in:
Lioncash 2018-10-12 10:57:28 -04:00
parent 9bf409f275
commit b492d43e63
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/core/hle/kernel/thread.cpp
View file

@ -183,13 +183,10 @@ void Thread::ResumeFromWait() {
*/ */
static void ResetThreadContext(Core::ARM_Interface::ThreadContext& context, VAddr stack_top, static void ResetThreadContext(Core::ARM_Interface::ThreadContext& context, VAddr stack_top,
VAddr entry_point, u64 arg) { VAddr entry_point, u64 arg) {
memset(&context, 0, sizeof(Core::ARM_Interface::ThreadContext)); context = {};
context.cpu_registers[0] = arg; context.cpu_registers[0] = arg;
context.pc = entry_point; context.pc = entry_point;
context.sp = stack_top; context.sp = stack_top;
context.pstate = 0;
context.fpcr = 0;
} }
ResultVal<SharedPtr<Thread>> Thread::Create(KernelCore& kernel, std::string name, VAddr entry_point, ResultVal<SharedPtr<Thread>> Thread::Create(KernelCore& kernel, std::string name, VAddr entry_point,