N-archive/suyu
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/suyu.git synced 2024-11-29 10:12:46 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #7579 from Morph1984/swkbd-oob-array-access

Browse source 
qt_software_keyboard: Fix out of bounds array access
This commit is contained in:
Mai M 2021-12-14 23:42:07 -05:00 committed by GitHub
commit f0ed11e318
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/yuzu/applets/qt_software_keyboard.cpp
View file

@ -475,11 +475,26 @@ void QtSoftwareKeyboardDialog::open() {
row = 0; row = 0;
column = 0; column = 0;
const auto* const curr_button = switch (bottom_osk_index) {
keyboard_buttons[static_cast<int>(bottom_osk_index)][row][column]; case BottomOSKIndex::LowerCase:
case BottomOSKIndex::UpperCase: {
const auto* const curr_button =
keyboard_buttons[static_cast<std::size_t>(bottom_osk_index)][row][column];
// This is a workaround for setFocus() randomly not showing focus in the UI // This is a workaround for setFocus() randomly not showing focus in the UI
QCursor::setPos(curr_button->mapToGlobal(curr_button->rect().center())); QCursor::setPos(curr_button->mapToGlobal(curr_button->rect().center()));
break;
}
case BottomOSKIndex::NumberPad: {
const auto* const curr_button = numberpad_buttons[row][column];
// This is a workaround for setFocus() randomly not showing focus in the UI
QCursor::setPos(curr_button->mapToGlobal(curr_button->rect().center()));
break;
}
default:
break;
}
StartInputThread(); StartInputThread();
} }