2022-04-23 10:59:50 +02:00
|
|
|
// SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project
|
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2019-10-27 07:40:08 +01:00
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
2021-03-03 01:57:53 +01:00
|
|
|
#include <array>
|
|
|
|
#include <atomic>
|
2019-10-27 07:40:08 +01:00
|
|
|
|
|
|
|
#include "common/common_types.h"
|
|
|
|
#include "video_core/rasterizer_interface.h"
|
|
|
|
|
2020-03-31 21:10:44 +02:00
|
|
|
namespace Core::Memory {
|
2019-11-26 20:10:49 +01:00
|
|
|
class Memory;
|
|
|
|
}
|
|
|
|
|
2019-10-27 07:40:08 +01:00
|
|
|
namespace VideoCore {
|
|
|
|
|
|
|
|
/// Implements the shared part in GPU accelerated rasterizers in RasterizerInterface.
|
|
|
|
class RasterizerAccelerated : public RasterizerInterface {
|
|
|
|
public:
|
2020-03-31 21:10:44 +02:00
|
|
|
explicit RasterizerAccelerated(Core::Memory::Memory& cpu_memory_);
|
2019-10-27 07:40:08 +01:00
|
|
|
~RasterizerAccelerated() override;
|
|
|
|
|
|
|
|
void UpdatePagesCachedCount(VAddr addr, u64 size, int delta) override;
|
|
|
|
|
|
|
|
private:
|
2021-03-03 01:57:53 +01:00
|
|
|
class CacheEntry final {
|
|
|
|
public:
|
|
|
|
CacheEntry() = default;
|
|
|
|
|
2021-05-27 23:47:24 +02:00
|
|
|
std::atomic_uint16_t& Count(std::size_t page) {
|
|
|
|
return values[page & 3];
|
2021-03-03 01:57:53 +01:00
|
|
|
}
|
|
|
|
|
2021-05-27 23:47:24 +02:00
|
|
|
const std::atomic_uint16_t& Count(std::size_t page) const {
|
|
|
|
return values[page & 3];
|
2021-03-03 01:57:53 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
2021-05-27 23:47:24 +02:00
|
|
|
std::array<std::atomic_uint16_t, 4> values{};
|
2021-03-03 01:57:53 +01:00
|
|
|
};
|
|
|
|
static_assert(sizeof(CacheEntry) == 8, "CacheEntry should be 8 bytes!");
|
2019-11-26 20:10:49 +01:00
|
|
|
|
Fixes and workarounds to make UBSan happier on macOS
There are still some other issues not addressed here, but it's a start.
Workarounds for false-positive reports:
- `RasterizerAccelerated`: Put a gigantic array behind a `unique_ptr`,
because UBSan has a [hardcoded limit](https://stackoverflow.com/questions/64531383/c-runtime-error-using-fsanitize-undefined-object-has-a-possibly-invalid-vp)
of how big it thinks objects can be, specifically when dealing with
offset-to-top values used with multiple inheritance. Hopefully this
doesn't have a performance impact.
- `QueryCacheBase::QueryCacheBase`: Avoid an operation that UBSan thinks
is UB even though it at least arguably isn't. See the link in the
comment for more information.
Fixes for correct reports:
- `PageTable`, `Memory`: Use `uintptr_t` values instead of pointers to
avoid UB from pointer overflow (when pointer arithmetic wraps around
the address space).
- `KScheduler::Reload`: `thread->GetOwnerProcess()` can be `nullptr`;
avoid calling methods on it in this case. (The existing code returns
a garbage reference to a field, which is then passed into
`LoadWatchpointArray`, and apparently it's never used, so it's
harmless in practice but still triggers UBSan.)
- `KAutoObject::Close`: This function calls `this->Destroy()`, which
overwrites the beginning of the object with junk (specifically a free
list pointer). Then it calls `this->UnregisterWithKernel()`. UBSan
complains about a type mismatch because the vtable has been
overwritten, and I believe this is indeed UB. `UnregisterWithKernel`
also loads `m_kernel` from the 'freed' object, which seems to be
technically safe (the overwriting doesn't extend as far as that
field), but seems dubious. Switch to a `static` method and load
`m_kernel` in advance.
2023-07-02 00:00:39 +02:00
|
|
|
using CachedPages = std::array<CacheEntry, 0x2000000>;
|
|
|
|
std::unique_ptr<CachedPages> cached_pages;
|
2020-03-31 21:10:44 +02:00
|
|
|
Core::Memory::Memory& cpu_memory;
|
2019-10-27 07:40:08 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
} // namespace VideoCore
|