From be06b21f7bf23a1a5f9388a54c68309eea888063 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 6 Jul 2020 09:03:00 -0400 Subject: [PATCH] configure_graphics: Prevent unnecessary string copies in UpdateDeviceComboBox() Unlikely to impact performance at all, but this is essentially a "free" transformation, so why not? --- src/yuzu/configuration/configure_graphics.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/yuzu/configuration/configure_graphics.cpp b/src/yuzu/configuration/configure_graphics.cpp index 304625cd7..e8c8f5f20 100644 --- a/src/yuzu/configuration/configure_graphics.cpp +++ b/src/yuzu/configuration/configure_graphics.cpp @@ -112,7 +112,7 @@ void ConfigureGraphics::UpdateDeviceComboBox() { enabled = false; break; case Settings::RendererBackend::Vulkan: - for (const auto device : vulkan_devices) { + for (const auto& device : vulkan_devices) { ui->device->addItem(device); } ui->device->setCurrentIndex(vulkan_device);