bd0c56c6e7
* IOFile: Make the move constructor and move assignment operator noexcept Certain parts of the standard library try to determine whether or not a transfer operation should either be a copy or a move. The prevalent notion of move constructors/assignment operators is that they should not throw, they simply move an already existing resource somewhere else. This is typically done with 'std::move_if_noexcept'. Like the name says, if a type's move constructor is noexcept, then the functions retrieves an r-value reference (for move semantics), or an l-value (for copy semantics) if it is not noexcept. As IOFile deletes the copy constructor and copy assignment operators, using IOFile with certain parts of the standard library can fail in unexcepted ways (especially when used with various container implementations). This prevents that. * fix various instances of -1 being assigned to unsigned types * do not assign in conditional statements * File/IOFile: Check _tfopen_s properly * common/file_util.cpp: address review comments Co-authored-by: Lioncash <mathew1800@gmail.com> Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com> Co-authored-by: Sepalani <sepalani@hotmail.fr>
75 lines
2 KiB
C++
75 lines
2 KiB
C++
// Copyright 2013 Dolphin Emulator Project / 2014 Citra Emulator Project
|
|
// Licensed under GPLv2 or any later version
|
|
// Refer to the license.txt file included.
|
|
|
|
#include "common/thread.h"
|
|
#ifdef __APPLE__
|
|
#include <mach/mach.h>
|
|
#elif defined(_WIN32)
|
|
#include <windows.h>
|
|
#else
|
|
#if defined(__Bitrig__) || defined(__DragonFly__) || defined(__FreeBSD__) || defined(__OpenBSD__)
|
|
#include <pthread_np.h>
|
|
#else
|
|
#include <pthread.h>
|
|
#endif
|
|
#include <sched.h>
|
|
#endif
|
|
#ifndef _WIN32
|
|
#include <unistd.h>
|
|
#endif
|
|
|
|
#ifdef __FreeBSD__
|
|
#define cpu_set_t cpuset_t
|
|
#endif
|
|
|
|
namespace Common {
|
|
|
|
#ifdef _MSC_VER
|
|
|
|
// Sets the debugger-visible name of the current thread.
|
|
// Uses trick documented in:
|
|
// https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread-name-in-native-code
|
|
void SetCurrentThreadName(const char* name) {
|
|
static const DWORD MS_VC_EXCEPTION = 0x406D1388;
|
|
|
|
#pragma pack(push, 8)
|
|
struct THREADNAME_INFO {
|
|
DWORD dwType; // must be 0x1000
|
|
LPCSTR szName; // pointer to name (in user addr space)
|
|
DWORD dwThreadID; // thread ID (-1=caller thread)
|
|
DWORD dwFlags; // reserved for future use, must be zero
|
|
} info;
|
|
#pragma pack(pop)
|
|
|
|
info.dwType = 0x1000;
|
|
info.szName = name;
|
|
info.dwThreadID = std::numeric_limits<DWORD>::max();
|
|
info.dwFlags = 0;
|
|
|
|
__try {
|
|
RaiseException(MS_VC_EXCEPTION, 0, sizeof(info) / sizeof(ULONG_PTR), (ULONG_PTR*)&info);
|
|
} __except (EXCEPTION_CONTINUE_EXECUTION) {
|
|
}
|
|
}
|
|
|
|
#else // !MSVC_VER, so must be POSIX threads
|
|
|
|
// MinGW with the POSIX threading model does not support pthread_setname_np
|
|
#if !defined(_WIN32) || defined(_MSC_VER)
|
|
void SetCurrentThreadName(const char* name) {
|
|
#ifdef __APPLE__
|
|
pthread_setname_np(name);
|
|
#elif defined(__Bitrig__) || defined(__DragonFly__) || defined(__FreeBSD__) || defined(__OpenBSD__)
|
|
pthread_set_name_np(pthread_self(), name);
|
|
#elif defined(__NetBSD__)
|
|
pthread_setname_np(pthread_self(), "%s", (void*)name);
|
|
#else
|
|
pthread_setname_np(pthread_self(), name);
|
|
#endif
|
|
}
|
|
#endif
|
|
|
|
#endif
|
|
|
|
} // namespace Common
|