1
0
Fork 0

Rename Phabricator Variables Injected to TC builds

To make sure there are no naming conflicts with teamcity environment variable we are renaming the vars injected to the build via the harbormaster trigger.
This commit is contained in:
Steven Cooney 2019-05-31 12:37:30 +01:00
parent 5f25b065aa
commit 265318a9ce

View file

@ -24,12 +24,12 @@ final class TeamCityXmlBuildBuilder {
}
function addPhabBuildId($buildId){
$this->addProperty("env.buildId", $buildId);
$this->addProperty("env.PHAB_BUILD_ID", $buildId);
return $this;
}
function addRevisionId($revisionId){
$this->addProperty("env.revisionId", $revisionId);
$this->addProperty("env.PHAB_REVISION_ID", $revisionId);
return $this;
}
@ -37,18 +37,18 @@ final class TeamCityXmlBuildBuilder {
// $this->
// root->
// setAttribute('branchName', $branchName);
$this->addProperty("env.branchName", $branchName);
$this->addProperty("env.PHAB_BRANCH_NAME", $branchName);
return $this;
}
function addHarbormasterPHID($phid){
$this->addProperty('env.harbormasterTargetPHID', $phid);
$this->addProperty('env.PHAB_HARBORMASTER_TARGET_PHID', $phid);
return $this;
}
function addDiffId($diffId){
$this->addProperty('env.diffId', $diffId);
$this->addProperty('env.PHAB_DIFF_ID', $diffId);
return $this;
}