From 3564d1492797b98688d1be7b062d2b54ed97ab6c Mon Sep 17 00:00:00 2001 From: Steven Cooney Date: Wed, 5 Jun 2019 16:38:13 +0100 Subject: [PATCH] Skip Patch When Plugin Not Installed Explicitly set `phabricatorTriggeredBuild` to false on exit points on `AgentBuildExtension` because we are seeing behaviour that suggest the default value is not used in the `sourcesUpdated` step --- .../java/uk/xlab/teamcity/phabricator/AgentBuildExtension.java | 1 + 1 file changed, 1 insertion(+) diff --git a/Teamcity-Phabricator-Plugin/phabricator-plugin-agent/src/main/java/uk/xlab/teamcity/phabricator/AgentBuildExtension.java b/Teamcity-Phabricator-Plugin/phabricator-plugin-agent/src/main/java/uk/xlab/teamcity/phabricator/AgentBuildExtension.java index 421f575..6a08699 100644 --- a/Teamcity-Phabricator-Plugin/phabricator-plugin-agent/src/main/java/uk/xlab/teamcity/phabricator/AgentBuildExtension.java +++ b/Teamcity-Phabricator-Plugin/phabricator-plugin-agent/src/main/java/uk/xlab/teamcity/phabricator/AgentBuildExtension.java @@ -42,6 +42,7 @@ public class AgentBuildExtension extends AgentLifeCycleAdapter { .getBuildFeaturesOfType(Constants.BUILD_FEATURE_TYPE); if (phabricatorBuildFeatureParameters.isEmpty()) { + phabricatorTriggeredBuild = false; return; }