diff --git a/Teamcity-Phabricator-Plugin/phabricator-plugin-common/pom.xml b/Teamcity-Phabricator-Plugin/phabricator-plugin-common/pom.xml index e13efa1..e384158 100644 --- a/Teamcity-Phabricator-Plugin/phabricator-plugin-common/pom.xml +++ b/Teamcity-Phabricator-Plugin/phabricator-plugin-common/pom.xml @@ -8,6 +8,15 @@ phabricator-plugin-common jar + + + + org.jetbrains.teamcity + common-api + ${teamcity-version} + provided + + diff --git a/Teamcity-Phabricator-Plugin/phabricator-plugin-common/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginLogger.java b/Teamcity-Phabricator-Plugin/phabricator-plugin-common/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginLogger.java new file mode 100644 index 0000000..7df96e2 --- /dev/null +++ b/Teamcity-Phabricator-Plugin/phabricator-plugin-common/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginLogger.java @@ -0,0 +1,22 @@ +package uk.xlab.teamcity.phabricator; + +import jetbrains.buildServer.log.Loggers; + +public final class PhabricatorPluginLogger { + + public void serverInfo(String message) { + Loggers.SERVER.info(String.format("Phabricator Plugin: %s", message)); + } + + public void serverWarn(String message, Exception e) { + Loggers.SERVER.warn(message, e); + } + + public void agentInfo(String message) { + Loggers.AGENT.info(String.format("Phabricator Plugin: %s", message)); + } + + public void agentWarn(String message, Exception e) { + Loggers.AGENT.warn(String.format("Phabricator Plugin: %s", message), e); + } +} diff --git a/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginBuildFeature.java b/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginBuildFeature.java index 1c85455..58eceb7 100644 --- a/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginBuildFeature.java +++ b/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/java/uk/xlab/teamcity/phabricator/PhabricatorPluginBuildFeature.java @@ -4,17 +4,22 @@ import java.util.Map; import org.jetbrains.annotations.NotNull; -import jetbrains.buildServer.log.Loggers; import jetbrains.buildServer.serverSide.BuildFeature; import jetbrains.buildServer.web.openapi.PluginDescriptor; public class PhabricatorPluginBuildFeature extends BuildFeature { - private final String myEditUrl; - public PhabricatorPluginBuildFeature(@NotNull final PluginDescriptor pluginDescriptor) { + private final String myEditUrl; + private PhabricatorPluginLogger logger; + + public PhabricatorPluginBuildFeature( + @NotNull final PluginDescriptor pluginDescriptor, + @NotNull final PhabricatorPluginLogger logger + ) { myEditUrl = pluginDescriptor.getPluginResourcesPath("phabricatorBuildFeature.jsp"); + this.logger = logger; - Loggers.SERVER.info("Phabricator build feature registered"); + this.logger.serverInfo("Build feature registered"); } @Override diff --git a/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/resources/META-INF/build-server-plugin-phabricator-plugin.xml b/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/resources/META-INF/build-server-plugin-phabricator-plugin.xml index f6033b1..df2dc83 100644 --- a/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/resources/META-INF/build-server-plugin-phabricator-plugin.xml +++ b/Teamcity-Phabricator-Plugin/phabricator-plugin-server/src/main/resources/META-INF/build-server-plugin-phabricator-plugin.xml @@ -4,5 +4,6 @@ xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd" default-autowire="constructor"> - + +