2020-01-23 11:17:23 +01:00
|
|
|
# clang-tidy checks
|
2020-01-23 14:16:42 +01:00
|
|
|
## Warning is not useful
|
2020-01-23 11:17:23 +01:00
|
|
|
If you found that a warning produced by clang-tidy is not useful:
|
|
|
|
|
|
|
|
|
|
- If clang-tidy must not run for some files at all (e.g. lit test), please
|
2020-06-22 17:49:19 +02:00
|
|
|
[add files to ignorelist](../scripts/clang-tidy.ignore).
|
2020-01-23 11:17:23 +01:00
|
|
|
|
|
|
|
|
- Consider fixing or [suppressing diagnostic](https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics)
|
|
|
|
|
if there is a good reason.
|
|
|
|
|
|
2020-01-23 14:16:42 +01:00
|
|
|
- [File a bug](https://github.com/google/llvm-premerge-checks/issues/new?assignees=&labels=bug&template=bug_report.md&title=)
|
2020-01-23 11:17:23 +01:00
|
|
|
if build process should be improved.
|
|
|
|
|
|
|
|
|
|
- If you believe that you found a clang-tidy bug then please keep in mind that clang-tidy version run by bot
|
|
|
|
|
might not be most recent. Please reproduce your issue on current version before submitting a bug to clang-tidy.
|
|
|
|
|
|
|
|
|
|
## Review comments
|
|
|
|
|
|
|
|
|
|
Build bot leaves inline comments only for a small subset of files that are not blacklisted for analysis (see above) *and*
|
|
|
|
|
specifically whitelisted for comments.
|
|
|
|
|
|
|
|
|
|
That is done to avoid potential noise when a file already contains a number of warnings.
|
|
|
|
|
|
|
|
|
|
If your are confident that some files are in good shape already, please
|
2020-01-23 14:17:33 +01:00
|
|
|
[whitelist them](../scripts/clang-tidy-comments.ignore).
|
2020-01-23 11:17:23 +01:00
|
|
|
|
|
|
|
|
----
|
|
|
|
|
|
2020-08-27 11:21:35 +02:00
|
|
|
[about pre-merge checks](../README.md)
|
