revi-archive/llvm-premerge-checks
1
0
Fork 0
Code Activity

handling broken XML files

Browse source
This commit is contained in:
Christian Kühnel 2020-02-18 09:55:24 +01:00
parent 71240e7473
commit 22ce8e9632
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
scripts/phabtalk/phabtalk.py
View file

@ -233,7 +233,16 @@ class BuildReport:
else: else:
self.success = False self.success = False
self.add_test_results() try:
self.add_test_results()
except etree.XMLSyntaxError:
# Sometimes we get an incomplete XML file.
# In this case:
# - fail the build (the safe thing to do)
# - continue so the user gets some feedback.
print('Error parsing {}. Invalid XML syntax!'.format(self.test_result_file))
self.success = False
self.add_clang_tidy() self.add_clang_tidy()
self.add_clang_format() self.add_clang_format()
self.api.update_build_status(self.diff_id, self.ph_id, self.working, self.success, self.lint, self.unit) self.api.update_build_status(self.diff_id, self.ph_id, self.working, self.success, self.lint, self.unit)