revi-archive/llvm-premerge-checks
1
0
Fork 0
Code Activity

no error message when no clang-tidy/format files given

Browse source
This commit is contained in:
Christian Kühnel 2020-02-17 16:34:00 +00:00
parent cbe186f02b
commit 3b593e36cf
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scripts/phabtalk/phabtalk.py
View file

@ -263,7 +263,9 @@ class BuildReport:
def add_clang_format(self):
"""Populates results from diff produced by clang format."""
present = (self.clang_format_patch is not None) and os.path.exists(
if self.clang_format_patch is None:
return
present = os.path.exists(
os.path.join(self.results_dir, self.clang_format_patch))
if not present:
print('clang-format result {} is not found'.format(self.clang_format_patch))
@ -294,11 +296,13 @@ class BuildReport:
def add_clang_tidy(self):
# Typical message looks like
# [..]/clang/include/clang/AST/DeclCXX.h:3058:20: error: no member named 'LifetimeExtendedTemporary' in 'clang::Decl' [clang-diagnostic-error]
if self.clang_tidy_result is None:
return
pattern = '^{}/([^:]*):(\\d+):(\\d+): (.*): (.*)'.format(self.workspace)
errors_count = 0
warn_count = 0
inline_comments = 0
present = (self.clang_tidy_result is not None) and os.path.exists(
present = os.path.exists(
os.path.join(self.results_dir, self.clang_tidy_result))
if not present:
print('clang-tidy result {} is not found'.format(self.clang_tidy_result))