lessonsn learned from next agent

docs/playbooks.md

@@ -130,7 +130,7 @@ Invoke-WebRequest -uri 'https://raw.githubusercontent.com/google/llvm-premerge-c
 TODO: add documentation on how to create these.
 1. run this script to start containers:
 ```cmd
-powershell Invoke-WebRequest -uri 'https://raw.githubusercontent.com/google/llvm-premerge-checks/master/scripts/windows_agent_start.ps1' -OutFile windows_agent_bootstrap.ps1
+powershell Invoke-WebRequest -uri 'https://raw.githubusercontent.com/google/llvm-premerge-checks/master/scripts/windows_agent_bootstrap.ps1' -OutFile windows_agent_bootstrap.ps1
 
 .\windows_agent_bootstrap.ps1
 ```

scripts/windows_agent_bootstrap.ps1

@@ -28,6 +28,10 @@ iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.p
 choco feature disable --name showDownloadProgress
 choco install -y git
 
+# move docker folder to SSD to get better IO performance
+New-Item -Path "D:\" -Name "Docker" -ItemType "directory"
+cmd /C "mklink /j C:\ProgramData\Docker D:\docker"
+
 # install Docker
 Install-PackageProvider -Name NuGet -Force
 Install-Module -Name DockerMsftProvider -Repository PSGallery -Force
@@ -37,11 +41,6 @@ Set-Service -Name docker  -StartupType Automatic
 # install gcloud and authenticate access to gcr.io registry
 # TODO: find a better way to install the Google Cloud SDK, avoid ingoring the checksum
 choco install -y gcloudsdk --ignore-checksums
-gcloud auth docker
-
-# move docker folder to SSD to get better IO performance
-New-Item -Path "D:\" -Name "Docker" -ItemType "directory"
-cmd /C "mklink /j C:\ProgramData\Docker D:\docker"
 
 # Reboot
 Restart-Computer -Force

scripts/windows_agent_start.ps1

@@ -18,6 +18,9 @@
 $NAME="agent-windows-jenkins"
 $IMAGE="gcr.io/llvm-premerge-checks/${NAME}"
 
+Write-Output "Authenticating docker..."
+echo "y`n" | gcloud auth configure-docker
+
 Write-Output "Pulling new image..."
 docker pull ${IMAGE}