revi-archive/llvm-premerge-checks
1
0
Fork 0
Code Activity

Merge pull request #217 from google/link-to-log

Browse source 
Add link to ninja log instead of XML #216
This commit is contained in:
Mikhail Goncharov 2020-07-22 15:47:06 +02:00 committed by GitHub
commit 724a11a7f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
scripts/premerge_checks.py
View file

@ -50,6 +50,8 @@ def ninja_all_report(step: Step, _: Report, filter_output: bool):
'ninja all', cwd=build_dir)
logging.debug(f'ninja all: returned {rc}')
step.set_status_from_exit_code(rc)
if not step.success:
report.add_artifact(artifacts_dir, 'ninja-all.log', 'build failed')
def ninja_check_all_report(step: Step, _: Report, filter_output: bool):
@ -67,6 +69,14 @@ def ninja_check_all_report(step: Step, _: Report, filter_output: bool):
logging.debug(f'ninja check-all: returned {rc}')
step.set_status_from_exit_code(rc)
test_results_report.run(build_dir, 'test-results.xml', step, report)
if not step.success:
message = 'tests failed'
f = report.test_stats['fail']
if f == 1:
message = '1 test failed'
if f > 1:
message = f'{f} tests failed'
report.add_artifact(artifacts_dir, 'ninja-check-all.log', message)
def run_step(name: str, report: Report, thunk: Callable[[Step, Report], None]) -> Step:

1
scripts/test_results_report.py
View file

@ -32,7 +32,6 @@ def run(working_dir: str, test_results: str, step: Optional[Step], report: Optio
step.success = False
step.messages.append(f'test report "{path}" is not found')
return
report.add_artifact(working_dir, test_results, 'test results')
try:
success = True
root_node = etree.parse(path)