1
0
Fork 0
Commit graph

59 commits

Author SHA1 Message Date
Mikhail Goncharov
429c70ddc9 fix links 2020-01-23 14:13:42 +01:00
Mikhail Goncharov
ce74784e48
Merge pull request #104 from google/bot-text
Update bot report
2020-01-23 13:36:20 +01:00
Mikhail Goncharov
a3f6610df2 Update bot report
- add links to join beta and report issue
- add link "not useful" to clang-tidy warning
- clang-tidy comment in report now tells how many inline comments were
  added
2020-01-23 13:35:40 +01:00
Christian Kühnel
9f3db2cc48 handling base revision not found
using master instead
2020-01-23 09:47:59 +01:00
Mikhail Goncharov
bf98f92a3d print current git commit info on checkout and while applying patch 2020-01-23 09:32:45 +01:00
Mikhail Goncharov
276978ff1f Ignore selected paths for clang-format and clang-tidy
Now clang-format report will skip files matching `clang-format.ignore`.
For now it's empty.

clang-tidy will not receive diffs for `clang-tidy.ignore` (it still can
produce warnings for these files).
In addition build bot will not will not post comments for files
that are matched by `clang-tidy-comments.ignore`. Now project/file should
be whitelisted to receive inline comments from clang-tidy.

Added all /test directories to `clang-tidy.ignore`.

Other alternatives considered:

- using 'compile_commands.json': does not contain header files.
- specifying -regex option to 'clang-tidy-diff': probably not the best
  experience of providing multiple rules and maintaining a single regex.
2020-01-22 19:05:36 +01:00
Mikhail Goncharov
f998580ba2 fix requirements.txt 2020-01-22 18:27:04 +01:00
Mikhail Goncharov
7e54c937c8 Add pathspec pip package. 2020-01-22 18:04:18 +01:00
Christian Kühnel
6dfeb6a728 using patch instead of "git apply" 2020-01-22 13:21:02 +01:00
Christian Kühnel
d99d32bdaa added git reset 2020-01-22 12:08:51 +00:00
Christian Kühnel
4bb77853ca Merge branch 'master' of ssh://github.com/google/llvm-premerge-checks 2020-01-22 10:39:47 +00:00
Christian Kühnel
83e9732126 using given base revision 2020-01-22 11:39:20 +01:00
Christian Kühnel
c6083e3cf4 added "done" to comd output 2020-01-20 13:16:45 +00:00
Christian Kühnel
398656cc7e using patch command 2020-01-20 13:14:29 +00:00
Christian Kühnel
a3ed6589f4 added git-clean 2020-01-20 13:04:09 +00:00
Christian Kühnel
677b7fbe89 removed uplicate entry 2020-01-20 12:32:17 +00:00
Christian Kühnel
1fc40ffedd fixed bug when diff has no dependencies 2020-01-20 13:29:58 +01:00
Christian Kühnel
7228ab9fdc fixed variable 2020-01-20 12:45:07 +01:00
Christian Kühnel
a61428e5bb added missing self 2020-01-20 12:37:49 +01:00
Christian Kühnel
b4ac626be6 added retry library
to be used for retrying on phabricator interaction
2020-01-20 12:07:19 +01:00
Christian Kühnel
fe615f19bb calling update_interfaces 2020-01-20 12:06:57 +01:00
Christian Kühnel
3fd0d02cd0 added missing dependency 2020-01-16 14:21:13 +00:00
Christian Kühnel
b0263dd926 Created new apply_patch script
Should handle landed diffs better.
2020-01-15 17:40:32 +01:00
Mikhail Goncharov
453aa2ae84 Run clang-tidy and parse message
+ don't assume that clang-format has passed if there is no file.
  If linters didn't run at all file will be missing.
+ add "gray" icon for the result if it's unknown.
+ assume whole build is failed if clang-format or clang-tidy found something.
+ combine multiple lint messages per line.
2019-12-17 11:00:30 +01:00
Mikhail Goncharov
8d390ff370 Refactor Phabricator report construction
Now report is constructed by adding more data from several stages and
represents internal structure rather what API expects.

+ Made all function that don't interact with phabricator free standing
+ Now links list all files in results directory
+ Status icons

Example comment: https://reviews.llvm.org/D71197#1779176 (links don't work).
2019-12-11 14:36:20 +01:00
Mikhail Goncharov
7faaec98e7 Attach diffs produced by git-clang-format as lint messages.
E.g.: https://reviews.llvm.org/D71197?id=233029
Will add a link to file and code to apply the patch in the next PR.

+ don't create TARGET_DIR in scripts;
+ updated section about local build;
+ partially specified inputs / outputs of scripts so it's more transparent what are the results;
+ added symlink to compile_command.json (clang-tidy will need it);
+ add IDEA files to .gitignore.
2019-12-11 08:55:38 +01:00
Christian Kühnel
59e5bb8ed2 improved logging 2019-11-22 11:03:05 +01:00
Christian Kühnel
6708a6a900 Improved error messages for apply_patch
fixes #56
2019-11-22 10:42:51 +01:00
Christian Kühnel
0be0498203 fix handling of compile errors
addresses #63
2019-11-21 15:04:39 +01:00
Christian Kühnel
3c0461255c changed type of exception 2019-11-21 15:00:48 +01:00
Christian Kühnel
617f0db570 do not fail if log can't be crated 2019-11-18 17:19:13 +01:00
Christian Kühnel
8f72543819 printing message if patch successful 2019-11-18 17:07:31 +01:00
Christian Kühnel
65a9b864d2 running arc patch with --force 2019-11-18 17:02:24 +01:00
Christian Kühnel
b53b2110ef fixed raise statement 2019-11-18 16:41:44 +01:00
Christian Kühnel
f8eaba6cf1 fixed bug in subprocess.run 2019-11-18 16:38:55 +01:00
Christian Kühnel
d028ac35b1 improved error handling for arc patch 2019-11-18 16:36:23 +01:00
Christian Kühnel
db831d4c0e only posting non-empty comments 2019-11-18 16:22:43 +01:00
Christian Kühnel
c96a2d158c making feedback upload more relaxed if files are missing 2019-11-18 16:00:14 +01:00
Christian Kühnel
cbf1bee7da fixed imports 2019-11-18 12:17:06 +01:00
Christian Kühnel
1be0187f5e fixed json output 2019-11-18 12:06:22 +01:00
Christian Kühnel
4ebb7edb11 fixed typo in var name 2019-11-18 11:51:10 +01:00
Christian Kühnel
b1dde01ac0 added phid to log output 2019-11-18 11:46:57 +01:00
Christian Kühnel
124b7fd445 fix issues in apply_patch.py
to fix #56
2019-11-18 11:45:08 +01:00
Christian Kühnel
48567c02fe added retry on errors 2019-11-05 09:31:43 +01:00
Christian Kühnel
b99d01165e fixed bug in git checkout script 2019-10-31 11:33:23 +01:00
Christian Kühnel
ba0f07ffb4 added status output 2019-10-24 09:41:19 -07:00
Christian Kühnel
a6abec98d4 handling missing test result file as failted build 2019-10-24 04:41:57 -07:00
Christian Kühnel
e59db9cbcd added error handling to patch script 2019-10-23 06:39:24 -07:00
Christian Kühnel
86c9d08007 aded 'git clean' to the pipelines 2019-10-21 22:47:25 +02:00
Christian Kühnel
dddf48b57b added fallback for applying patch 2019-10-21 22:41:37 +02:00