revi-archive/llvm-premerge-checks
1
0
Fork 0
Code Activity
No description
812 commits 20 branches 1 tag 1.7 MiB
Python 72.3%
Dockerfile 9.4%
Shell 8.1%
PowerShell 5.8%
Jupyter Notebook 3.5%
Other 0.9%
Find a file
Mikhail Goncharov c350101a23 Allow projects to define custom steps 
Now it's possible to allow sub-projects to define own checks and skip
"generic" ones.

To properly accomodate affected projects that might not have special
treatment we:

1. extend the set of affected projecs with dependent (e.g. add 'libc' if
'clang' was modified)

2. add custom steps for projects that define own workflow. At the moment
it's only libcxx and it has a custom trigger pipeline so it's noop.

3. add dependent projects and run generic check on them.

To illustrate: imagine that we have a dependency graph:

llvm -> clang -> openmp

and only clang was modified in a diff; also clang defines own checks.
Thus list of affected projects will be [clang, openmp].
After adding custom checks and removing their projecst: [openmp].
After adding dependencies: [llvm, clang, openmp]. Generic linux /
windows checks will be run on thouse 3 projects.
So as you can see in some scenarios projects with custom checks will
still go through generic checks.

Note that clang-format and clang-tidy checks are run only for "generic"
checks at the moment.
2020-10-02 16:19:57 +02:00
.github/ISSUE_TEMPLATE Update bug_report.md 2019-12-11 16:06:13 +01:00
containers remove jenkins configs and scrips 2020-09-01 09:51:49 +02:00
docs Organize scripts 2020-10-02 14:18:22 +02:00
kubernetes Update nginx configuration to capture all traffic to the static IP 2020-09-29 11:44:12 +02:00
phabricator-proxy Allow other refspecs to be used. 2020-09-29 17:57:33 +02:00
scripts Allow projects to define custom steps 2020-10-02 16:19:57 +02:00
.editorconfig review fixes, formatted text 2020-08-27 15:30:03 +02:00
.gitignore Organize scripts 2020-10-02 14:18:22 +02:00
k8s_config added windows cluster 2020-02-03 12:41:54 +01:00
LICENSE added license 2019-10-04 14:31:57 +02:00
local_setup.sh Update nginx configuration to capture all traffic to the static IP 2020-09-29 11:44:12 +02:00
README.md Update nginx configuration to capture all traffic to the static IP 2020-09-29 11:44:12 +02:00

README.md

Status

❗ We have ongoing issue with windows build taking more that 2 hours to complete. That also causes follow up builds to fail. Thus windows builds are temporary disabled.

Overview

The pre-merge checks for the LLVM project are a continuous integration (CI) workflow. The workflow checks the patches the developers upload to the LLVM Phabricator instance.

Phabricator (https://reviews.llvm.org) is the code review tool in the LLVM project.

The workflow checks the patches before a user merges them to the master branch - thus the term pre-merge testing*. When a user uploads a patch to the LLVM Phabricator, Phabricator triggers the checks and then displays the results.

The CI system checks the patches before a user merges them to the master branch. This way bugs in a patch are contained during the code review stage and do not pollute the master branch. The more bugs the CI system can catch during the code review phase, the more stable and bug-free the master branch will become. citation needed

This repository contains the configurations and script to run pre-merge checks for the LLVM project.

Feedback

If you notice issues or have an idea on how to improve pre-merge checks, please create a new issue or give a ❤️ to an existing one.

Sign up for beta-test

To get the latest features and help us developing the project, sign up for the pre-merge beta testing by adding yourself to the "pre-merge beta testing" project on Phabricator.

Opt-out

In case you want to opt-out entirely of pre-merge testing, add yourself to the OPT OUT project.

If you decide to opt-out, please let us know why, so we might be able to improve in the future.

Requirements

The builds are only triggered if the Revision in Phabricator is created/updated via arc diff. If you update a Revision via the Web UI it will not trigger a build.

To get a patch on Phabricator tested the build server must be able to apply the patch to the checked out git repository. If you want to get your patch tested, please make sure that either:

  • You set a git hash as sourceControlBaseRevision in Phabricator which is
  • available on the Github repository, or you define the dependencies of your
  • patch in Phabricator, or your patch can be applied to the master branch.

Only then can the build server apply the patch locally and run the builds and tests.

Accessing results on Phabricator

Phabricator will automatically trigger a build for every new patch you upload or modify. Phabricator shows the build results at the top of the entry: build status

The CI will compile and run tests, run clang-format and clang-tidy on lines changed.

If a unit test failed, this is shown below the build status. You can also expand the unit test to see the details: unit test results.

Contributing

We're happy to get help on improving the infrastructure and workflows!

Please check contibuting first.

Development gives an overview how different parts interact together.

Playbooks shows concrete examples how to, for example, build and run agents locally.

If you have any questions please contact by mail or find user "goncharov" on LLVM Discord.

Additional Information

License

This project is licensed under the "Apache 2.0 with LLVM Exception" license. See LICENSE for details.