[Wilds] Remove libphutil
Summary:
Ref T13098. Historically, Phabricator was split into three parts:
- Phabricator, the server.
- Arcanist, the client.
- libphutil, libraries shared between the client and server.
One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use.
However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals.
Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library.
Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value.
Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users.
This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library.
Test Plan: Ran `arc`, it gets about as far as it did before.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13098
Differential Revision: https://secure.phabricator.com/D19688
2018-09-18 19:37:45 +02:00
|
|
|
#!/usr/bin/env php
|
|
|
|
<?php
|
|
|
|
|
2018-09-18 21:49:13 +02:00
|
|
|
require_once dirname(dirname(__FILE__)).'/init/init-script.php';
|
[Wilds] Remove libphutil
Summary:
Ref T13098. Historically, Phabricator was split into three parts:
- Phabricator, the server.
- Arcanist, the client.
- libphutil, libraries shared between the client and server.
One imagined use case for this was that `libphutil` might become a general-purpose library that other projects would use.
However, this didn't really happen, and it seems unlikely to at this point: Phabricator has become a relatively more sophisticated application platform; we didn't end up seeing or encouraging much custom development; what custom development there is basically embraces all of Phabricator since there are huge advantages to doing so; and a general "open source is awful" sort of factor here in the sense that open source users often don't have goals well aligned to our goals.
Turning "arc" into a client platform and building package management solidify us in this direction of being a standalone platform, not a standalone utility library.
Phabricator also depends on `arcanist/`. If it didn't, there would be a small advantage to saying "shared code + client for client, shared code + server for server", but there's no such distinction and it seems unlikely that one will ever exist. Even if it did, I think this has little value.
Nowadays, I think this separation has no advantages for us and one significant cost: it makes installing `arcanist` more difficult for end-users.
This will need some more finesssing (Phabricator will need some changes for compatibility, and a lot of stuff that still says "libphutil" or "phutil" may eventually want to say "arcanist"), and some stuff (like xhpast) is probably straight-up broken right now and needs some tweaking, but I don't anticipate any major issues here. There was never anything particularly magical about libphutil as a separate standalone library.
Test Plan: Ran `arc`, it gets about as far as it did before.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13098
Differential Revision: https://secure.phabricator.com/D19688
2018-09-18 19:37:45 +02:00
|
|
|
|
|
|
|
$args = new PhutilArgumentParser($argv);
|
|
|
|
$args->setTagline(pht('rebuild the library map file'));
|
|
|
|
$args->setSynopsis(<<<EOHELP
|
|
|
|
**phutil_rebuild_map.php** [__options__] __root__
|
|
|
|
Rebuild the library map file for a libphutil library.
|
|
|
|
|
|
|
|
EOHELP
|
|
|
|
);
|
|
|
|
|
|
|
|
$args->parseStandardArguments();
|
|
|
|
$args->parse(
|
|
|
|
array(
|
|
|
|
array(
|
|
|
|
'name' => 'quiet',
|
|
|
|
'help' => pht('Do not write status messages to stderr.'),
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
'name' => 'drop-cache',
|
|
|
|
'help' => pht(
|
|
|
|
'Drop the symbol cache and rebuild the entire map from scratch.'),
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
'name' => 'limit',
|
|
|
|
'param' => 'N',
|
|
|
|
'default' => 8,
|
|
|
|
'help' => pht(
|
|
|
|
'Controls the number of symbol mapper subprocesses run at once. '.
|
|
|
|
'Defaults to 8.'),
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
'name' => 'show',
|
|
|
|
'help' => pht(
|
|
|
|
'Print symbol map to stdout instead of writing it to the map file.'),
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
'name' => 'ugly',
|
|
|
|
'help' => pht(
|
|
|
|
'Use faster but less readable serialization for %s.',
|
|
|
|
'--show'),
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
'name' => 'root',
|
|
|
|
'wildcard' => true,
|
|
|
|
),
|
|
|
|
));
|
|
|
|
|
|
|
|
$root = $args->getArg('root');
|
|
|
|
if (count($root) !== 1) {
|
|
|
|
throw new Exception(pht('Provide exactly one library root!'));
|
|
|
|
}
|
|
|
|
$root = Filesystem::resolvePath(head($root));
|
|
|
|
|
|
|
|
$builder = new PhutilLibraryMapBuilder($root);
|
|
|
|
$builder->setQuiet($args->getArg('quiet'));
|
|
|
|
$builder->setSubprocessLimit($args->getArg('limit'));
|
|
|
|
|
|
|
|
if ($args->getArg('drop-cache')) {
|
|
|
|
$builder->dropSymbolCache();
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($args->getArg('show')) {
|
|
|
|
$library_map = $builder->buildMap();
|
|
|
|
|
|
|
|
if ($args->getArg('ugly')) {
|
|
|
|
echo json_encode($library_map);
|
|
|
|
} else {
|
|
|
|
echo id(new PhutilJSON())->encodeFormatted($library_map);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
$builder->buildAndWriteMap();
|
|
|
|
}
|
|
|
|
|
|
|
|
exit(0);
|