phorge-arcanist/src/lint/linter/__tests__/ArcanistPhpcsLinterTestCase.php

<?php

final class ArcanistPhpcsLinterTestCase extends ArcanistExternalLinterTestCase {

  public function testLinter() {
    $this->executeTestsInDirectory(dirname(__FILE__).'/phpcs/');
  }

}
Support PHPCS as a `.arclint` linter Summary: Ref T3186. Ref T2039. Ref T3771. A few effects here: # Expose PHPCS as a `.arclint` linter. # Turn PHPCS into an ArcanistExternalLinter linter. # Add test coverage for PHPCS. # Add a `severity.rules` option to `.arclint`. Some linters have very explicit builtin severities ("error", "warning") but their meanings are different from how arc interprets these terms. For example, PHPCS raises "wrong indentation level" as an "error". You can already use the "severity" map to adjust individual rules, but if you want to adjust an entire linter it's currently difficult. This rule map makes it easy. There's substantial precedent for this in other linters, notably all the Python linters. For `severity.rules`, for example, this will turn all PHPCS "errors" into warnings, and all of its warnings into advice: "severity.rules" : { "(^PHPCS\\.E\\.)" : "warning", "(^PHPCS\\.W\\.)" : "advice" } The user can use `severity` (or more rules) to get additional granularity adjustments if they desire. Test Plan: https://github.com/epriestley/arclint-examples/commit/5bb919bc3a684d6654dcc28622de9a29ec08307d Reviewers: btrahan Reviewed By: btrahan CC: aran, ajtrichards Maniphest Tasks: T2039, T3186, T3771 Differential Revision: https://secure.phabricator.com/D6830 2013-08-29 15:47:27 +02:00			`<?php`

Create an `ArcanistExternalLinterTestCase` class Summary: Creates a new base class for unit testing `ArcanistExternalLinter` subclasses. Specifically, add a test case for verifying that we are correctly parsing the output of `$external_linter --version`. Test Plan: `arc unit` Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11197 2015-01-04 20:41:59 +01:00			`final class ArcanistPhpcsLinterTestCase extends ArcanistExternalLinterTestCase {`
Support PHPCS as a `.arclint` linter Summary: Ref T3186. Ref T2039. Ref T3771. A few effects here: # Expose PHPCS as a `.arclint` linter. # Turn PHPCS into an ArcanistExternalLinter linter. # Add test coverage for PHPCS. # Add a `severity.rules` option to `.arclint`. Some linters have very explicit builtin severities ("error", "warning") but their meanings are different from how arc interprets these terms. For example, PHPCS raises "wrong indentation level" as an "error". You can already use the "severity" map to adjust individual rules, but if you want to adjust an entire linter it's currently difficult. This rule map makes it easy. There's substantial precedent for this in other linters, notably all the Python linters. For `severity.rules`, for example, this will turn all PHPCS "errors" into warnings, and all of its warnings into advice: "severity.rules" : { "(^PHPCS\\.E\\.)" : "warning", "(^PHPCS\\.W\\.)" : "advice" } The user can use `severity` (or more rules) to get additional granularity adjustments if they desire. Test Plan: https://github.com/epriestley/arclint-examples/commit/5bb919bc3a684d6654dcc28622de9a29ec08307d Reviewers: btrahan Reviewed By: btrahan CC: aran, ajtrichards Maniphest Tasks: T2039, T3186, T3771 Differential Revision: https://secure.phabricator.com/D6830 2013-08-29 15:47:27 +02:00
Create an `ArcanistExternalLinterTestCase` class Summary: Creates a new base class for unit testing `ArcanistExternalLinter` subclasses. Specifically, add a test case for verifying that we are correctly parsing the output of `$external_linter --version`. Test Plan: `arc unit` Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11197 2015-01-04 20:41:59 +01:00			`public function testLinter() {`
Reduce boilerplate code in `ArcanistLinterTestCase` subclasses Summary: This is a bit magical and is maybe a terrible idea, but it seems okayish. Test Plan: `arc unit` Reviewers: chad, #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11172 2015-01-04 08:38:32 +01:00			`$this->executeTestsInDirectory(dirname(__FILE__).'/phpcs/');`
Support PHPCS as a `.arclint` linter Summary: Ref T3186. Ref T2039. Ref T3771. A few effects here: # Expose PHPCS as a `.arclint` linter. # Turn PHPCS into an ArcanistExternalLinter linter. # Add test coverage for PHPCS. # Add a `severity.rules` option to `.arclint`. Some linters have very explicit builtin severities ("error", "warning") but their meanings are different from how arc interprets these terms. For example, PHPCS raises "wrong indentation level" as an "error". You can already use the "severity" map to adjust individual rules, but if you want to adjust an entire linter it's currently difficult. This rule map makes it easy. There's substantial precedent for this in other linters, notably all the Python linters. For `severity.rules`, for example, this will turn all PHPCS "errors" into warnings, and all of its warnings into advice: "severity.rules" : { "(^PHPCS\\.E\\.)" : "warning", "(^PHPCS\\.W\\.)" : "advice" } The user can use `severity` (or more rules) to get additional granularity adjustments if they desire. Test Plan: https://github.com/epriestley/arclint-examples/commit/5bb919bc3a684d6654dcc28622de9a29ec08307d Reviewers: btrahan Reviewed By: btrahan CC: aran, ajtrichards Maniphest Tasks: T2039, T3186, T3771 Differential Revision: https://secure.phabricator.com/D6830 2013-08-29 15:47:27 +02:00			`}`

			`}`