revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 23:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src/__phutil_library_map__.php

305 lines
20 KiB
PHP
Raw Normal View History

Initial commit.
2011-01-10 00:22:25 +01:00
<?php
/**
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
* This file is automatically generated. Use 'arc liberate' to rebuild it.
Initial commit.
2011-01-10 00:22:25 +01:00
* @generated
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
* @phutil-library-version 2
Initial commit.
2011-01-10 00:22:25 +01:00
*/
phutil_register_library_map(array(
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'__library_version__' => 2,
Initial commit.
2011-01-10 00:22:25 +01:00
'class' =>
array(
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistAliasWorkflow' => 'workflow/ArcanistAliasWorkflow.php',
'ArcanistAmendWorkflow' => 'workflow/ArcanistAmendWorkflow.php',
Create a mysterious new workflow Summary: Phabricator, as we all know, is marketed as a fun adventure game. However, while it is occasionally fun and often an adventure, it's so far been sorely deficient in the game aspect. This patch aims to rectify that oversight. (Presence of the first two qualities is not guaranteed.) Note: In case there's any doubt, this is not a serious suggestion. I was bored. Test Plan: Seriously? Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3026
2012-07-21 11:09:21 +02:00
'ArcanistAnoidWorkflow' => 'workflow/ArcanistAnoidWorkflow.php',
Temporarily restore apache/license linters Summary: Restores linters only, without unit tests or entry in ComprehensiveLinter. Marks them deprecated. If use at Facebook isn't widespread I'd prefer to simply delete them. Test Plan: none Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2274 Differential Revision: https://secure.phabricator.com/D4906
2013-02-11 23:12:10 +01:00
'ArcanistApacheLicenseLinter' => 'lint/linter/ArcanistApacheLicenseLinter.php',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistArcanistLinterTestCase' => 'lint/linter/__tests__/ArcanistArcanistLinterTestCase.php',
Adding arc revert command[] Summary: Arc Revert does the following: 1. Git revert 2. Go to the differential of the rev you are reverting and either repoen it or set it to a reverted state 3. File a hipri task to orig author [Preview] Creating Arc Revert workflow Porting arc revert from FB4A to phabricator for general usage. This is my first stab, so totally appreciate feedback and assistance. I'm currently focused on making this work for git. However, I built out the functions through the GitAPI so this could be easily extendable to Mercurial later on. Stuck on the following (help): 1. Creating a task for FB internal. I tried building on top of existing arc listeners but getting errors on failures to load the TaskCreator (and other) tasks. 2. I'm using a hacky way to grab the diff revision id from the newly created revert diff. (see line 204) I'm looking for a way to just fetch the diff ID from arc after the diff is created; is this possible? Test Plan: - 1. Ran arc revert on a www and fbcode diff 2. Confirmed that revert was run on the diffs and a proper diff filed - Reviewers: royw, sdwilsh, nh, epriestley Reviewed By: epriestley CC: aran, epriestley, Korvin, pti, keir Maniphest Tasks: T1751 Differential Revision: https://secure.phabricator.com/D5553
2013-05-14 20:00:56 +02:00
'ArcanistBackoutWorkflow' => 'workflow/ArcanistBackoutWorkflow.php',
Add a DSL for selecting base commits Summary: New optional mode. If you set 'base' in local, project or global config or pass '--base' to 'arc diff' or 'arc which', it switches to DSL mode. In DSL mode, lists of rules from args, local, project and global config are resolved, in that order. Rules can manipulate the rule machine or resolve into actual commits. Provides support for some 'arc' rules (mostly machine manipulation) and 'git' rules (symbolic ref and merge-base). Test Plan: Ran unit tests. Also: ```$ arc which --show-base --base 'arc:prompt' Against which commit? HEAD HEAD $ arc which --show-base --base 'git:HEAD' HEAD $ arc which --show-base --base 'git:fake' Usage Exception: None of the rules in your 'base' configuration matched a valid commit. Adjust rules or specify which commit you want to use explicitly. $ arc which --show-base --base 'git:origin/master' origin/master $ arc which --show-base --base 'git:upstream' Usage Exception: None of the rules in your 'base' configuration matched a valid commit. Adjust rules or specify which commit you want to use explicitly. $ arc which --show-base --base 'literal:derp' derp $ arc which --show-base --base 'arc:halt' Usage Exception: None of the rules in your 'base' configuration matched a valid commit. Adjust rules or specify which commit you want to use explicitly. $ arc set-config --local base git:origin/master Set key 'base' = 'git:origin/master' in local config. $ arc which --show-base origin/master $ arc which --show-base --base 'git:HEAD^' HEAD^ $ arc which --show-base --base 'arc:yield, git:HEAD^' origin/master $ arc which --show-base --base 'arc:global, git:HEAD^' HEAD^ $ arc which --show-base --base 'arc:global, git:merge-base(origin/master)' 3f4f8992fba8d1f142974da36a82bae900e247c0``` Reviewers: dschleimer, vrana Reviewed By: dschleimer CC: aran Maniphest Tasks: T1233 Differential Revision: https://secure.phabricator.com/D2748
2012-06-15 23:01:28 +02:00
'ArcanistBaseCommitParser' => 'parser/ArcanistBaseCommitParser.php',
'ArcanistBaseCommitParserTestCase' => 'parser/__tests__/ArcanistBaseCommitParserTestCase.php',
Added base test result parser class. Implemented Go test result parser based on Go's built in test utility output. Test Plan: Ran PhpunitTestEngine unit test and used both test result parsers to generate test results. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D4676
2013-01-28 02:16:50 +01:00
'ArcanistBaseTestResultParser' => 'unit/engine/ArcanistBaseTestResultParser.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistBaseUnitTestEngine' => 'unit/engine/ArcanistBaseUnitTestEngine.php',
'ArcanistBaseWorkflow' => 'workflow/ArcanistBaseWorkflow.php',
Separate Phutil specific lint rules from XHPAST Summary: Also provides an example how to build custom linter using XHPAST. Test Plan: Added debug output to `willLintPaths()`, verified that each path is parsed only once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4718
2013-01-29 07:03:03 +01:00
'ArcanistBaseXHPASTLinter' => 'lint/linter/ArcanistBaseXHPASTLinter.php',
Support `arc bookmark` in Mercurial Summary: Branch in Mercurial means something else. Hopefully users wouldn't be too confused. Test Plan: $ arc help $ arc help branch $ arc help feature $ arc feature $ arc bookmark $ arc branch # In hg repo: $ arc feature $ arc feature new $ arc feature new Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2332 Differential Revision: https://secure.phabricator.com/D4753
2013-01-31 02:33:32 +01:00
'ArcanistBookmarkWorkflow' => 'workflow/ArcanistBookmarkWorkflow.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistBranchWorkflow' => 'workflow/ArcanistBranchWorkflow.php',
Fix filter/sort order of operations for british spellings Summary: Currently, if we match "alnd" to "land" and "amend" equally (distance 2), we drop "land" with the other part of the rule. Stop doing that. Test Plan: Unit tests. Also: ``` $ arc alnd Usage Exception: Unknown command 'alnd'. Try 'arc help'. Did you mean: amend land ``` Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D5033
2013-02-21 19:15:20 +01:00
'ArcanistBritishTestCase' => 'configuration/__tests__/ArcanistBritishTestCase.php',
Add arc browse workflow Summary: arc browse will open a browser to the Diffusion view of a file. Convenient if you like Diffusion for reading source. Naturally, it fixes relative filenames. Combined with git-grep it can be an easy replacement for server-side search functions. Test Plan: use feature with and without 'browser' configured. I've only tested this on Linux, because that's all I have right now, but the principle is sound. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4127
2012-12-09 23:09:35 +01:00
'ArcanistBrowseWorkflow' => 'workflow/ArcanistBrowseWorkflow.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistBundle' => 'parser/ArcanistBundle.php',
'ArcanistBundleTestCase' => 'parser/__tests__/ArcanistBundleTestCase.php',
'ArcanistCallConduitWorkflow' => 'workflow/ArcanistCallConduitWorkflow.php',
'ArcanistCapabilityNotSupportedException' => 'workflow/exception/ArcanistCapabilityNotSupportedException.php',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistChooseInvalidRevisionException' => 'exception/ArcanistChooseInvalidRevisionException.php',
'ArcanistChooseNoRevisionsException' => 'exception/ArcanistChooseNoRevisionsException.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistCloseRevisionWorkflow' => 'workflow/ArcanistCloseRevisionWorkflow.php',
'ArcanistCloseWorkflow' => 'workflow/ArcanistCloseWorkflow.php',
'ArcanistCommentRemover' => 'parser/ArcanistCommentRemover.php',
'ArcanistCommentRemoverTestCase' => 'parser/__tests__/ArcanistCommentRemoverTestCase.php',
'ArcanistCommitWorkflow' => 'workflow/ArcanistCommitWorkflow.php',
'ArcanistConduitLinter' => 'lint/linter/ArcanistConduitLinter.php',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistConfiguration' => 'configuration/ArcanistConfiguration.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistCoverWorkflow' => 'workflow/ArcanistCoverWorkflow.php',
CppCheck linter Summary: Lints cpp code using the cppcheck static linter. This linter needs to be downloaded and built from http://cppcheck.sourceforge.net/ Test Plan: Used it on a few files. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4353
2013-01-07 17:16:45 +01:00
'ArcanistCppcheckLinter' => 'lint/linter/ArcanistCppcheckLinter.php',
Add cpplint.py engine Summary: Adds arc lint support for cpp files with Google's cpplint.py lint checking. Test Plan: ran it on some cpp files. Added unit tests Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4344
2013-01-05 03:59:38 +01:00
'ArcanistCpplintLinter' => 'lint/linter/ArcanistCpplintLinter.php',
'ArcanistCpplintLinterTestCase' => 'lint/linter/__tests__/ArcanistCpplintLinterTestCase.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistDiffChange' => 'parser/diff/ArcanistDiffChange.php',
'ArcanistDiffChangeType' => 'parser/diff/ArcanistDiffChangeType.php',
'ArcanistDiffHunk' => 'parser/diff/ArcanistDiffHunk.php',
'ArcanistDiffParser' => 'parser/ArcanistDiffParser.php',
'ArcanistDiffParserTestCase' => 'parser/__tests__/ArcanistDiffParserTestCase.php',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistDiffUtils' => 'difference/ArcanistDiffUtils.php',
'ArcanistDiffUtilsTestCase' => 'difference/__tests__/ArcanistDiffUtilsTestCase.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistDiffWorkflow' => 'workflow/ArcanistDiffWorkflow.php',
'ArcanistDifferentialCommitMessage' => 'differential/ArcanistDifferentialCommitMessage.php',
'ArcanistDifferentialCommitMessageParserException' => 'differential/ArcanistDifferentialCommitMessageParserException.php',
'ArcanistDifferentialRevisionHash' => 'differential/constants/ArcanistDifferentialRevisionHash.php',
'ArcanistDifferentialRevisionStatus' => 'differential/constants/ArcanistDifferentialRevisionStatus.php',
'ArcanistDownloadWorkflow' => 'workflow/ArcanistDownloadWorkflow.php',
'ArcanistEventType' => 'events/constant/ArcanistEventType.php',
'ArcanistExportWorkflow' => 'workflow/ArcanistExportWorkflow.php',
Support `arc bookmark` in Mercurial Summary: Branch in Mercurial means something else. Hopefully users wouldn't be too confused. Test Plan: $ arc help $ arc help branch $ arc help feature $ arc feature $ arc bookmark $ arc branch # In hg repo: $ arc feature $ arc feature new $ arc feature new Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2332 Differential Revision: https://secure.phabricator.com/D4753
2013-01-31 02:33:32 +01:00
'ArcanistFeatureWorkflow' => 'workflow/ArcanistFeatureWorkflow.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistFilenameLinter' => 'lint/linter/ArcanistFilenameLinter.php',
Add an arc flag workflow Summary: Allow querying and modifying flags from arcanist. Currently supports only printing and deleting flags for Differential revisions, but it should be straightforward to add more capabilities (given Conduit support). Test Plan: Run arc flag, passing it various revisions. Flags are modified appropriately. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1556 Differential Revision: https://secure.phabricator.com/D3133
2012-08-03 21:00:54 +02:00
'ArcanistFlagWorkflow' => 'workflow/ArcanistFlagWorkflow.php',
Add a flake8 linter Summary: flake8 is the better maintained combination of pep8 and pyflakes Test Plan: There's a test! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, jack Differential Revision: https://secure.phabricator.com/D4082
2012-12-22 00:27:52 +01:00
'ArcanistFlake8Linter' => 'lint/linter/ArcanistFlake8Linter.php',
'ArcanistFlake8LinterTestCase' => 'lint/linter/__tests__/ArcanistFlake8LinterTestCase.php',
Run PEP8 linter on background Test Plan: $ arc lint pep8.py --cache 0 --engine ComprehensiveLintEngine --trace Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4967
2013-02-15 01:16:08 +01:00
'ArcanistFutureLinter' => 'lint/linter/ArcanistFutureLinter.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistGeneratedLinter' => 'lint/linter/ArcanistGeneratedLinter.php',
'ArcanistGetConfigWorkflow' => 'workflow/ArcanistGetConfigWorkflow.php',
'ArcanistGitAPI' => 'repository/api/ArcanistGitAPI.php',
'ArcanistGitHookPreReceiveWorkflow' => 'workflow/ArcanistGitHookPreReceiveWorkflow.php',
'ArcanistHelpWorkflow' => 'workflow/ArcanistHelpWorkflow.php',
Rough cut of hgdaemon Summary: This need a bunch of work, but is a sort of minimum viable product for the hgdaemon. The two ProtocolChannels implement the client and server halves of the protocol. The Server implements the server logic, the Client implements the client logic. Test Plan: Launched a server and client on the same repo, got hg output in ~2-3ms instead of 100ms+. Reviewers: csilvers, btrahan, vrana Reviewed By: csilvers CC: aran Differential Revision: https://secure.phabricator.com/D2665
2012-06-08 03:23:57 +02:00
'ArcanistHgClientChannel' => 'hgdaemon/ArcanistHgClientChannel.php',
'ArcanistHgProxyClient' => 'hgdaemon/ArcanistHgProxyClient.php',
'ArcanistHgProxyServer' => 'hgdaemon/ArcanistHgProxyServer.php',
'ArcanistHgServerChannel' => 'hgdaemon/ArcanistHgServerChannel.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistHookAPI' => 'repository/hookapi/ArcanistHookAPI.php',
Introduce `arc inlines` Summary: This displays all inline comments attached to a revision in a format consumable by editors. Test Plan: Ran it, opened the file on the line. Reviewers: epriestley Reviewed By: epriestley CC: vii, aran, Korvin Differential Revision: https://secure.phabricator.com/D2845
2012-06-23 08:08:25 +02:00
'ArcanistInlinesWorkflow' => 'workflow/ArcanistInlinesWorkflow.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistInstallCertificateWorkflow' => 'workflow/ArcanistInstallCertificateWorkflow.php',
'ArcanistJSHintLinter' => 'lint/linter/ArcanistJSHintLinter.php',
'ArcanistLandWorkflow' => 'workflow/ArcanistLandWorkflow.php',
'ArcanistLiberateWorkflow' => 'workflow/ArcanistLiberateWorkflow.php',
Temporarily restore apache/license linters Summary: Restores linters only, without unit tests or entry in ComprehensiveLinter. Marks them deprecated. If use at Facebook isn't widespread I'd prefer to simply delete them. Test Plan: none Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2274 Differential Revision: https://secure.phabricator.com/D4906
2013-02-11 23:12:10 +01:00
'ArcanistLicenseLinter' => 'lint/linter/ArcanistLicenseLinter.php',
Define interface for lint renderers Summary: It makes me nervous. Also move them to the dir. Test Plan: `arc lint` `arc lint --output json` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2644
2012-06-02 02:32:35 +02:00
'ArcanistLintConsoleRenderer' => 'lint/renderer/ArcanistLintConsoleRenderer.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistLintEngine' => 'lint/engine/ArcanistLintEngine.php',
Define interface for lint renderers Summary: It makes me nervous. Also move them to the dir. Test Plan: `arc lint` `arc lint --output json` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2644
2012-06-02 02:32:35 +02:00
'ArcanistLintJSONRenderer' => 'lint/renderer/ArcanistLintJSONRenderer.php',
'ArcanistLintLikeCompilerRenderer' => 'lint/renderer/ArcanistLintLikeCompilerRenderer.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistLintMessage' => 'lint/ArcanistLintMessage.php',
Support `arc lint --output none` Summary: I want to run lint on background and I'm interested only in side effect of caching (and maybe exit status). This is better than discarding stdout later because we don't do unnecessary work and error conditions are still printed. Test Plan: $ arc lint --output none # with error $ echo $? $ arc lint --output none # with no lintable paths $ arc lint --output none # witout errors Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5106
2013-02-25 21:33:51 +01:00
'ArcanistLintNoneRenderer' => 'lint/renderer/ArcanistLintNoneRenderer.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistLintPatcher' => 'lint/ArcanistLintPatcher.php',
Define interface for lint renderers Summary: It makes me nervous. Also move them to the dir. Test Plan: `arc lint` `arc lint --output json` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2644
2012-06-02 02:32:35 +02:00
'ArcanistLintRenderer' => 'lint/renderer/ArcanistLintRenderer.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistLintResult' => 'lint/ArcanistLintResult.php',
'ArcanistLintSeverity' => 'lint/ArcanistLintSeverity.php',
Define interface for lint renderers Summary: It makes me nervous. Also move them to the dir. Test Plan: `arc lint` `arc lint --output json` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2644
2012-06-02 02:32:35 +02:00
'ArcanistLintSummaryRenderer' => 'lint/renderer/ArcanistLintSummaryRenderer.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistLintWorkflow' => 'workflow/ArcanistLintWorkflow.php',
'ArcanistLinter' => 'lint/linter/ArcanistLinter.php',
'ArcanistLinterTestCase' => 'lint/linter/__tests__/ArcanistLinterTestCase.php',
'ArcanistListWorkflow' => 'workflow/ArcanistListWorkflow.php',
'ArcanistMarkCommittedWorkflow' => 'workflow/ArcanistMarkCommittedWorkflow.php',
'ArcanistMercurialAPI' => 'repository/api/ArcanistMercurialAPI.php',
'ArcanistMercurialParser' => 'repository/parser/ArcanistMercurialParser.php',
'ArcanistMercurialParserTestCase' => 'repository/parser/__tests__/ArcanistMercurialParserTestCase.php',
Add linting for syntax brought in by unresolved merge conflicts. Summary: Add linting capability for detecting files which contain syntax introduced by unresolved merge conflicts. The detection is file-type-agnostic (the only requirement is that the file is a text file). Test Plan: Tested in three ways. The first way is to add all three forms of syntax to a file to indicate a merge conflict. HPHP will pick this up as a syntax error before this linter reaches it. The second way is to add the syntax in a comment. In that case, this linter will show three warnings. For example: $ arc lint ArcanistMergeConflictLinter.php >>> Lint for arcanist/src/lint/linter/ArcanistMergeConflictLinter.php: Warning (MERGECONFLICT1) Unresolved merge conflict This syntax indicates there is still an unresolved merge conflict. 20 21 foreach ($lines as $lineno => $line) { 22 /* >>> 23 >>>>>>> 24 25 ======= Warning (MERGECONFLICT1) Unresolved merge conflict This syntax indicates there is still an unresolved merge conflict. 22 /* 23 >>>>>>> 24 >>> 25 ======= 26 27 <<<<<<< Warning (MERGECONFLICT1) Unresolved merge conflict This syntax indicates there is still an unresolved merge conflict. 24 25 ======= 26 >>> 27 <<<<<<< 28 29 */ The last test was to test on various different file types, including JavaScript, PHP, an animated GIF, a PNG, and a Bash file to make sure the file type detection worked. Each of the aforementioned tests passed. Reviewers: vrana, epriestley Reviewed By: epriestley CC: aran, epriestley, Korvin Maniphest Tasks: T2547 Differential Revision: https://secure.phabricator.com/D4966
2013-02-20 23:19:55 +01:00
'ArcanistMergeConflictLinter' => 'lint/linter/ArcanistMergeConflictLinter.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistNoEffectException' => 'exception/usage/ArcanistNoEffectException.php',
'ArcanistNoEngineException' => 'exception/usage/ArcanistNoEngineException.php',
'ArcanistNoLintLinter' => 'lint/linter/ArcanistNoLintLinter.php',
'ArcanistNoLintTestCaseMisnamed' => 'lint/linter/__tests__/ArcanistNoLintTestCase.php',
'ArcanistPEP8Linter' => 'lint/linter/ArcanistPEP8Linter.php',
'ArcanistPasteWorkflow' => 'workflow/ArcanistPasteWorkflow.php',
'ArcanistPatchWorkflow' => 'workflow/ArcanistPatchWorkflow.php',
'ArcanistPhpcsLinter' => 'lint/linter/ArcanistPhpcsLinter.php',
'ArcanistPhutilLibraryLinter' => 'lint/linter/ArcanistPhutilLibraryLinter.php',
'ArcanistPhutilTestCase' => 'unit/engine/phutil/ArcanistPhutilTestCase.php',
Pass for phutil test that was expected to fail and skip Summary: I just hope that we will not create `ArcanistPhutilTestCaseTestCaseTestCase`. Also fix a copy/paste error (@edward's this time). Test Plan: `arc unit` Reviewers: epriestley Reviewed By: epriestley CC: edward, aran, Korvin Differential Revision: https://secure.phabricator.com/D2692
2012-06-08 23:22:23 +02:00
'ArcanistPhutilTestCaseTestCase' => 'unit/engine/phutil/testcase/ArcanistPhutilTestCaseTestCase.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistPhutilTestSkippedException' => 'unit/engine/phutil/testcase/ArcanistPhutilTestSkippedException.php',
'ArcanistPhutilTestTerminatedException' => 'unit/engine/phutil/testcase/ArcanistPhutilTestTerminatedException.php',
Separate Phutil specific lint rules from XHPAST Summary: Also provides an example how to build custom linter using XHPAST. Test Plan: Added debug output to `willLintPaths()`, verified that each path is parsed only once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4718
2013-01-29 07:03:03 +01:00
'ArcanistPhutilXHPASTLinter' => 'lint/linter/ArcanistPhutilXHPASTLinter.php',
'ArcanistPhutilXHPASTLinterTestCase' => 'lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistPyFlakesLinter' => 'lint/linter/ArcanistPyFlakesLinter.php',
'ArcanistPyLintLinter' => 'lint/linter/ArcanistPyLintLinter.php',
'ArcanistRepositoryAPI' => 'repository/api/ArcanistRepositoryAPI.php',
Fix an escaping issue with "svn commit" Summary: Fixes T2438. We currently escape everything with '@', but SVN rejects that for '.' Test Plan: Unit tests. Performed this commit: $ svn st M . A x@123 $ arc commit --conduit-uri=http://local.aphront.com:8080/ --revision 53 Revision 'D53: asdf' has not been accepted. Commit this revision anyway? [y/N] y Committing 'D53: asdf'... Sending . Adding x@123 Transmitting file data . Committed revision 37. Done. I grepped for more '@' adding but couldn't find any. It's a bit tricky to grep for though, so it's possible I missed some. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran, mbishopim3 Maniphest Tasks: T2438 Differential Revision: https://secure.phabricator.com/D4703
2013-01-28 23:11:31 +01:00
'ArcanistRepositoryAPIMiscTestCase' => 'repository/api/__tests__/ArcanistRepositoryAPIMiscTestCase.php',
Refactor getWorkingCopyStatus() into getUncommittedStatus() and getCommitRangeStatus() Summary: See discussion in D4049. The getWorkingCopyStatus() method gets called from requireCleanWorkingCopy() in a lot of places, which triggers resolution of the base of the commit range. This is unnecessary; we do not need to examine the base commit in order to determine whether the working copy is dirty or not. This causes problems, in D4049 and elsewhere (we currently have a lot of fluff calls to setDefaultBaseCommit() in workflows which need to call requireCleanWorkingCopy() but do not ever use commit ranges, such as `arc patch`). This is mostly an artifact of SVN, where the "commit range" and "uncommitted stuff in the working copy" are always the same. - Split the method into two status methods: getUncommittedStatus() (uncommitted stuff in the working copy, required by requireCleanWorkingCopy()) and getCommitRangeStatus() (committed stuff in the commit range). - Lift caching out of the implementations into the base class. - Dirty the cache after we commit. This doesn't do anything useful on its own and creates one caching problem (`commitRangeStatusCache` is not invalidated when the commit range changes because of `setBaseCommit()` or similar) but I wanted to break things apart here. I won't land it until there's a more complete picture. This creates a minor performance regression in git and hg (we run less stuff in parallel than previously) but all the commands should be disk-bound anyway and the regression should be minor. It prevents a larger regression in `hg` in D4049, and lets us do less work to arrive at common error states (dirty working copy). We can examine perf at the end of this change sequence. Test Plan: Ran unit tests, various `arc` commands. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4095
2012-12-17 21:53:28 +01:00
'ArcanistRepositoryAPIStateTestCase' => 'repository/api/__tests__/ArcanistRepositoryAPIStateTestCase.php',
Adding arc revert command[] Summary: Arc Revert does the following: 1. Git revert 2. Go to the differential of the rev you are reverting and either repoen it or set it to a reverted state 3. File a hipri task to orig author [Preview] Creating Arc Revert workflow Porting arc revert from FB4A to phabricator for general usage. This is my first stab, so totally appreciate feedback and assistance. I'm currently focused on making this work for git. However, I built out the functions through the GitAPI so this could be easily extendable to Mercurial later on. Stuck on the following (help): 1. Creating a task for FB internal. I tried building on top of existing arc listeners but getting errors on failures to load the TaskCreator (and other) tasks. 2. I'm using a hacky way to grab the diff revision id from the newly created revert diff. (see line 204) I'm looking for a way to just fetch the diff ID from arc after the diff is created; is this possible? Test Plan: - 1. Ran arc revert on a www and fbcode diff 2. Confirmed that revert was run on the diffs and a proper diff filed - Reviewers: royw, sdwilsh, nh, epriestley Reviewed By: epriestley CC: aran, epriestley, Korvin, pti, keir Maniphest Tasks: T1751 Differential Revision: https://secure.phabricator.com/D5553
2013-05-14 20:00:56 +02:00
'ArcanistRevertWorkflow' => 'workflow/ArcanistRevertWorkflow.php',
Make `ruby -wc` a linter in Arcanist Summary: Add `ruby -wc` as a linter and raise Error whenever there's a syntax error Test Plan: Just a few dumb unit tests. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3447
2012-09-06 20:50:15 +02:00
'ArcanistRubyLinter' => 'lint/linter/ArcanistRubyLinter.php',
'ArcanistRubyLinterTestCase' => 'lint/linter/__tests__/ArcanistRubyLinterTestCase.php',
Add a very basic Scala (SBT) linter. Summary: SBT is the most common Scala buildsystem. This adds an extremely basic and slightly horrible linter to check SBT's output for warnings and errors. Test Plan: Tested this with a Scala project I've been working on for some time. It seemed relatively sane. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4064
2012-12-03 17:13:45 +01:00
'ArcanistScalaSBTLinter' => 'lint/linter/ArcanistScalaSBTLinter.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistScriptAndRegexLinter' => 'lint/linter/ArcanistScriptAndRegexLinter.php',
'ArcanistSetConfigWorkflow' => 'workflow/ArcanistSetConfigWorkflow.php',
Enrich arc configuration and add stronger typing Summary: See <https://github.com/facebook/arcanist/issues/45> Currently, when the user types `arc set-config x false`, we set it as the string "false", which is usually not desirable. We have some steps toward typed config already, but expand on what we have and move as much stuff as possible into it, including all the config settings that aren't currently documented (there are still some lint-specific and project-specific settings not present here, but this is most of it). Also make the `phutil_libraries` key a legacy name for `load`, and `immutable_history` a legacy name for `history.immutable`. Generally the goal here is to make config simpler and bring it more in-line with Git/Mercurial, which use dotted hierarchies. I'll add some documentation here but I think most of the changes should be fairly straightforward. Test Plan: - `arc set-config history.immutable on` (And similar -- sets to boolean true.) - `arc set-config history.immutable off` (And similar -- sets to boolean false.) - `arc set-config history.immutable derp` (And similar -- raises exception.) - `arc set-config history.immutable ''` (And similar -- removes setting value.) - `arc set-config --show` - `arc get-config` - `arc get-config base` Reviewers: dschleimer, bos, btrahan, vrana Reviewed By: dschleimer CC: aran Maniphest Tasks: T1546 Differential Revision: https://secure.phabricator.com/D3045
2012-07-26 03:37:09 +02:00
'ArcanistSettings' => 'configuration/ArcanistSettings.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistShellCompleteWorkflow' => 'workflow/ArcanistShellCompleteWorkflow.php',
'ArcanistSingleLintEngine' => 'lint/engine/ArcanistSingleLintEngine.php',
Use punctuation in spelling linter Summary: Also move dependency one directory down. Test Plan: $ arc lint # on file with "teh" Reviewers: jack, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3436
2012-09-05 08:45:54 +02:00
'ArcanistSpellingDefaultData' => 'lint/linter/spelling/ArcanistSpellingDefaultData.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistSpellingLinter' => 'lint/linter/ArcanistSpellingLinter.php',
'ArcanistSpellingLinterTestCase' => 'lint/linter/__tests__/ArcanistSpellingLinterTestCase.php',
'ArcanistSubversionAPI' => 'repository/api/ArcanistSubversionAPI.php',
'ArcanistSubversionHookAPI' => 'repository/hookapi/ArcanistSubversionHookAPI.php',
'ArcanistSvnHookPreCommitWorkflow' => 'workflow/ArcanistSvnHookPreCommitWorkflow.php',
'ArcanistTasksWorkflow' => 'workflow/ArcanistTasksWorkflow.php',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistTestCase' => 'infrastructure/testing/ArcanistTestCase.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistTextLinter' => 'lint/linter/ArcanistTextLinter.php',
'ArcanistTextLinterTestCase' => 'lint/linter/__tests__/ArcanistTextLinterTestCase.php',
Create an arc todo workflow for quickly creating a task. Summary: Run `arc todo o rly?` to create a Maniphest task titled 'o rly?'. Pass --cc to add CCs besides yourself. Test Plan: Ran `arc todo o rly?`. Behaved as expected. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T749, T1325 Differential Revision: https://secure.phabricator.com/D2952
2012-07-11 02:32:36 +02:00
'ArcanistTodoWorkflow' => 'workflow/ArcanistTodoWorkflow.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistUncommittedChangesException' => 'exception/usage/ArcanistUncommittedChangesException.php',
Render unit results progressively Summary: Some tests take longer (fixtures usually around 1 second for me) and also FB runs all tests on deploy. I want to see all results immediately. Test Plan: Added `usleep(200000)` to `resultTest()`, then: $ arc unit Saw results printed one by one. Also didn't pass `$renderer` to `ArcanistPhutilTestCase` and saw empty output. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5141
2013-02-27 22:59:12 +01:00
'ArcanistUnitConsoleRenderer' => 'unit/renderer/ArcanistUnitConsoleRenderer.php',
'ArcanistUnitRenderer' => 'unit/renderer/ArcanistUnitRenderer.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistUnitTestResult' => 'unit/ArcanistUnitTestResult.php',
'ArcanistUnitWorkflow' => 'workflow/ArcanistUnitWorkflow.php',
'ArcanistUpgradeWorkflow' => 'workflow/ArcanistUpgradeWorkflow.php',
'ArcanistUploadWorkflow' => 'workflow/ArcanistUploadWorkflow.php',
'ArcanistUsageException' => 'exception/ArcanistUsageException.php',
'ArcanistUserAbortException' => 'exception/usage/ArcanistUserAbortException.php',
'ArcanistWhichWorkflow' => 'workflow/ArcanistWhichWorkflow.php',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistWorkingCopyIdentity' => 'workingcopyidentity/ArcanistWorkingCopyIdentity.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistXHPASTLintNamingHook' => 'lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php',
'ArcanistXHPASTLintNamingHookTestCase' => 'lint/linter/xhpast/__tests__/ArcanistXHPASTLintNamingHookTestCase.php',
Implement hook for checking switch lint Summary: We want to use it for `yield` and `invariant_violation()` which throws. Having node instead of token would be better but this would be enough. Test Plan: Implemented a hook in FB repo and added a test case there. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4821
2013-02-05 20:00:07 +01:00
'ArcanistXHPASTLintSwitchHook' => 'lint/linter/xhpast/ArcanistXHPASTLintSwitchHook.php',
Add unit tests for implicit fallthrough lint rule Summary: The perf fix actually catches some real problems. I didn't find anything in libphutil, Arcanist and Phabricator though. Also bump version. Also allow configuring the hook. Test Plan: Added a test, saw it fail with the old code. Repeat for hook. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5097
2013-02-23 06:12:29 +01:00
'ArcanistXHPASTLintTestSwitchHook' => 'lint/linter/__tests__/ArcanistXHPASTLintTestSwitchHook.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'ArcanistXHPASTLinter' => 'lint/linter/ArcanistXHPASTLinter.php',
'ArcanistXHPASTLinterTestCase' => 'lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php',
'ComprehensiveLintEngine' => 'lint/engine/ComprehensiveLintEngine.php',
'ExampleLintEngine' => 'lint/engine/ExampleLintEngine.php',
Added base test result parser class. Implemented Go test result parser based on Go's built in test utility output. Test Plan: Ran PhpunitTestEngine unit test and used both test result parsers to generate test results. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D4676
2013-01-28 02:16:50 +01:00
'GoTestResultParser' => 'unit/engine/GoTestResultParser.php',
'GoTestResultParserTestCase' => 'unit/engine/__tests__/GoTestResultParserTestCase.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'NoseTestEngine' => 'unit/engine/NoseTestEngine.php',
Search for more test locations in PHPUnitTestEngine Summary: See https://github.com/facebook/arcanist/pull/53 - Work correctly for directories with `%` in their name; this breaks under sprintf(). - Search for `src/` -> `tests/` style directories. - Add coverage for search paths. Test Plan: Ran unit tests. I don't have a working test case for PHPUnit tests, can one of you guys apply this and verify I didn't break your setups? Reviewers: quard, aurelijus Reviewed By: aurelijus CC: aran Differential Revision: https://secure.phabricator.com/D3558
2012-09-30 03:03:43 +02:00
'PHPUnitTestEngineTestCase' => 'unit/engine/__tests__/PHPUnitTestEngineTestCase.php',
Decoupling phpunit test parsing from running and gathering. Should enable third party test engines to reuse common business logic around phpunit without requiring common logic for the typically application-specific running and gathering. Test Plan: Ran PhpunitTestEngine unit test. Also used refactored PhpunitTestEngine to run phpunit tests. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D4651
2013-01-26 02:06:20 +01:00
'PhpunitResultParser' => 'unit/engine/PhpunitResultParser.php',
Move files in Arcanist one level up Summary: - `kill_init.php` - Manually change library map. - Manually rename `/data/` test dirs. - [src/lint/linter] `git mv base/ArcanistLinterTestCase.php __tests__/` - `arc liberate` Test Plan: Browse around to make sure I like it better, especially `repository/api`, and `workflow`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2637
2012-06-01 20:41:04 +02:00
'PhpunitTestEngine' => 'unit/engine/PhpunitTestEngine.php',
'PhutilLintEngine' => 'lint/engine/PhutilLintEngine.php',
'PhutilUnitTestEngine' => 'unit/engine/PhutilUnitTestEngine.php',
'PhutilUnitTestEngineTestCase' => 'unit/engine/__tests__/PhutilUnitTestEngineTestCase.php',
'UnitTestableArcanistLintEngine' => 'lint/engine/UnitTestableArcanistLintEngine.php',
Initial commit.
2011-01-10 00:22:25 +01:00
),
'function' =>
array(
),
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'xmap' =>
Initial commit.
2011-01-10 00:22:25 +01:00
array(
Add an "arc alias" command Summary: Allow users to easily define aliased arc commands. This is easier than making them muck around with shell stuff, and lets me do stuff like "arc alias adiff diff -- --auto" so I can test --auto more easily. There are some limitations here (for example, you can't put --trace in an alias because it gets parsed too early) but I think it's a reasonable starting point. Test Plan: Set, listed, removed and used aliases. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T896 Differential Revision: https://secure.phabricator.com/D1653
2012-02-21 22:16:52 +01:00
'ArcanistAliasWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistAmendWorkflow' => 'ArcanistBaseWorkflow',
Create a mysterious new workflow Summary: Phabricator, as we all know, is marketed as a fun adventure game. However, while it is occasionally fun and often an adventure, it's so far been sorely deficient in the game aspect. This patch aims to rectify that oversight. (Presence of the first two qualities is not guaranteed.) Note: In case there's any doubt, this is not a serious suggestion. I was bored. Test Plan: Seriously? Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3026
2012-07-21 11:09:21 +02:00
'ArcanistAnoidWorkflow' => 'ArcanistBaseWorkflow',
Temporarily restore apache/license linters Summary: Restores linters only, without unit tests or entry in ComprehensiveLinter. Marks them deprecated. If use at Facebook isn't widespread I'd prefer to simply delete them. Test Plan: none Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2274 Differential Revision: https://secure.phabricator.com/D4906
2013-02-11 23:12:10 +01:00
'ArcanistApacheLicenseLinter' => 'ArcanistLicenseLinter',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistArcanistLinterTestCase' => 'ArcanistLinterTestCase',
Adding arc revert command[] Summary: Arc Revert does the following: 1. Git revert 2. Go to the differential of the rev you are reverting and either repoen it or set it to a reverted state 3. File a hipri task to orig author [Preview] Creating Arc Revert workflow Porting arc revert from FB4A to phabricator for general usage. This is my first stab, so totally appreciate feedback and assistance. I'm currently focused on making this work for git. However, I built out the functions through the GitAPI so this could be easily extendable to Mercurial later on. Stuck on the following (help): 1. Creating a task for FB internal. I tried building on top of existing arc listeners but getting errors on failures to load the TaskCreator (and other) tasks. 2. I'm using a hacky way to grab the diff revision id from the newly created revert diff. (see line 204) I'm looking for a way to just fetch the diff ID from arc after the diff is created; is this possible? Test Plan: - 1. Ran arc revert on a www and fbcode diff 2. Confirmed that revert was run on the diffs and a proper diff filed - Reviewers: royw, sdwilsh, nh, epriestley Reviewed By: epriestley CC: aran, epriestley, Korvin, pti, keir Maniphest Tasks: T1751 Differential Revision: https://secure.phabricator.com/D5553
2013-05-14 20:00:56 +02:00
'ArcanistBackoutWorkflow' => 'ArcanistBaseWorkflow',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase',
Refuse writing to undeclared properties in workflows Summary: I don't know how to not be strict here plus we (Arcanist developers) don't have access to user's error log. Test Plan: Undeclared `ArcanistDiffWorkflow::$console`, then: $ arc diff Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3607
2012-10-03 23:34:02 +02:00
'ArcanistBaseWorkflow' => 'Phobject',
Remove hgsprintf() from arcanist Summary: Moving to libphutil. Test Plan: unit Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D5058
2013-02-22 01:44:19 +01:00
'ArcanistBaseXHPASTLinter' => 'ArcanistFutureLinter',
Support `arc bookmark` in Mercurial Summary: Branch in Mercurial means something else. Hopefully users wouldn't be too confused. Test Plan: $ arc help $ arc help branch $ arc help feature $ arc feature $ arc bookmark $ arc branch # In hg repo: $ arc feature $ arc feature new $ arc feature new Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2332 Differential Revision: https://secure.phabricator.com/D4753
2013-01-31 02:33:32 +01:00
'ArcanistBookmarkWorkflow' => 'ArcanistFeatureWorkflow',
'ArcanistBranchWorkflow' => 'ArcanistFeatureWorkflow',
Fix filter/sort order of operations for british spellings Summary: Currently, if we match "alnd" to "land" and "amend" equally (distance 2), we drop "land" with the other part of the rule. Stop doing that. Test Plan: Unit tests. Also: ``` $ arc alnd Usage Exception: Unknown command 'alnd'. Try 'arc help'. Did you mean: amend land ``` Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D5033
2013-02-21 19:15:20 +01:00
'ArcanistBritishTestCase' => 'ArcanistTestCase',
Add arc browse workflow Summary: arc browse will open a browser to the Diffusion view of a file. Convenient if you like Diffusion for reading source. Naturally, it fixes relative filenames. Combined with git-grep it can be an easy replacement for server-side search functions. Test Plan: use feature with and without 'browser' configured. I've only tested this on Linux, because that's all I have right now, but the principle is sound. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4127
2012-12-09 23:09:35 +01:00
'ArcanistBrowseWorkflow' => 'ArcanistBaseWorkflow',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistBundleTestCase' => 'ArcanistTestCase',
Provide 'arc call-conduit' to facilitate script integration with Phabricator Summary: Provide a formal mechanism for making conduit calls from other scripts. Test Plan: Called 'conduit.ping'. Reviewed By: jungejason Reviewers: aran, jungejason, tuomaspelkonen CC: aran, jungejason Differential Revision: 239
2011-05-06 17:43:38 +02:00
'ArcanistCallConduitWorkflow' => 'ArcanistBaseWorkflow',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistCapabilityNotSupportedException' => 'Exception',
'ArcanistChooseInvalidRevisionException' => 'Exception',
'ArcanistChooseNoRevisionsException' => 'Exception',
Rename "arc mark-committed" to "arc close-revision" Summary: - Replace SVN-specific language with VCS-agnostic language. - Add new "arc close-revision", works exactly like "arc mark-committed" but with agnostic language. - Use status constants, not status strings. - Mark "arc mark-committed" deprecated. - Remove deprecated "arc merge". Test Plan: Ran "arc mark-committed", "arc close-revision". Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran, Makinde Maniphest Tasks: T909 Differential Revision: https://secure.phabricator.com/D2244
2012-04-17 22:51:10 +02:00
'ArcanistCloseRevisionWorkflow' => 'ArcanistBaseWorkflow',
Add arc close command Summary: ```arc close T1088 --status wontfix --message "I'm not going to fix this."``` T1088 is the test task to screw with, so feel free. Test Plan: ```arc close T1088 --status [ resolved | wontfix | invalid | duplicate | spite | open ] -m "Message"``` Reviewers: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2162
2012-04-09 05:55:10 +02:00
'ArcanistCloseWorkflow' => 'ArcanistBaseWorkflow',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistCommentRemoverTestCase' => 'ArcanistTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistCommitWorkflow' => 'ArcanistBaseWorkflow',
Add ArcanistConduitLinter, a linter that delegates through Conduit Summary: Julien built a really cool static analysis database of our codebase. One capability is that it can suggest typehints that are not in the code. The analysis to do this is very expensive, so it can't reasonably be run locally. But it can remain indexed on a server. The idea here is to provide a familiar interface to it through arc lint, via a generic Conduit service call. In our lint engine, this will probably be gated on --advice for performance. This will introduce a slight awkwardness in that running with --advice can add new non-advice lint if the server chooses, but this isn't likely to cause a practical problem. Test Plan: Construct a fake Conduit lint endpoint, attach this linter to it, and see bogus lint appear with --advice. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1462
2012-01-20 02:09:27 +01:00
'ArcanistConduitLinter' => 'ArcanistLinter',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistCoverWorkflow' => 'ArcanistBaseWorkflow',
CppCheck linter Summary: Lints cpp code using the cppcheck static linter. This linter needs to be downloaded and built from http://cppcheck.sourceforge.net/ Test Plan: Used it on a few files. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4353
2013-01-07 17:16:45 +01:00
'ArcanistCppcheckLinter' => 'ArcanistLinter',
Add cpplint.py engine Summary: Adds arc lint support for cpp files with Google's cpplint.py lint checking. Test Plan: ran it on some cpp files. Added unit tests Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4344
2013-01-05 03:59:38 +01:00
'ArcanistCpplintLinter' => 'ArcanistLinter',
'ArcanistCpplintLinterTestCase' => 'ArcanistArcanistLinterTestCase',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistDiffParserTestCase' => 'ArcanistTestCase',
'ArcanistDiffUtilsTestCase' => 'ArcanistTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistDiffWorkflow' => 'ArcanistBaseWorkflow',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistDifferentialCommitMessageParserException' => 'Exception',
Add 'arc upload' and 'arc download' Summary: Mechanisms for interacting with Files via Arcanist. Test Plan: - Ran 'arc upload x', 'arc upload x y z' - Ran 'arc download' with --as and --show. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 742
2011-07-29 19:05:07 +02:00
'ArcanistDownloadWorkflow' => 'ArcanistBaseWorkflow',
Add events framework to Arcanist Test Plan: Added a test event listener, added an event dispatch in diff workflow, run the workflow, the listener was called. Reviewers: epriestley Reviewed By: epriestley CC: aran, jungejason, epriestley Differential Revision: 1102
2011-11-10 22:47:45 +01:00
'ArcanistEventType' => 'PhutilEventType',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistExportWorkflow' => 'ArcanistBaseWorkflow',
Support `arc bookmark` in Mercurial Summary: Branch in Mercurial means something else. Hopefully users wouldn't be too confused. Test Plan: $ arc help $ arc help branch $ arc help feature $ arc feature $ arc bookmark $ arc branch # In hg repo: $ arc feature $ arc feature new $ arc feature new Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2332 Differential Revision: https://secure.phabricator.com/D4753
2013-01-31 02:33:32 +01:00
'ArcanistFeatureWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistFilenameLinter' => 'ArcanistLinter',
Add an arc flag workflow Summary: Allow querying and modifying flags from arcanist. Currently supports only printing and deleting flags for Differential revisions, but it should be straightforward to add more capabilities (given Conduit support). Test Plan: Run arc flag, passing it various revisions. Flags are modified appropriately. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1556 Differential Revision: https://secure.phabricator.com/D3133
2012-08-03 21:00:54 +02:00
'ArcanistFlagWorkflow' => 'ArcanistBaseWorkflow',
Add a flake8 linter Summary: flake8 is the better maintained combination of pep8 and pyflakes Test Plan: There's a test! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, jack Differential Revision: https://secure.phabricator.com/D4082
2012-12-22 00:27:52 +01:00
'ArcanistFlake8Linter' => 'ArcanistLinter',
'ArcanistFlake8LinterTestCase' => 'ArcanistArcanistLinterTestCase',
Run PEP8 linter on background Test Plan: $ arc lint pep8.py --cache 0 --engine ComprehensiveLintEngine --trace Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4967
2013-02-15 01:16:08 +01:00
'ArcanistFutureLinter' => 'ArcanistLinter',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistGeneratedLinter' => 'ArcanistLinter',
Add "arc get-config" and "arc set-config" for managing ~/.arcrc values Summary: The major thing I want to do here is allow you to set a default Phabricator URI, so we can make "arc paste", and "arc upload", "arc download" work anywhere. We can also relax the .arcconfig requirements (request from @csilvers). Test Plan: Get/set some values? iiam Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2400
2012-05-07 15:07:23 +02:00
'ArcanistGetConfigWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistGitAPI' => 'ArcanistRepositoryAPI',
'ArcanistGitHookPreReceiveWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistHelpWorkflow' => 'ArcanistBaseWorkflow',
Rough cut of hgdaemon Summary: This need a bunch of work, but is a sort of minimum viable product for the hgdaemon. The two ProtocolChannels implement the client and server halves of the protocol. The Server implements the server logic, the Client implements the client logic. Test Plan: Launched a server and client on the same repo, got hg output in ~2-3ms instead of 100ms+. Reviewers: csilvers, btrahan, vrana Reviewed By: csilvers CC: aran Differential Revision: https://secure.phabricator.com/D2665
2012-06-08 03:23:57 +02:00
'ArcanistHgClientChannel' => 'PhutilProtocolChannel',
'ArcanistHgServerChannel' => 'PhutilProtocolChannel',
Introduce `arc inlines` Summary: This displays all inline comments attached to a revision in a format consumable by editors. Test Plan: Ran it, opened the file on the line. Reviewers: epriestley Reviewed By: epriestley CC: vii, aran, Korvin Differential Revision: https://secure.phabricator.com/D2845
2012-06-23 08:08:25 +02:00
'ArcanistInlinesWorkflow' => 'ArcanistBaseWorkflow',
"arc install-certificate", client side changes Summary: Provide an "install-certificate" workflow to simplify ~/.arcrc edits. See also D460. Test Plan: Installed certificates via "arc install-certificate". Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 465
2011-06-14 21:18:40 +02:00
'ArcanistInstallCertificateWorkflow' => 'ArcanistBaseWorkflow',
Adds ArcanistJSHintLinter to check JS files for errors and potential problems. This patch adds ArcanistJSHintLinter class and three new .arcconfig options: * lint.jshint.prefix - directory where JSHint binary resides * lint.jshint.bin - JSHint binary name (if different from 'jshint') * lint.jshint.config - a JSON file with JSHint project-wide options By default, this linter assumes that JSHint is installed on user's system as an NPM package. Test Plan: (1) Run `npm install jshint -g` to install JSHint and add ArcanistJSHintLinter to your Lint Engine (I didn't see PEP8 or PyFlakes in the PhutilLintEngine so I decided to not to put JSHint in there). After that you can do `arc lint my.js`. (2) Create a new file, config.json, and add `{ "white": true }` in it. Add `"lint.jshint.config": "/path/to/config.json"` to your .arcconfig and run `arc lint my.js`. After that, unless your name is Douglas Crockford, you'll see tons of JSHint warnings about minor PEP8-like things (spacing, etc.)
2012-01-14 00:21:57 +01:00
'ArcanistJSHintLinter' => 'ArcanistLinter',
Add "arc land" as a first-class workflow Summary: This is a fancy version of "land.sh" that uses "git merge --squash" and "arc which" to cover more cases. Test Plan: Ran "arc land" against various repository states (no such branch, not accepted, valid, etc). Things seemed OK. There are basically an infinite number of states here so it's hard to test exhaustively. Reviewers: cpiro, btrahan, jungejason, davidreuss Reviewed By: davidreuss CC: zeeg, aran, epriestley, davidreuss Maniphest Tasks: T787, T723 Differential Revision: https://secure.phabricator.com/D1488
2012-01-26 00:10:59 +01:00
'ArcanistLandWorkflow' => 'ArcanistBaseWorkflow',
'arc liberate', convenience wrapper for various libphutil operations Summary: The story for creating and maintaining libphutil libraries and modules is pretty terrible right now: you need to know a bunch of secret scripts and dark magic. Provide 'arc liberate' which endeavors to always do the right thing and put a library in the correct state. Test Plan: Ran liberate on libphutil, arcanist, phabricator; created new libphutil libraries, added classes to them, liberated everything, introduced errors etc and liberated that stuff, nothing was obviously broken in a terrible way..? Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 269
2011-05-12 01:30:22 +02:00
'ArcanistLiberateWorkflow' => 'ArcanistBaseWorkflow',
Temporarily restore apache/license linters Summary: Restores linters only, without unit tests or entry in ComprehensiveLinter. Marks them deprecated. If use at Facebook isn't widespread I'd prefer to simply delete them. Test Plan: none Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2274 Differential Revision: https://secure.phabricator.com/D4906
2013-02-11 23:12:10 +01:00
'ArcanistLicenseLinter' => 'ArcanistLinter',
Define interface for lint renderers Summary: It makes me nervous. Also move them to the dir. Test Plan: `arc lint` `arc lint --output json` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2644
2012-06-02 02:32:35 +02:00
'ArcanistLintConsoleRenderer' => 'ArcanistLintRenderer',
'ArcanistLintJSONRenderer' => 'ArcanistLintRenderer',
'ArcanistLintLikeCompilerRenderer' => 'ArcanistLintRenderer',
Support `arc lint --output none` Summary: I want to run lint on background and I'm interested only in side effect of caching (and maybe exit status). This is better than discarding stdout later because we don't do unnecessary work and error conditions are still printed. Test Plan: $ arc lint --output none # with error $ echo $? $ arc lint --output none # with no lintable paths $ arc lint --output none # witout errors Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5106
2013-02-25 21:33:51 +01:00
'ArcanistLintNoneRenderer' => 'ArcanistLintRenderer',
Define interface for lint renderers Summary: It makes me nervous. Also move them to the dir. Test Plan: `arc lint` `arc lint --output json` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2644
2012-06-02 02:32:35 +02:00
'ArcanistLintSummaryRenderer' => 'ArcanistLintRenderer',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistLintWorkflow' => 'ArcanistBaseWorkflow',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistLinterTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistListWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistMarkCommittedWorkflow' => 'ArcanistBaseWorkflow',
Basic Mercurial support for Arcanist Summary: There's a lot of ground left to cover but this makes "arc diff" work (on one trivial diff) in my sandbox, at least, and supports parsing of Mercurial native diffs (which are unified + a custom header). Piles of missing features, still. Some of this is blocked by me not understanding the mercurial model well yet. This is also a really good opportunity for cleanup (especially, reducing the level of "instanceof" in the diff workflow), I'll try to do a bunch of that in followup diffs. Test Plan: Ran "arc diff" in a mercurial repository, got a diff out of it. Reviewed By: aran Reviewers: Makinde, jungejason, tuomaspelkonen, aran, codeblock CC: aran, epriestley, codeblock, fratrik Differential Revision: 792
2011-08-09 18:00:29 +02:00
'ArcanistMercurialAPI' => 'ArcanistRepositoryAPI',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistMercurialParserTestCase' => 'ArcanistTestCase',
Add linting for syntax brought in by unresolved merge conflicts. Summary: Add linting capability for detecting files which contain syntax introduced by unresolved merge conflicts. The detection is file-type-agnostic (the only requirement is that the file is a text file). Test Plan: Tested in three ways. The first way is to add all three forms of syntax to a file to indicate a merge conflict. HPHP will pick this up as a syntax error before this linter reaches it. The second way is to add the syntax in a comment. In that case, this linter will show three warnings. For example: $ arc lint ArcanistMergeConflictLinter.php >>> Lint for arcanist/src/lint/linter/ArcanistMergeConflictLinter.php: Warning (MERGECONFLICT1) Unresolved merge conflict This syntax indicates there is still an unresolved merge conflict. 20 21 foreach ($lines as $lineno => $line) { 22 /* >>> 23 >>>>>>> 24 25 ======= Warning (MERGECONFLICT1) Unresolved merge conflict This syntax indicates there is still an unresolved merge conflict. 22 /* 23 >>>>>>> 24 >>> 25 ======= 26 27 <<<<<<< Warning (MERGECONFLICT1) Unresolved merge conflict This syntax indicates there is still an unresolved merge conflict. 24 25 ======= 26 >>> 27 <<<<<<< 28 29 */ The last test was to test on various different file types, including JavaScript, PHP, an animated GIF, a PNG, and a Bash file to make sure the file type detection worked. Each of the aforementioned tests passed. Reviewers: vrana, epriestley Reviewed By: epriestley CC: aran, epriestley, Korvin Maniphest Tasks: T2547 Differential Revision: https://secure.phabricator.com/D4966
2013-02-20 23:19:55 +01:00
'ArcanistMergeConflictLinter' => 'ArcanistLinter',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistNoEffectException' => 'ArcanistUsageException',
'ArcanistNoEngineException' => 'ArcanistUsageException',
Respect @nolint Summary: Respect @nolint annotations Test Plan: New "test case" Differential Revision: 41 Reviewed By: epriestley Reviewers: epriestley CC: epriestley
2011-02-25 02:59:49 +01:00
'ArcanistNoLintLinter' => 'ArcanistLinter',
Make all the working-copy-paths errors extremely explicit.
2011-03-13 03:16:15 +01:00
'ArcanistNoLintTestCaseMisnamed' => 'ArcanistLinterTestCase',
Run PEP8 linter on background Test Plan: $ arc lint pep8.py --cache 0 --engine ComprehensiveLintEngine --trace Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4967
2013-02-15 01:16:08 +01:00
'ArcanistPEP8Linter' => 'ArcanistFutureLinter',
Add an "arc paste" workflow Summary: Read and write in the same workflow! Dogs and cats living together! Test Plan: - Performed a bunch of paste reads and writes and they looked ok? Reviewed By: aran Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 748
2011-07-30 03:55:01 +02:00
'ArcanistPasteWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistPatchWorkflow' => 'ArcanistBaseWorkflow',
PHPCS Linter Summary: Simple wrapper for PHP_CodeSniffer. You need to have PHP_CodeSniffer and it's dependencies installed. Test Plan: - Try running it with your custom lint engine Reviewers: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2560
2012-05-24 10:51:44 +02:00
'ArcanistPhpcsLinter' => 'ArcanistLinter',
Add "ArcanistPhutilLibraryLinter" to replace "ArcanistPhutilModuleLinter" Summary: Adds a linter for v2 libraries which raises the relevant errors. NOTE: Not hooked up anywhere yet, so this diff has no effect. Test Plan: Switched the ModuleLinter to LibraryLinter and ran it with a junk block to trigger errors: >>> Lint for src/lint/linter/phutillibrary/ArcanistPhutilLibraryLinter.php: Error (PHL3) One Class Per File File 'lint/linter/phutillibrary/ArcanistPhutilLibraryLinter.php' mixes function (id) and class/interface (ArcanistPhutilLibraryLinter) definitions in the same file. A file which declares a class or an interface MUST declare nothing else. 190 } 191 192 if (false) { 193 function id() { } 194 new XYZ(); 195 } Error (PHL2) Duplicate Symbol Definition of function 'id' in 'lint/linter/phutillibrary/ArcanistPhutilLibraryLinter.php' in library 'arcanist' duplicates prior definition in 'utils/utils.php' in library 'phutil'. 190 } 191 192 if (false) { 193 function id() { } 194 new XYZ(); 195 } Error (PHL1) Unknown Symbol Use of unknown class 'XYZ'. This symbol is not defined in any loaded libphutil library. 191 192 if (false) { 193 function id() { } 194 new XYZ(); 195 } Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2597
2012-05-30 16:25:09 +02:00
'ArcanistPhutilLibraryLinter' => 'ArcanistLinter',
Pass for phutil test that was expected to fail and skip Summary: I just hope that we will not create `ArcanistPhutilTestCaseTestCaseTestCase`. Also fix a copy/paste error (@edward's this time). Test Plan: `arc unit` Reviewers: epriestley Reviewed By: epriestley CC: edward, aran, Korvin Differential Revision: https://secure.phabricator.com/D2692
2012-06-08 23:22:23 +02:00
'ArcanistPhutilTestCaseTestCase' => 'ArcanistPhutilTestCase',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistPhutilTestSkippedException' => 'Exception',
'ArcanistPhutilTestTerminatedException' => 'Exception',
Separate Phutil specific lint rules from XHPAST Summary: Also provides an example how to build custom linter using XHPAST. Test Plan: Added debug output to `willLintPaths()`, verified that each path is parsed only once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4718
2013-01-29 07:03:03 +01:00
'ArcanistPhutilXHPASTLinter' => 'ArcanistBaseXHPASTLinter',
'ArcanistPhutilXHPASTLinterTestCase' => 'ArcanistArcanistLinterTestCase',
arc lint: add support for PyFlakes Summary: Provide a simple linter wrapper around pyflakes. This relies on finding pyflakes via: - lint.pyflakes.path - arcconfig setting of absolute path to pyflakes - lint.pyflakes.prefix - arcconfig setting of the prefix that pyflakes was installed under - users path Test Plan: linted python code with PyFlakes warnings Reviewed By: epriestley Reviewers: jungejason, epriestley Commenters: jungejason CC: aran, epriestley, andrewjcg, jungejason Differential Revision: 310
2011-05-19 11:00:59 +02:00
'ArcanistPyFlakesLinter' => 'ArcanistLinter',
arc lint: add support for PyLint Summary: Provides a lint class as a wrapper around the external project PyLint. This exposes some arc config variables to control the behavior: lint.pylint.prefix - non-standard installation location of pylint lint.pylint.logilab_astng.prefix - non-standard installation location of logilab-astng, a dependency of pylint lint.pylint.logilab_common.prefix - non-standard installation location of logilab-common, a dependency of pylint lint.pylint.codes.{error,warning,advice} - regexes matching against PyLint message codes which should trigger arc errors/warnings/advice lint.pylint.options - options to pass PyLint Test Plan: used to lint python code Reviewed By: epriestley Reviewers: epriestley, jungejason CC: aran, epriestley Differential Revision: 343
2011-05-22 12:32:26 +02:00
'ArcanistPyLintLinter' => 'ArcanistLinter',
Fix an escaping issue with "svn commit" Summary: Fixes T2438. We currently escape everything with '@', but SVN rejects that for '.' Test Plan: Unit tests. Performed this commit: $ svn st M . A x@123 $ arc commit --conduit-uri=http://local.aphront.com:8080/ --revision 53 Revision 'D53: asdf' has not been accepted. Commit this revision anyway? [y/N] y Committing 'D53: asdf'... Sending . Adding x@123 Transmitting file data . Committed revision 37. Done. I grepped for more '@' adding but couldn't find any. It's a bit tricky to grep for though, so it's possible I missed some. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran, mbishopim3 Maniphest Tasks: T2438 Differential Revision: https://secure.phabricator.com/D4703
2013-01-28 23:11:31 +01:00
'ArcanistRepositoryAPIMiscTestCase' => 'ArcanistTestCase',
Refactor getWorkingCopyStatus() into getUncommittedStatus() and getCommitRangeStatus() Summary: See discussion in D4049. The getWorkingCopyStatus() method gets called from requireCleanWorkingCopy() in a lot of places, which triggers resolution of the base of the commit range. This is unnecessary; we do not need to examine the base commit in order to determine whether the working copy is dirty or not. This causes problems, in D4049 and elsewhere (we currently have a lot of fluff calls to setDefaultBaseCommit() in workflows which need to call requireCleanWorkingCopy() but do not ever use commit ranges, such as `arc patch`). This is mostly an artifact of SVN, where the "commit range" and "uncommitted stuff in the working copy" are always the same. - Split the method into two status methods: getUncommittedStatus() (uncommitted stuff in the working copy, required by requireCleanWorkingCopy()) and getCommitRangeStatus() (committed stuff in the commit range). - Lift caching out of the implementations into the base class. - Dirty the cache after we commit. This doesn't do anything useful on its own and creates one caching problem (`commitRangeStatusCache` is not invalidated when the commit range changes because of `setBaseCommit()` or similar) but I wanted to break things apart here. I won't land it until there's a more complete picture. This creates a minor performance regression in git and hg (we run less stuff in parallel than previously) but all the commands should be disk-bound anyway and the regression should be minor. It prevents a larger regression in `hg` in D4049, and lets us do less work to arrive at common error states (dirty working copy). We can examine perf at the end of this change sequence. Test Plan: Ran unit tests, various `arc` commands. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4095
2012-12-17 21:53:28 +01:00
'ArcanistRepositoryAPIStateTestCase' => 'ArcanistTestCase',
Adding arc revert command[] Summary: Arc Revert does the following: 1. Git revert 2. Go to the differential of the rev you are reverting and either repoen it or set it to a reverted state 3. File a hipri task to orig author [Preview] Creating Arc Revert workflow Porting arc revert from FB4A to phabricator for general usage. This is my first stab, so totally appreciate feedback and assistance. I'm currently focused on making this work for git. However, I built out the functions through the GitAPI so this could be easily extendable to Mercurial later on. Stuck on the following (help): 1. Creating a task for FB internal. I tried building on top of existing arc listeners but getting errors on failures to load the TaskCreator (and other) tasks. 2. I'm using a hacky way to grab the diff revision id from the newly created revert diff. (see line 204) I'm looking for a way to just fetch the diff ID from arc after the diff is created; is this possible? Test Plan: - 1. Ran arc revert on a www and fbcode diff 2. Confirmed that revert was run on the diffs and a proper diff filed - Reviewers: royw, sdwilsh, nh, epriestley Reviewed By: epriestley CC: aran, epriestley, Korvin, pti, keir Maniphest Tasks: T1751 Differential Revision: https://secure.phabricator.com/D5553
2013-05-14 20:00:56 +02:00
'ArcanistRevertWorkflow' => 'ArcanistBaseWorkflow',
Make `ruby -wc` a linter in Arcanist Summary: Add `ruby -wc` as a linter and raise Error whenever there's a syntax error Test Plan: Just a few dumb unit tests. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3447
2012-09-06 20:50:15 +02:00
'ArcanistRubyLinter' => 'ArcanistLinter',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistRubyLinterTestCase' => 'ArcanistArcanistLinterTestCase',
Add a very basic Scala (SBT) linter. Summary: SBT is the most common Scala buildsystem. This adds an extremely basic and slightly horrible linter to check SBT's output for warnings and errors. Test Plan: Tested this with a Scala project I've been working on for some time. It seemed relatively sane. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4064
2012-12-03 17:13:45 +01:00
'ArcanistScalaSBTLinter' => 'ArcanistLinter',
Add "ArcanistSingleLintEngine" and "ArcanistScriptAndRegexLinter" Summary: Request from @csilvers. Allow installs to get most linter features with regexes, configuration and external scripts if they are hesitant to write phutil libraries. - Add "ArcanistSingleLintEngine", which implements the smallest possible engine behavior (run one linter on every path). - Add "ArcanistScriptAndRegexLinter", which uses a script and a regex to parse lint output from other scripts. Depends on D2618. Test Plan: Basics: $ arc set-config lint.engine ArcanistSingleLintEngine Set key 'lint.engine' = 'ArcanistSingleLintEngine'. $ arc set-config lint.engine.single.linter ArcanistScriptAndRegexLinter Set key 'lint.engine.single.linter' = 'ArcanistScriptAndRegexLinter'. $ arc set-config linter.scriptandregex.script 'echo derp #' Set key 'linter.scriptandregex.script' = 'echo derp #'. $ arc set-config linter.scriptandregex.regex '/^(?P<message>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<message>.*)$/m'. $ arc lint >>> Lint for .arcconfig: Error (S&RX) Lint derp 1 { 2 "project_id" : "arcanist", 3 "conduit_uri" : "https://secure.phabricator.com/", Throw: $ arc set-config linter.scriptandregex.regex '/^(?P<throw>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<throw>.*)$/m' (was '/^(?P<message>.*)$/m'). $ arc lint Usage Exception: ArcanistScriptAndRegexLinter: configuration captured a 'throw' named capturing group, 'derp'. Script output: derp Ignore: $ arc set-config linter.scriptandregex.regex '/^(?P<ignore>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<ignore>.*)$/m' (was '/^(?P<throw>.*)$/m'). $ arc lint OKAY No lint warnings. Severity: $ arc set-config linter.scriptandregex.regex '/^(?P<warning>.)(?P<message>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<warning>.)(?P<message>.*)$/m' (was '/^(?P<ignore>.*)$/m'). $ arc lint >>> Lint for src/lint/engine/single/ArcanistSingleLintEngine.php: Warning (S&RX) Lint erp 1 <?php 2 3 /* Reviewers: csilvers, btrahan, vrana Reviewed By: csilvers CC: aran Differential Revision: https://secure.phabricator.com/D2619
2012-05-31 21:09:01 +02:00
'ArcanistScriptAndRegexLinter' => 'ArcanistLinter',
Add "arc get-config" and "arc set-config" for managing ~/.arcrc values Summary: The major thing I want to do here is allow you to set a default Phabricator URI, so we can make "arc paste", and "arc upload", "arc download" work anywhere. We can also relax the .arcconfig requirements (request from @csilvers). Test Plan: Get/set some values? iiam Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2400
2012-05-07 15:07:23 +02:00
'ArcanistSetConfigWorkflow' => 'ArcanistBaseWorkflow',
Basic 'shell-complete' workflow. Summary: Adds data-driven shell completion help to arcanist. Test Plan: ran various commands in git and svn working copies, output seemed reasonable Differential Revision: 201754 Reviewed By: adonohue Reviewers: mroch, adonohue Commenters: crackerjack CC: epriestley, adonohue, achao Revert Plan: OK
2011-01-15 05:00:11 +01:00
'ArcanistShellCompleteWorkflow' => 'ArcanistBaseWorkflow',
Add "ArcanistSingleLintEngine" and "ArcanistScriptAndRegexLinter" Summary: Request from @csilvers. Allow installs to get most linter features with regexes, configuration and external scripts if they are hesitant to write phutil libraries. - Add "ArcanistSingleLintEngine", which implements the smallest possible engine behavior (run one linter on every path). - Add "ArcanistScriptAndRegexLinter", which uses a script and a regex to parse lint output from other scripts. Depends on D2618. Test Plan: Basics: $ arc set-config lint.engine ArcanistSingleLintEngine Set key 'lint.engine' = 'ArcanistSingleLintEngine'. $ arc set-config lint.engine.single.linter ArcanistScriptAndRegexLinter Set key 'lint.engine.single.linter' = 'ArcanistScriptAndRegexLinter'. $ arc set-config linter.scriptandregex.script 'echo derp #' Set key 'linter.scriptandregex.script' = 'echo derp #'. $ arc set-config linter.scriptandregex.regex '/^(?P<message>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<message>.*)$/m'. $ arc lint >>> Lint for .arcconfig: Error (S&RX) Lint derp 1 { 2 "project_id" : "arcanist", 3 "conduit_uri" : "https://secure.phabricator.com/", Throw: $ arc set-config linter.scriptandregex.regex '/^(?P<throw>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<throw>.*)$/m' (was '/^(?P<message>.*)$/m'). $ arc lint Usage Exception: ArcanistScriptAndRegexLinter: configuration captured a 'throw' named capturing group, 'derp'. Script output: derp Ignore: $ arc set-config linter.scriptandregex.regex '/^(?P<ignore>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<ignore>.*)$/m' (was '/^(?P<throw>.*)$/m'). $ arc lint OKAY No lint warnings. Severity: $ arc set-config linter.scriptandregex.regex '/^(?P<warning>.)(?P<message>.*)$/m' Set key 'linter.scriptandregex.regex' = '/^(?P<warning>.)(?P<message>.*)$/m' (was '/^(?P<ignore>.*)$/m'). $ arc lint >>> Lint for src/lint/engine/single/ArcanistSingleLintEngine.php: Warning (S&RX) Lint erp 1 <?php 2 3 /* Reviewers: csilvers, btrahan, vrana Reviewed By: csilvers CC: aran Differential Revision: https://secure.phabricator.com/D2619
2012-05-31 21:09:01 +02:00
'ArcanistSingleLintEngine' => 'ArcanistLintEngine',
Add spell check linter Summary: Inspired by http://news.ycombinator.com/item?id=3464671 and a lot of diffs I've seen @ FB, I've added a spell checking linter. To reduce false positives, it's only a blacklist. Still, it catches a large number of 'issues'. Test Plan: Unit tests. Ran on FB's codebase. No false positives noticed but a lot of cases caught. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley, jack Differential Revision: https://secure.phabricator.com/D1409
2012-01-16 06:28:58 +01:00
'ArcanistSpellingLinter' => 'ArcanistLinter',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistSpellingLinterTestCase' => 'ArcanistArcanistLinterTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistSubversionAPI' => 'ArcanistRepositoryAPI',
[arc svn-hook-pre-commit] Access working copy Summary: Creates a new hook API that can be used to interface with SVN/Git/Mercurial in the context of a commit hook. Currently only adds a function to read the modified file data in a Subversion commit hook. An object of this API is created in the SvnHookPreCommitWorkflow and passed on the Lint Engine which then uses it to access current file data, of the way the APIs seem to be structured); linters use the getData function which is essentially a wrapper around the engine's call, with another layer of caching. Task ID: #770556 Blame Rev: Test Plan: - Create a local svn repository and add a minimal hook to run the local version of arc to test commits (http://phabricator.com/docs/arcanist/article/Installing_Arcanist_SVN_Hooks.html) - Create a temporary repository that can trigger any of the linters available, and test against a temporary linter by committing against the test repository: the linter should be able to access all required files by using loadData/getData in the LintEngine and Linter. Revert Plan: Tags: lint, svn-hook-pre-commit Reviewers: jungejason, asukhachev, epriestley, aran Reviewed By: epriestley CC: aran, jungejason, epriestley, kunalb, asukhachev Differential Revision: https://secure.phabricator.com/D1256
2011-12-21 05:26:05 +01:00
'ArcanistSubversionHookAPI' => 'ArcanistHookAPI',
Add SVN pre-commit hook support. Summary: Basic support for an SVN pre-commit hook. Still very skeletal. Test Plan: Reviewers: CC:
2011-01-12 10:49:48 +01:00
'ArcanistSvnHookPreCommitWorkflow' => 'ArcanistBaseWorkflow',
Add arc tasks command Summary: Added `arc tasks`: %%%arc tasks arc tasks --view-all // View Open and Closed Tasks arc tasks --by-status // Group By Status arc tasks --by-priority // Group By Priority%%% Test Plan: Connect to conduit and run arc tasks >> make sure you have tasks =p Reviewers: epriestley, indiefan Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T749 Differential Revision: https://secure.phabricator.com/D1943
2012-04-08 02:40:25 +02:00
'ArcanistTasksWorkflow' => 'ArcanistBaseWorkflow',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistTextLinter' => 'ArcanistLinter',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistTextLinterTestCase' => 'ArcanistArcanistLinterTestCase',
Create an arc todo workflow for quickly creating a task. Summary: Run `arc todo o rly?` to create a Maniphest task titled 'o rly?'. Pass --cc to add CCs besides yourself. Test Plan: Ran `arc todo o rly?`. Behaved as expected. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T749, T1325 Differential Revision: https://secure.phabricator.com/D2952
2012-07-11 02:32:36 +02:00
'ArcanistTodoWorkflow' => 'ArcanistBaseWorkflow',
When a mercurial working copy has uncommitted changes, prompt to include them in "arc diff" Summary: See task. Allow mercurial users to diff with uncommitted changes. - By default, commit range is merge-base of `hg outgoing` to `.` (dirstate). - You can get JUST dirstate with `arc diff tip` or similar. - This ended up being a giant mess various other changes to deal with empty `hg outgoing` and empty dirstate. Test Plan: Diffed with uncommitted changes, got sensible prompts and results. Reviewers: Makinde, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T998 Differential Revision: https://secure.phabricator.com/D1954
2012-03-20 03:17:10 +01:00
'ArcanistUncommittedChangesException' => 'ArcanistUsageException',
Render unit results progressively Summary: Some tests take longer (fixtures usually around 1 second for me) and also FB runs all tests on deploy. I want to see all results immediately. Test Plan: Added `usleep(200000)` to `resultTest()`, then: $ arc unit Saw results printed one by one. Also didn't pass `$renderer` to `ArcanistPhutilTestCase` and saw empty output. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5141
2013-02-27 22:59:12 +01:00
'ArcanistUnitConsoleRenderer' => 'ArcanistUnitRenderer',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistUnitWorkflow' => 'ArcanistBaseWorkflow',
"arc upgrade", to automatically upgrade arc (client changes) Summary: - Try to limit the pain of //future// version bumps by making arc self-updating. - When the server needs a newer version, prompt the user to update. - (We need them to reissue their command because we may already have loaded classes which have changed in the update.) - Make the message sound exciting! Test Plan: Artifically bumped server forward, ran "arc list", got to upgrade! Reviewers: Makinde, nh, jungejason, btrahan Reviewed By: nh CC: aran Differential Revision: https://secure.phabricator.com/D2435
2012-05-09 19:01:31 +02:00
'ArcanistUpgradeWorkflow' => 'ArcanistBaseWorkflow',
Add 'arc upload' and 'arc download' Summary: Mechanisms for interacting with Files via Arcanist. Test Plan: - Ran 'arc upload x', 'arc upload x y z' - Ran 'arc download' with --as and --show. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 742
2011-07-29 19:05:07 +02:00
'ArcanistUploadWorkflow' => 'ArcanistBaseWorkflow',
Upgrade arcanist to libphutil v2 Summary: Mechanical changes from D2588. No "Class.php" moves yet because they aren't necessary for libraries to function. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2589
2012-05-30 23:22:59 +02:00
'ArcanistUsageException' => 'Exception',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistUserAbortException' => 'ArcanistUsageException',
Add 'arc which', and ArcanistRepositoryAPI->loadWorkingCopyDifferentialRevisions() Summary: - See T787. - @cpiro has an immediate use case for this, which is ##arc amend --revision `arc which --id` --show master## for "git merge --autosquash" or similar. - For T614, we need this to choose "--create" vs "--update". - Other workflows should also use this to improve how often we automatically get things right, particularly in Mercurial and SVN. Test Plan: Ran "arc which" in SVN, Git and HG working copies with various flags; results seemed reasonable. Reviewers: btrahan, cpiro, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T787 Differential Revision: https://secure.phabricator.com/D1478
2012-01-24 17:07:38 +01:00
'ArcanistWhichWorkflow' => 'ArcanistBaseWorkflow',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'ArcanistXHPASTLintNamingHookTestCase' => 'ArcanistTestCase',
Add unit tests for implicit fallthrough lint rule Summary: The perf fix actually catches some real problems. I didn't find anything in libphutil, Arcanist and Phabricator though. Also bump version. Also allow configuring the hook. Test Plan: Added a test, saw it fail with the old code. Repeat for hook. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5097
2013-02-23 06:12:29 +01:00
'ArcanistXHPASTLintTestSwitchHook' => 'ArcanistXHPASTLintSwitchHook',
Separate Phutil specific lint rules from XHPAST Summary: Also provides an example how to build custom linter using XHPAST. Test Plan: Added debug output to `willLintPaths()`, verified that each path is parsed only once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4718
2013-01-29 07:03:03 +01:00
'ArcanistXHPASTLinter' => 'ArcanistBaseXHPASTLinter',
Remove getLink() from ArcanistLinterTestCase Summary: Installations extend this. Another solution would be to extend `ArcanistLinterTestCase` from `ArcanistArcanistLinterTestCase` and return null in `getLink()` to avoid code duplication but I prefer clean class hierarchy. Test Plan: $ arc unit Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3878
2012-11-03 02:09:38 +01:00
'ArcanistXHPASTLinterTestCase' => 'ArcanistArcanistLinterTestCase',
Rebuild phutil library map for arc Summary: D1439 added a new class which had the wrong name in the map from D1439. Whoopsiepoos! Test Plan: unit tests now pass Reviewers: epriestley, zeeg Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1441
2012-01-17 23:54:27 +01:00
'ComprehensiveLintEngine' => 'ArcanistLintEngine',
Provide better documentation for lint engines, linters, and the PyLint linter Summary: Document the relationship between lint engines and linters. Provide an example linter. Improve the documentation of PyLintLinter, which has a bunch of configuration stuff which you had to dig into the code to get. Test Plan: Ran "arc lint --engine ExampleLintEngine --lintall derp.py" on a file with a Python syntax error in it. Read documentation. Reviewed By: j3kuntz Reviewers: j3kuntz, andrewjcg CC: aran, j3kuntz Differential Revision: 557
2011-06-30 04:32:03 +02:00
'ExampleLintEngine' => 'ArcanistLintEngine',
Added base test result parser class. Implemented Go test result parser based on Go's built in test utility output. Test Plan: Ran PhpunitTestEngine unit test and used both test result parsers to generate test results. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D4676
2013-01-28 02:16:50 +01:00
'GoTestResultParser' => 'ArcanistBaseTestResultParser',
'GoTestResultParserTestCase' => 'ArcanistTestCase',
Wrapper for 'nose' unittest and code coverage tools. Summary: Wrapper for Python 'nose' (http://readthedocs.org/docs/nose/en/latest/) testing tool. Test Plan: Install latest 'nose' v1.1.3. Currently it is available through Github only (``pep install git+https://github.com/nose-devs/nose.git``). Create a Python project with following structure: /package_name/module_name.py /tests/package_name/test_module_name.py Write some tests Run ``arc unit`` Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin, zeeg Differential Revision: https://secure.phabricator.com/D2322
2012-04-27 21:11:41 +02:00
'NoseTestEngine' => 'ArcanistBaseUnitTestEngine',
Search for more test locations in PHPUnitTestEngine Summary: See https://github.com/facebook/arcanist/pull/53 - Work correctly for directories with `%` in their name; this breaks under sprintf(). - Search for `src/` -> `tests/` style directories. - Add coverage for search paths. Test Plan: Ran unit tests. I don't have a working test case for PHPUnit tests, can one of you guys apply this and verify I didn't break your setups? Reviewers: quard, aurelijus Reviewed By: aurelijus CC: aran Differential Revision: https://secure.phabricator.com/D3558
2012-09-30 03:03:43 +02:00
'PHPUnitTestEngineTestCase' => 'ArcanistTestCase',
Added base test result parser class. Implemented Go test result parser based on Go's built in test utility output. Test Plan: Ran PhpunitTestEngine unit test and used both test result parsers to generate test results. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D4676
2013-01-28 02:16:50 +01:00
'PhpunitResultParser' => 'ArcanistBaseTestResultParser',
PHPUnit test engine Summary: PHPUnit wrapper for arc. The idea here is simple - find the test case which is related to the updated class file. Generate tmp files for json & clover reports, run phpunit with provided arguments. It supports phpunit configuration file setting in `.arcconfig`: `phpunit_config`. Path should be relative to project root. Test Plan: - Set `unit_engine` to `PhpunitTestEngine` - Try running tests with & without `phpunit_config` option. Reviewers: epriestley, davidreuss Reviewed By: epriestley CC: aran, Koolvin, jungejason Differential Revision: https://secure.phabricator.com/D2472
2012-05-15 15:12:10 +02:00
'PhpunitTestEngine' => 'ArcanistBaseUnitTestEngine',
Initial commit.
2011-01-10 00:22:25 +01:00
'PhutilLintEngine' => 'ArcanistLintEngine',
'PhutilUnitTestEngine' => 'ArcanistBaseUnitTestEngine',
Link Arcanist test cases Summary: See D3455. Test Plan: This diff (after rebase). Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3460
2012-09-08 00:16:39 +02:00
'PhutilUnitTestEngineTestCase' => 'ArcanistTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'UnitTestableArcanistLintEngine' => 'ArcanistLintEngine',
),
));
Copy permalink