revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-27 01:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-arcanist/src/__phutil_library_map__.php

199 lines
10 KiB
PHP
Raw Normal View History

Initial commit.
2011-01-10 00:22:25 +01:00
<?php
/**
* This file is automatically generated. Use 'phutil_mapper.php' to rebuild it.
* @generated
*/
phutil_register_library_map(array(
'class' =>
array(
Add an "arc alias" command Summary: Allow users to easily define aliased arc commands. This is easier than making them muck around with shell stuff, and lets me do stuff like "arc alias adiff diff -- --auto" so I can test --auto more easily. There are some limitations here (for example, you can't put --trace in an alias because it gets parsed too early) but I think it's a reasonable starting point. Test Plan: Set, listed, removed and used aliases. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T896 Differential Revision: https://secure.phabricator.com/D1653
2012-02-21 22:16:52 +01:00
'ArcanistAliasWorkflow' => 'workflow/alias',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistAmendWorkflow' => 'workflow/amend',
'ArcanistApacheLicenseLinter' => 'lint/linter/apachelicense',
Fix greediness in Apache License linter. Summary: The multi-line comment regexp was potentially too greedy. See "greedy.lint-test". - Made it less greedy. - Added test coverage. - Fixed an issue with the Apache license getting applied with too much whitespace against C files. Test Plan: Ran unit tests. Reviewers: aran CC: Differential Revision: 36
2011-02-13 20:57:14 +01:00
'ArcanistApacheLicenseLinterTestCase' => 'lint/linter/apachelicense/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistBaseUnitTestEngine' => 'unit/engine/base',
'ArcanistBaseWorkflow' => 'workflow/base',
arc branch Summary: Appending differential status, sorting, filtering and coloring git branches. I think it turned out rather nicely. On my repository with 70 branches it takes 1.6s, not terrible, though 1.2s is in the conduit call - seems like there is potential for optimization. I didn't end up changing 'arc list', as their semmantics are slightly different, but I'm open to ideas of consolidating them Test Plan: - Tested on both facebook www and arcanist repositories. - Validated that view-all flag works - Validated that the ordering is correct - Validated that the statuses match the differential status. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, slawekbiel Revert Plan: sure Other Notes: Differential Revision: 497
2011-06-23 21:10:59 +02:00
'ArcanistBranchWorkflow' => 'workflow/branch',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistBundle' => 'parser/bundle',
Fix ArcanistBundle to generate disjoint, minimal hunks Summary: 'patch' chokes on hunks with too much trailing stuff. 'git apply' chokes on overlapping hunks. Make them both happy. Write some test cases so I stop breaking this stuff. Test Plan: - Applied a previously-failing patch via SVN. - Applied a previously-failing-then-succeeding patch via Git. - Ran unit tests. Reviewers: jungejason, btrahan, nh, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason Differential Revision: 1099
2011-11-10 02:55:04 +01:00
'ArcanistBundleTestCase' => 'parser/bundle/__tests__',
Provide 'arc call-conduit' to facilitate script integration with Phabricator Summary: Provide a formal mechanism for making conduit calls from other scripts. Test Plan: Called 'conduit.ping'. Reviewed By: jungejason Reviewers: aran, jungejason, tuomaspelkonen CC: aran, jungejason Differential Revision: 239
2011-05-06 17:43:38 +02:00
'ArcanistCallConduitWorkflow' => 'workflow/call-conduit',
Add an "arc merge" workflow Summary: This should support conservative rewrite policies in git fairly well, under an assumed workflow of: - Develop in local branches, never rewrite history. - Commit with "-m" or by typing a brief, non-template commit message describing the checkpoint. - Provide rich information in the web console (reviewers, etc.) - Finalize with "git checkout master && arc merge branch && git push" or some flavor thereof. This supports Mercurial somewhat. The major problem is that "hg merge" fails if the local is a fastforward of the remote, at which point there's nowhere we can throw the commit message. Oh well. Just push it and we'll do our best to link them up based on local commit info. I am increasingly forming an opinion that Mercurial is "saftey-scissors git". But also maybe I have no clue what I'm doing. I just don't understand why anyone would think it's a good idea to have a trunk consisting of ~50% known-broken revisions, random checkpoint parts, whitespace changes, typo fixes, etc. If you use git with branching you can avoid this by making a trunk out of merges or with rebase/amend, but there seems to be no way to have "one commit = one idea" in any real sense in Mercurial. Test Plan: Execute "arc merge" in git and mercurial. Reviewers: fratrik, Makinde, aran, jungejason, tuomaspelkonen Reviewed By: Makinde CC: aran, epriestley, Makinde Differential Revision: 860
2011-08-26 01:02:03 +02:00
'ArcanistCapabilityNotSupportedException' => 'workflow/exception/notsupported',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistChooseInvalidRevisionException' => 'exception',
'ArcanistChooseNoRevisionsException' => 'exception',
Rename "arc mark-committed" to "arc close-revision" Summary: - Replace SVN-specific language with VCS-agnostic language. - Add new "arc close-revision", works exactly like "arc mark-committed" but with agnostic language. - Use status constants, not status strings. - Mark "arc mark-committed" deprecated. - Remove deprecated "arc merge". Test Plan: Ran "arc mark-committed", "arc close-revision". Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran, Makinde Maniphest Tasks: T909 Differential Revision: https://secure.phabricator.com/D2244
2012-04-17 22:51:10 +02:00
'ArcanistCloseRevisionWorkflow' => 'workflow/close-revision',
Add arc close command Summary: ```arc close T1088 --status wontfix --message "I'm not going to fix this."``` T1088 is the test task to screw with, so feel free. Test Plan: ```arc close T1088 --status [ resolved | wontfix | invalid | duplicate | spite | open ] -m "Message"``` Reviewers: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2162
2012-04-09 05:55:10 +02:00
'ArcanistCloseWorkflow' => 'workflow/close',
Remove only trailing "#" and empty lines as comments from CLI editors Summary: Don't strip numbered lists in comment bodies, etc. Test Plan: Unit tests, meta-testing this diff. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1124 Differential Revision: https://secure.phabricator.com/D2262
2012-04-18 15:08:41 +02:00
'ArcanistCommentRemover' => 'parser/commentremover',
'ArcanistCommentRemoverTestCase' => 'parser/commentremover/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistCommitWorkflow' => 'workflow/commit',
Add ArcanistConduitLinter, a linter that delegates through Conduit Summary: Julien built a really cool static analysis database of our codebase. One capability is that it can suggest typehints that are not in the code. The analysis to do this is very expensive, so it can't reasonably be run locally. But it can remain indexed on a server. The idea here is to provide a familiar interface to it through arc lint, via a generic Conduit service call. In our lint engine, this will probably be gated on --advice for performance. This will introduce a slight awkwardness in that running with --advice can add new non-advice lint if the server chooses, but this isn't likely to cause a practical problem. Test Plan: Construct a fake Conduit lint endpoint, attach this linter to it, and see bogus lint appear with --advice. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1462
2012-01-20 02:09:27 +01:00
'ArcanistConduitLinter' => 'lint/linter/conduit',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistConfiguration' => 'configuration',
'ArcanistCoverWorkflow' => 'workflow/cover',
'ArcanistDiffChange' => 'parser/diff/change',
'ArcanistDiffChangeType' => 'parser/diff/changetype',
'ArcanistDiffHunk' => 'parser/diff/hunk',
'ArcanistDiffParser' => 'parser/diff',
'ArcanistDiffParserTestCase' => 'parser/diff/__tests__',
Add ArcanistDiffUtils. Summary: Test Plan: Reviewers: CC:
2011-01-25 01:46:19 +01:00
'ArcanistDiffUtils' => 'difference',
Use linear distance instead of square distance in levenshtein Summary: We used square distance that optimized for the wrong thing. Making the same markers spread out instead of being together Also added a very little cost for switching type. That will make diff types stick together a bit more Task ID: #623 Blame Rev: Test Plan: Ran my new unit test. And tested a few diff in phabricator Revert Plan: Tags: Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: 1112
2011-11-15 19:43:36 +01:00
'ArcanistDiffUtilsTestCase' => 'difference/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistDiffWorkflow' => 'workflow/diff',
'ArcanistDifferentialCommitMessage' => 'differential/commitmessage',
'ArcanistDifferentialCommitMessageParserException' => 'differential/commitmessage',
Arc - add a sanity check to arc patch workflows to make sure the vcs base revision is the correct base revision relative to the patch. Summary: What the title says. If not correct, warn the user. This check honors the --force flag to skip all these checks. This change also includes moving some Differential constants into Arc so they can be used for both projects. There is a corresponding phabricator diff (incoming) to address this part of the change. Test Plan: For a project with actual diffs, a git repository tracked by phabricator, *AND* development in master branch only, do some... - git reset --hard HEAD^1 - arc patch DX, where X is what got us to HEAD in the first place - verify successful patch ...then... - git reset --hard HEAD^^ - arc patch DX, where X is what got us to HEAD in the first place - verify warning - verify Y versus N continues versus stops appropriately Note if development were done outside the master branch this warning message will fire early / often as git commit hashes are based on the commit *and* the rest of the source code the commit is made against. This is (unfortunately) the "typical" case so this warning is pretty active at the moment. T201 will eventually land and when parsing a given commit update the corresponding diff. Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Differential Revision: https://secure.phabricator.com/D1328
2011-12-03 01:21:14 +01:00
'ArcanistDifferentialRevisionHash' => 'differential/constants/revisionhash',
'ArcanistDifferentialRevisionStatus' => 'differential/constants/revisionstatus',
Add 'arc upload' and 'arc download' Summary: Mechanisms for interacting with Files via Arcanist. Test Plan: - Ran 'arc upload x', 'arc upload x y z' - Ran 'arc download' with --as and --show. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 742
2011-07-29 19:05:07 +02:00
'ArcanistDownloadWorkflow' => 'workflow/download',
Add events framework to Arcanist Test Plan: Added a test event listener, added an event dispatch in diff workflow, run the workflow, the listener was called. Reviewers: epriestley Reviewed By: epriestley CC: aran, jungejason, epriestley Differential Revision: 1102
2011-11-10 22:47:45 +01:00
'ArcanistEventType' => 'events/constant/type',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistExportWorkflow' => 'workflow/export',
'ArcanistFilenameLinter' => 'lint/linter/filename',
'ArcanistGeneratedLinter' => 'lint/linter/generated',
'ArcanistGitAPI' => 'repository/api/git',
'ArcanistGitHookPreReceiveWorkflow' => 'workflow/git-hook-pre-receive',
'ArcanistHelpWorkflow' => 'workflow/help',
[arc svn-hook-pre-commit] Access working copy Summary: Creates a new hook API that can be used to interface with SVN/Git/Mercurial in the context of a commit hook. Currently only adds a function to read the modified file data in a Subversion commit hook. An object of this API is created in the SvnHookPreCommitWorkflow and passed on the Lint Engine which then uses it to access current file data, of the way the APIs seem to be structured); linters use the getData function which is essentially a wrapper around the engine's call, with another layer of caching. Task ID: #770556 Blame Rev: Test Plan: - Create a local svn repository and add a minimal hook to run the local version of arc to test commits (http://phabricator.com/docs/arcanist/article/Installing_Arcanist_SVN_Hooks.html) - Create a temporary repository that can trigger any of the linters available, and test against a temporary linter by committing against the test repository: the linter should be able to access all required files by using loadData/getData in the LintEngine and Linter. Revert Plan: Tags: lint, svn-hook-pre-commit Reviewers: jungejason, asukhachev, epriestley, aran Reviewed By: epriestley CC: aran, jungejason, epriestley, kunalb, asukhachev Differential Revision: https://secure.phabricator.com/D1256
2011-12-21 05:26:05 +01:00
'ArcanistHookAPI' => 'repository/hookapi/base',
"arc install-certificate", client side changes Summary: Provide an "install-certificate" workflow to simplify ~/.arcrc edits. See also D460. Test Plan: Installed certificates via "arc install-certificate". Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 465
2011-06-14 21:18:40 +02:00
'ArcanistInstallCertificateWorkflow' => 'workflow/install-certificate',
Adds ArcanistJSHintLinter to check JS files for errors and potential problems. This patch adds ArcanistJSHintLinter class and three new .arcconfig options: * lint.jshint.prefix - directory where JSHint binary resides * lint.jshint.bin - JSHint binary name (if different from 'jshint') * lint.jshint.config - a JSON file with JSHint project-wide options By default, this linter assumes that JSHint is installed on user's system as an NPM package. Test Plan: (1) Run `npm install jshint -g` to install JSHint and add ArcanistJSHintLinter to your Lint Engine (I didn't see PEP8 or PyFlakes in the PhutilLintEngine so I decided to not to put JSHint in there). After that you can do `arc lint my.js`. (2) Create a new file, config.json, and add `{ "white": true }` in it. Add `"lint.jshint.config": "/path/to/config.json"` to your .arcconfig and run `arc lint my.js`. After that, unless your name is Douglas Crockford, you'll see tons of JSHint warnings about minor PEP8-like things (spacing, etc.)
2012-01-14 00:21:57 +01:00
'ArcanistJSHintLinter' => 'lint/linter/jshint',
Add "arc land" as a first-class workflow Summary: This is a fancy version of "land.sh" that uses "git merge --squash" and "arc which" to cover more cases. Test Plan: Ran "arc land" against various repository states (no such branch, not accepted, valid, etc). Things seemed OK. There are basically an infinite number of states here so it's hard to test exhaustively. Reviewers: cpiro, btrahan, jungejason, davidreuss Reviewed By: davidreuss CC: zeeg, aran, epriestley, davidreuss Maniphest Tasks: T787, T723 Differential Revision: https://secure.phabricator.com/D1488
2012-01-26 00:10:59 +01:00
'ArcanistLandWorkflow' => 'workflow/land',
'arc liberate', convenience wrapper for various libphutil operations Summary: The story for creating and maintaining libphutil libraries and modules is pretty terrible right now: you need to know a bunch of secret scripts and dark magic. Provide 'arc liberate' which endeavors to always do the right thing and put a library in the correct state. Test Plan: Ran liberate on libphutil, arcanist, phabricator; created new libphutil libraries, added classes to them, liberated everything, introduced errors etc and liberated that stuff, nothing was obviously broken in a terrible way..? Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 269
2011-05-12 01:30:22 +02:00
'ArcanistLiberateLintEngine' => 'lint/engine/liberate',
'ArcanistLiberateWorkflow' => 'workflow/liberate',
Refactor Apache license linter to parameterize the license itself. Summary: Refactor Apache license linter to parameterize the license itself. Test Plan: meta - begin *PUBLIC* platform impact section - Bugzilla: # - end platform impact - Differential Revision: 33 Reviewed By: epriestley Reviewers: epriestley
2011-02-12 01:03:00 +01:00
'ArcanistLicenseLinter' => 'lint/linter/license',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistLintEngine' => 'lint/engine/base',
init invest
2011-04-13 23:18:30 +02:00
'ArcanistLintJSONRenderer' => 'lint/renderer',
When a mercurial working copy has uncommitted changes, prompt to include them in "arc diff" Summary: See task. Allow mercurial users to diff with uncommitted changes. - By default, commit range is merge-base of `hg outgoing` to `.` (dirstate). - You can get JUST dirstate with `arc diff tip` or similar. - This ended up being a giant mess various other changes to deal with empty `hg outgoing` and empty dirstate. Test Plan: Diffed with uncommitted changes, got sensible prompts and results. Reviewers: Makinde, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T998 Differential Revision: https://secure.phabricator.com/D1954
2012-03-20 03:17:10 +01:00
'ArcanistLintLikeCompilerRenderer' => 'lint/renderer',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistLintMessage' => 'lint/message',
'ArcanistLintPatcher' => 'lint/patcher',
'ArcanistLintRenderer' => 'lint/renderer',
'ArcanistLintResult' => 'lint/result',
'ArcanistLintSeverity' => 'lint/severity',
init invest
2011-04-13 23:18:30 +02:00
'ArcanistLintSummaryRenderer' => 'lint/renderer',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistLintWorkflow' => 'workflow/lint',
'ArcanistLinter' => 'lint/linter/base',
Fix greediness in Apache License linter. Summary: The multi-line comment regexp was potentially too greedy. See "greedy.lint-test". - Made it less greedy. - Added test coverage. - Fixed an issue with the Apache license getting applied with too much whitespace against C files. Test Plan: Ran unit tests. Reviewers: aran CC: Differential Revision: 36
2011-02-13 20:57:14 +01:00
'ArcanistLinterTestCase' => 'lint/linter/base/test',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistListWorkflow' => 'workflow/list',
'ArcanistMarkCommittedWorkflow' => 'workflow/mark-committed',
Basic Mercurial support for Arcanist Summary: There's a lot of ground left to cover but this makes "arc diff" work (on one trivial diff) in my sandbox, at least, and supports parsing of Mercurial native diffs (which are unified + a custom header). Piles of missing features, still. Some of this is blocked by me not understanding the mercurial model well yet. This is also a really good opportunity for cleanup (especially, reducing the level of "instanceof" in the diff workflow), I'll try to do a bunch of that in followup diffs. Test Plan: Ran "arc diff" in a mercurial repository, got a diff out of it. Reviewed By: aran Reviewers: Makinde, jungejason, tuomaspelkonen, aran, codeblock CC: aran, epriestley, codeblock, fratrik Differential Revision: 792
2011-08-09 18:00:29 +02:00
'ArcanistMercurialAPI' => 'repository/api/mercurial',
Split mercurial parsing and API Summary: Move code to actually parse "hg" output into a separate class with some tests, so I can reuse it in the import scripts. We should probably do this for Git/SVN at some point, too. Test Plan: Ran unit tests, used this class in Phabricator importers, grepped for calls to removed private methods. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde Differential Revision: 942
2011-09-16 12:53:52 +02:00
'ArcanistMercurialParser' => 'repository/parser/mercurial',
'ArcanistMercurialParserTestCase' => 'repository/parser/mercurial/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistNoEffectException' => 'exception/usage/noeffect',
'ArcanistNoEngineException' => 'exception/usage/noengine',
Respect @nolint Summary: Respect @nolint annotations Test Plan: New "test case" Differential Revision: 41 Reviewed By: epriestley Reviewers: epriestley CC: epriestley
2011-02-25 02:59:49 +01:00
'ArcanistNoLintLinter' => 'lint/linter/nolint',
Make all the working-copy-paths errors extremely explicit.
2011-03-13 03:16:15 +01:00
'ArcanistNoLintTestCaseMisnamed' => 'lint/linter/nolint/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistPEP8Linter' => 'lint/linter/pep8',
Add an "arc paste" workflow Summary: Read and write in the same workflow! Dogs and cats living together! Test Plan: - Performed a bunch of paste reads and writes and they looked ok? Reviewed By: aran Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 748
2011-07-30 03:55:01 +02:00
'ArcanistPasteWorkflow' => 'workflow/paste',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistPatchWorkflow' => 'workflow/patch',
'ArcanistPhutilModuleLinter' => 'lint/linter/phutilmodule',
'ArcanistPhutilTestCase' => 'unit/engine/phutil/testcase',
'ArcanistPhutilTestTerminatedException' => 'unit/engine/phutil/testcase/exception',
arc lint: add support for PyFlakes Summary: Provide a simple linter wrapper around pyflakes. This relies on finding pyflakes via: - lint.pyflakes.path - arcconfig setting of absolute path to pyflakes - lint.pyflakes.prefix - arcconfig setting of the prefix that pyflakes was installed under - users path Test Plan: linted python code with PyFlakes warnings Reviewed By: epriestley Reviewers: jungejason, epriestley Commenters: jungejason CC: aran, epriestley, andrewjcg, jungejason Differential Revision: 310
2011-05-19 11:00:59 +02:00
'ArcanistPyFlakesLinter' => 'lint/linter/pyflakes',
arc lint: add support for PyLint Summary: Provides a lint class as a wrapper around the external project PyLint. This exposes some arc config variables to control the behavior: lint.pylint.prefix - non-standard installation location of pylint lint.pylint.logilab_astng.prefix - non-standard installation location of logilab-astng, a dependency of pylint lint.pylint.logilab_common.prefix - non-standard installation location of logilab-common, a dependency of pylint lint.pylint.codes.{error,warning,advice} - regexes matching against PyLint message codes which should trigger arc errors/warnings/advice lint.pylint.options - options to pass PyLint Test Plan: used to lint python code Reviewed By: epriestley Reviewers: epriestley, jungejason CC: aran, epriestley Differential Revision: 343
2011-05-22 12:32:26 +02:00
'ArcanistPyLintLinter' => 'lint/linter/pylint',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistRepositoryAPI' => 'repository/api/base',
Basic 'shell-complete' workflow. Summary: Adds data-driven shell completion help to arcanist. Test Plan: ran various commands in git and svn working copies, output seemed reasonable Differential Revision: 201754 Reviewed By: adonohue Reviewers: mroch, adonohue Commenters: crackerjack CC: epriestley, adonohue, achao Revert Plan: OK
2011-01-15 05:00:11 +01:00
'ArcanistShellCompleteWorkflow' => 'workflow/shell-complete',
Add spell check linter Summary: Inspired by http://news.ycombinator.com/item?id=3464671 and a lot of diffs I've seen @ FB, I've added a spell checking linter. To reduce false positives, it's only a blacklist. Still, it catches a large number of 'issues'. Test Plan: Unit tests. Ran on FB's codebase. No false positives noticed but a lot of cases caught. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley, jack Differential Revision: https://secure.phabricator.com/D1409
2012-01-16 06:28:58 +01:00
'ArcanistSpellingDefaultData' => 'lint/linter/spelling',
'ArcanistSpellingLinter' => 'lint/linter/spelling',
'ArcanistSpellingLinterTestCase' => 'lint/linter/spelling/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistSubversionAPI' => 'repository/api/subversion',
[arc svn-hook-pre-commit] Access working copy Summary: Creates a new hook API that can be used to interface with SVN/Git/Mercurial in the context of a commit hook. Currently only adds a function to read the modified file data in a Subversion commit hook. An object of this API is created in the SvnHookPreCommitWorkflow and passed on the Lint Engine which then uses it to access current file data, of the way the APIs seem to be structured); linters use the getData function which is essentially a wrapper around the engine's call, with another layer of caching. Task ID: #770556 Blame Rev: Test Plan: - Create a local svn repository and add a minimal hook to run the local version of arc to test commits (http://phabricator.com/docs/arcanist/article/Installing_Arcanist_SVN_Hooks.html) - Create a temporary repository that can trigger any of the linters available, and test against a temporary linter by committing against the test repository: the linter should be able to access all required files by using loadData/getData in the LintEngine and Linter. Revert Plan: Tags: lint, svn-hook-pre-commit Reviewers: jungejason, asukhachev, epriestley, aran Reviewed By: epriestley CC: aran, jungejason, epriestley, kunalb, asukhachev Differential Revision: https://secure.phabricator.com/D1256
2011-12-21 05:26:05 +01:00
'ArcanistSubversionHookAPI' => 'repository/hookapi/subversion',
Add SVN pre-commit hook support. Summary: Basic support for an SVN pre-commit hook. Still very skeletal. Test Plan: Reviewers: CC:
2011-01-12 10:49:48 +01:00
'ArcanistSvnHookPreCommitWorkflow' => 'workflow/svn-hook-pre-commit',
Add arc tasks command Summary: Added `arc tasks`: %%%arc tasks arc tasks --view-all // View Open and Closed Tasks arc tasks --by-status // Group By Status arc tasks --by-priority // Group By Priority%%% Test Plan: Connect to conduit and run arc tasks >> make sure you have tasks =p Reviewers: epriestley, indiefan Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T749 Differential Revision: https://secure.phabricator.com/D1943
2012-04-08 02:40:25 +02:00
'ArcanistTasksWorkflow' => 'workflow/tasks',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistTextLinter' => 'lint/linter/text',
Add @nocommit and tests to Text linter. Summary: Test Plan: Reviewers: CC:
2011-02-17 02:26:51 +01:00
'ArcanistTextLinterTestCase' => 'lint/linter/text/__tests__',
When a mercurial working copy has uncommitted changes, prompt to include them in "arc diff" Summary: See task. Allow mercurial users to diff with uncommitted changes. - By default, commit range is merge-base of `hg outgoing` to `.` (dirstate). - You can get JUST dirstate with `arc diff tip` or similar. - This ended up being a giant mess various other changes to deal with empty `hg outgoing` and empty dirstate. Test Plan: Diffed with uncommitted changes, got sensible prompts and results. Reviewers: Makinde, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T998 Differential Revision: https://secure.phabricator.com/D1954
2012-03-20 03:17:10 +01:00
'ArcanistUncommittedChangesException' => 'exception/usage/uncommittedchanges',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistUnitTestResult' => 'unit/result',
'ArcanistUnitWorkflow' => 'workflow/unit',
Add 'arc upload' and 'arc download' Summary: Mechanisms for interacting with Files via Arcanist. Test Plan: - Ran 'arc upload x', 'arc upload x y z' - Ran 'arc download' with --as and --show. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 742
2011-07-29 19:05:07 +02:00
'ArcanistUploadWorkflow' => 'workflow/upload',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistUsageException' => 'exception/usage',
'ArcanistUserAbortException' => 'exception/usage/userabort',
Add 'arc which', and ArcanistRepositoryAPI->loadWorkingCopyDifferentialRevisions() Summary: - See T787. - @cpiro has an immediate use case for this, which is ##arc amend --revision `arc which --id` --show master## for "git merge --autosquash" or similar. - For T614, we need this to choose "--create" vs "--update". - Other workflows should also use this to improve how often we automatically get things right, particularly in Mercurial and SVN. Test Plan: Ran "arc which" in SVN, Git and HG working copies with various flags; results seemed reasonable. Reviewers: btrahan, cpiro, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T787 Differential Revision: https://secure.phabricator.com/D1478
2012-01-24 17:07:38 +01:00
'ArcanistWhichWorkflow' => 'workflow/which',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistWorkingCopyIdentity' => 'workingcopyidentity',
Allow XHPAST lint name rules to be overridden through configuration Summary: See T326. Allow lint rules to be selectively overridden, e.g. for Conduit methods. Since FB has a long history of suggesting crazy patches for this stuff I think we're safer just adding a hook class than trying to do some kind of regexp magic. Test Plan: Wrote a hook for Phabricator and linted some Conduit files without issues. Ran unit tests. Reviewers: nh, jungejason, tuomaspelkonen, aran Reviewed By: nh CC: aran, nh Differential Revision: 874
2011-08-30 22:07:01 +02:00
'ArcanistXHPASTLintNamingHook' => 'lint/linter/xhpast/naminghook',
Improve Arcanist symbol name linter Summary: - Move name helper functions to ArcanistXHPASTLintNamingHook to make it easier to write custom linters. - Add test coverage for name functions. - Add 'variable' and 'global' naming convention tests. - Expand test cases. - Improve lint message error when an unexpected message is raised during a test. - Remove a defunct XHP lint message. Test Plan: - Ran unit tests. - Ran "arc lint --lintall" on arcanist/. Reviewers: btrahan, nh, jungejason Reviewed By: btrahan CC: johnduhart, aran, epriestley, arudolph Differential Revision: https://secure.phabricator.com/D1506
2012-01-28 20:17:45 +01:00
'ArcanistXHPASTLintNamingHookTestCase' => 'lint/linter/xhpast/naminghook/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistXHPASTLinter' => 'lint/linter/xhpast',
'ArcanistXHPASTLinterTestCase' => 'lint/linter/xhpast/__tests__',
arc branch Summary: Appending differential status, sorting, filtering and coloring git branches. I think it turned out rather nicely. On my repository with 70 branches it takes 1.6s, not terrible, though 1.2s is in the conduit call - seems like there is potential for optimization. I didn't end up changing 'arc list', as their semmantics are slightly different, but I'm open to ideas of consolidating them Test Plan: - Tested on both facebook www and arcanist repositories. - Validated that view-all flag works - Validated that the ordering is correct - Validated that the statuses match the differential status. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, slawekbiel Revert Plan: sure Other Notes: Differential Revision: 497
2011-06-23 21:10:59 +02:00
'BranchInfo' => 'branch',
Rebuild phutil library map for arc Summary: D1439 added a new class which had the wrong name in the map from D1439. Whoopsiepoos! Test Plan: unit tests now pass Reviewers: epriestley, zeeg Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1441
2012-01-17 23:54:27 +01:00
'ComprehensiveLintEngine' => 'lint/engine/comprehensive',
Provide better documentation for lint engines, linters, and the PyLint linter Summary: Document the relationship between lint engines and linters. Provide an example linter. Improve the documentation of PyLintLinter, which has a bunch of configuration stuff which you had to dig into the code to get. Test Plan: Ran "arc lint --engine ExampleLintEngine --lintall derp.py" on a file with a Python syntax error in it. Read documentation. Reviewed By: j3kuntz Reviewers: j3kuntz, andrewjcg CC: aran, j3kuntz Differential Revision: 557
2011-06-30 04:32:03 +02:00
'ExampleLintEngine' => 'lint/engine/example',
Initial commit.
2011-01-10 00:22:25 +01:00
'PhutilLintEngine' => 'lint/engine/phutil',
Some documentation. Summary: Test Plan: Reviewers: CC:
2011-02-19 20:36:08 +01:00
'PhutilModuleRequirements' => 'parser/phutilmodule',
Initial commit.
2011-01-10 00:22:25 +01:00
'PhutilUnitTestEngine' => 'unit/engine/phutil',
Ship unresolved unit test information to Differential. Summary: Test Plan: Reviewers: CC:
2011-01-12 07:13:31 +01:00
'PhutilUnitTestEngineTestCase' => 'unit/engine/phutil/__tests__',
Initial commit.
2011-01-10 00:22:25 +01:00
'UnitTestableArcanistLintEngine' => 'lint/engine/test',
),
'function' =>
array(
),
'requires_class' =>
array(
Add an "arc alias" command Summary: Allow users to easily define aliased arc commands. This is easier than making them muck around with shell stuff, and lets me do stuff like "arc alias adiff diff -- --auto" so I can test --auto more easily. There are some limitations here (for example, you can't put --trace in an alias because it gets parsed too early) but I think it's a reasonable starting point. Test Plan: Set, listed, removed and used aliases. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T896 Differential Revision: https://secure.phabricator.com/D1653
2012-02-21 22:16:52 +01:00
'ArcanistAliasWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistAmendWorkflow' => 'ArcanistBaseWorkflow',
Refactor Apache license linter to parameterize the license itself. Summary: Refactor Apache license linter to parameterize the license itself. Test Plan: meta - begin *PUBLIC* platform impact section - Bugzilla: # - end platform impact - Differential Revision: 33 Reviewed By: epriestley Reviewers: epriestley
2011-02-12 01:03:00 +01:00
'ArcanistApacheLicenseLinter' => 'ArcanistLicenseLinter',
Fix greediness in Apache License linter. Summary: The multi-line comment regexp was potentially too greedy. See "greedy.lint-test". - Made it less greedy. - Added test coverage. - Fixed an issue with the Apache license getting applied with too much whitespace against C files. Test Plan: Ran unit tests. Reviewers: aran CC: Differential Revision: 36
2011-02-13 20:57:14 +01:00
'ArcanistApacheLicenseLinterTestCase' => 'ArcanistLinterTestCase',
arc branch Summary: Appending differential status, sorting, filtering and coloring git branches. I think it turned out rather nicely. On my repository with 70 branches it takes 1.6s, not terrible, though 1.2s is in the conduit call - seems like there is potential for optimization. I didn't end up changing 'arc list', as their semmantics are slightly different, but I'm open to ideas of consolidating them Test Plan: - Tested on both facebook www and arcanist repositories. - Validated that view-all flag works - Validated that the ordering is correct - Validated that the statuses match the differential status. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, slawekbiel Revert Plan: sure Other Notes: Differential Revision: 497
2011-06-23 21:10:59 +02:00
'ArcanistBranchWorkflow' => 'ArcanistBaseWorkflow',
Fix ArcanistBundle to generate disjoint, minimal hunks Summary: 'patch' chokes on hunks with too much trailing stuff. 'git apply' chokes on overlapping hunks. Make them both happy. Write some test cases so I stop breaking this stuff. Test Plan: - Applied a previously-failing patch via SVN. - Applied a previously-failing-then-succeeding patch via Git. - Ran unit tests. Reviewers: jungejason, btrahan, nh, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason Differential Revision: 1099
2011-11-10 02:55:04 +01:00
'ArcanistBundleTestCase' => 'ArcanistPhutilTestCase',
Provide 'arc call-conduit' to facilitate script integration with Phabricator Summary: Provide a formal mechanism for making conduit calls from other scripts. Test Plan: Called 'conduit.ping'. Reviewed By: jungejason Reviewers: aran, jungejason, tuomaspelkonen CC: aran, jungejason Differential Revision: 239
2011-05-06 17:43:38 +02:00
'ArcanistCallConduitWorkflow' => 'ArcanistBaseWorkflow',
Rename "arc mark-committed" to "arc close-revision" Summary: - Replace SVN-specific language with VCS-agnostic language. - Add new "arc close-revision", works exactly like "arc mark-committed" but with agnostic language. - Use status constants, not status strings. - Mark "arc mark-committed" deprecated. - Remove deprecated "arc merge". Test Plan: Ran "arc mark-committed", "arc close-revision". Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran, Makinde Maniphest Tasks: T909 Differential Revision: https://secure.phabricator.com/D2244
2012-04-17 22:51:10 +02:00
'ArcanistCloseRevisionWorkflow' => 'ArcanistBaseWorkflow',
Add arc close command Summary: ```arc close T1088 --status wontfix --message "I'm not going to fix this."``` T1088 is the test task to screw with, so feel free. Test Plan: ```arc close T1088 --status [ resolved | wontfix | invalid | duplicate | spite | open ] -m "Message"``` Reviewers: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2162
2012-04-09 05:55:10 +02:00
'ArcanistCloseWorkflow' => 'ArcanistBaseWorkflow',
Remove only trailing "#" and empty lines as comments from CLI editors Summary: Don't strip numbered lists in comment bodies, etc. Test Plan: Unit tests, meta-testing this diff. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1124 Differential Revision: https://secure.phabricator.com/D2262
2012-04-18 15:08:41 +02:00
'ArcanistCommentRemoverTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistCommitWorkflow' => 'ArcanistBaseWorkflow',
Add ArcanistConduitLinter, a linter that delegates through Conduit Summary: Julien built a really cool static analysis database of our codebase. One capability is that it can suggest typehints that are not in the code. The analysis to do this is very expensive, so it can't reasonably be run locally. But it can remain indexed on a server. The idea here is to provide a familiar interface to it through arc lint, via a generic Conduit service call. In our lint engine, this will probably be gated on --advice for performance. This will introduce a slight awkwardness in that running with --advice can add new non-advice lint if the server chooses, but this isn't likely to cause a practical problem. Test Plan: Construct a fake Conduit lint endpoint, attach this linter to it, and see bogus lint appear with --advice. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1462
2012-01-20 02:09:27 +01:00
'ArcanistConduitLinter' => 'ArcanistLinter',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistCoverWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistDiffParserTestCase' => 'ArcanistPhutilTestCase',
Use linear distance instead of square distance in levenshtein Summary: We used square distance that optimized for the wrong thing. Making the same markers spread out instead of being together Also added a very little cost for switching type. That will make diff types stick together a bit more Task ID: #623 Blame Rev: Test Plan: Ran my new unit test. And tested a few diff in phabricator Revert Plan: Tags: Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: 1112
2011-11-15 19:43:36 +01:00
'ArcanistDiffUtilsTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistDiffWorkflow' => 'ArcanistBaseWorkflow',
Add 'arc upload' and 'arc download' Summary: Mechanisms for interacting with Files via Arcanist. Test Plan: - Ran 'arc upload x', 'arc upload x y z' - Ran 'arc download' with --as and --show. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 742
2011-07-29 19:05:07 +02:00
'ArcanistDownloadWorkflow' => 'ArcanistBaseWorkflow',
Add events framework to Arcanist Test Plan: Added a test event listener, added an event dispatch in diff workflow, run the workflow, the listener was called. Reviewers: epriestley Reviewed By: epriestley CC: aran, jungejason, epriestley Differential Revision: 1102
2011-11-10 22:47:45 +01:00
'ArcanistEventType' => 'PhutilEventType',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistExportWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistFilenameLinter' => 'ArcanistLinter',
'ArcanistGeneratedLinter' => 'ArcanistLinter',
'ArcanistGitAPI' => 'ArcanistRepositoryAPI',
'ArcanistGitHookPreReceiveWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistHelpWorkflow' => 'ArcanistBaseWorkflow',
"arc install-certificate", client side changes Summary: Provide an "install-certificate" workflow to simplify ~/.arcrc edits. See also D460. Test Plan: Installed certificates via "arc install-certificate". Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 465
2011-06-14 21:18:40 +02:00
'ArcanistInstallCertificateWorkflow' => 'ArcanistBaseWorkflow',
Adds ArcanistJSHintLinter to check JS files for errors and potential problems. This patch adds ArcanistJSHintLinter class and three new .arcconfig options: * lint.jshint.prefix - directory where JSHint binary resides * lint.jshint.bin - JSHint binary name (if different from 'jshint') * lint.jshint.config - a JSON file with JSHint project-wide options By default, this linter assumes that JSHint is installed on user's system as an NPM package. Test Plan: (1) Run `npm install jshint -g` to install JSHint and add ArcanistJSHintLinter to your Lint Engine (I didn't see PEP8 or PyFlakes in the PhutilLintEngine so I decided to not to put JSHint in there). After that you can do `arc lint my.js`. (2) Create a new file, config.json, and add `{ "white": true }` in it. Add `"lint.jshint.config": "/path/to/config.json"` to your .arcconfig and run `arc lint my.js`. After that, unless your name is Douglas Crockford, you'll see tons of JSHint warnings about minor PEP8-like things (spacing, etc.)
2012-01-14 00:21:57 +01:00
'ArcanistJSHintLinter' => 'ArcanistLinter',
Add "arc land" as a first-class workflow Summary: This is a fancy version of "land.sh" that uses "git merge --squash" and "arc which" to cover more cases. Test Plan: Ran "arc land" against various repository states (no such branch, not accepted, valid, etc). Things seemed OK. There are basically an infinite number of states here so it's hard to test exhaustively. Reviewers: cpiro, btrahan, jungejason, davidreuss Reviewed By: davidreuss CC: zeeg, aran, epriestley, davidreuss Maniphest Tasks: T787, T723 Differential Revision: https://secure.phabricator.com/D1488
2012-01-26 00:10:59 +01:00
'ArcanistLandWorkflow' => 'ArcanistBaseWorkflow',
'arc liberate', convenience wrapper for various libphutil operations Summary: The story for creating and maintaining libphutil libraries and modules is pretty terrible right now: you need to know a bunch of secret scripts and dark magic. Provide 'arc liberate' which endeavors to always do the right thing and put a library in the correct state. Test Plan: Ran liberate on libphutil, arcanist, phabricator; created new libphutil libraries, added classes to them, liberated everything, introduced errors etc and liberated that stuff, nothing was obviously broken in a terrible way..? Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 269
2011-05-12 01:30:22 +02:00
'ArcanistLiberateLintEngine' => 'ArcanistLintEngine',
'ArcanistLiberateWorkflow' => 'ArcanistBaseWorkflow',
Refactor Apache license linter to parameterize the license itself. Summary: Refactor Apache license linter to parameterize the license itself. Test Plan: meta - begin *PUBLIC* platform impact section - Bugzilla: # - end platform impact - Differential Revision: 33 Reviewed By: epriestley Reviewers: epriestley
2011-02-12 01:03:00 +01:00
'ArcanistLicenseLinter' => 'ArcanistLinter',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistLintWorkflow' => 'ArcanistBaseWorkflow',
Fix greediness in Apache License linter. Summary: The multi-line comment regexp was potentially too greedy. See "greedy.lint-test". - Made it less greedy. - Added test coverage. - Fixed an issue with the Apache license getting applied with too much whitespace against C files. Test Plan: Ran unit tests. Reviewers: aran CC: Differential Revision: 36
2011-02-13 20:57:14 +01:00
'ArcanistLinterTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistListWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistMarkCommittedWorkflow' => 'ArcanistBaseWorkflow',
Basic Mercurial support for Arcanist Summary: There's a lot of ground left to cover but this makes "arc diff" work (on one trivial diff) in my sandbox, at least, and supports parsing of Mercurial native diffs (which are unified + a custom header). Piles of missing features, still. Some of this is blocked by me not understanding the mercurial model well yet. This is also a really good opportunity for cleanup (especially, reducing the level of "instanceof" in the diff workflow), I'll try to do a bunch of that in followup diffs. Test Plan: Ran "arc diff" in a mercurial repository, got a diff out of it. Reviewed By: aran Reviewers: Makinde, jungejason, tuomaspelkonen, aran, codeblock CC: aran, epriestley, codeblock, fratrik Differential Revision: 792
2011-08-09 18:00:29 +02:00
'ArcanistMercurialAPI' => 'ArcanistRepositoryAPI',
Split mercurial parsing and API Summary: Move code to actually parse "hg" output into a separate class with some tests, so I can reuse it in the import scripts. We should probably do this for Git/SVN at some point, too. Test Plan: Ran unit tests, used this class in Phabricator importers, grepped for calls to removed private methods. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde Differential Revision: 942
2011-09-16 12:53:52 +02:00
'ArcanistMercurialParserTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistNoEffectException' => 'ArcanistUsageException',
'ArcanistNoEngineException' => 'ArcanistUsageException',
Respect @nolint Summary: Respect @nolint annotations Test Plan: New "test case" Differential Revision: 41 Reviewed By: epriestley Reviewers: epriestley CC: epriestley
2011-02-25 02:59:49 +01:00
'ArcanistNoLintLinter' => 'ArcanistLinter',
Make all the working-copy-paths errors extremely explicit.
2011-03-13 03:16:15 +01:00
'ArcanistNoLintTestCaseMisnamed' => 'ArcanistLinterTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistPEP8Linter' => 'ArcanistLinter',
Add an "arc paste" workflow Summary: Read and write in the same workflow! Dogs and cats living together! Test Plan: - Performed a bunch of paste reads and writes and they looked ok? Reviewed By: aran Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 748
2011-07-30 03:55:01 +02:00
'ArcanistPasteWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistPatchWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistPhutilModuleLinter' => 'ArcanistLinter',
arc lint: add support for PyFlakes Summary: Provide a simple linter wrapper around pyflakes. This relies on finding pyflakes via: - lint.pyflakes.path - arcconfig setting of absolute path to pyflakes - lint.pyflakes.prefix - arcconfig setting of the prefix that pyflakes was installed under - users path Test Plan: linted python code with PyFlakes warnings Reviewed By: epriestley Reviewers: jungejason, epriestley Commenters: jungejason CC: aran, epriestley, andrewjcg, jungejason Differential Revision: 310
2011-05-19 11:00:59 +02:00
'ArcanistPyFlakesLinter' => 'ArcanistLinter',
arc lint: add support for PyLint Summary: Provides a lint class as a wrapper around the external project PyLint. This exposes some arc config variables to control the behavior: lint.pylint.prefix - non-standard installation location of pylint lint.pylint.logilab_astng.prefix - non-standard installation location of logilab-astng, a dependency of pylint lint.pylint.logilab_common.prefix - non-standard installation location of logilab-common, a dependency of pylint lint.pylint.codes.{error,warning,advice} - regexes matching against PyLint message codes which should trigger arc errors/warnings/advice lint.pylint.options - options to pass PyLint Test Plan: used to lint python code Reviewed By: epriestley Reviewers: epriestley, jungejason CC: aran, epriestley Differential Revision: 343
2011-05-22 12:32:26 +02:00
'ArcanistPyLintLinter' => 'ArcanistLinter',
Basic 'shell-complete' workflow. Summary: Adds data-driven shell completion help to arcanist. Test Plan: ran various commands in git and svn working copies, output seemed reasonable Differential Revision: 201754 Reviewed By: adonohue Reviewers: mroch, adonohue Commenters: crackerjack CC: epriestley, adonohue, achao Revert Plan: OK
2011-01-15 05:00:11 +01:00
'ArcanistShellCompleteWorkflow' => 'ArcanistBaseWorkflow',
Add spell check linter Summary: Inspired by http://news.ycombinator.com/item?id=3464671 and a lot of diffs I've seen @ FB, I've added a spell checking linter. To reduce false positives, it's only a blacklist. Still, it catches a large number of 'issues'. Test Plan: Unit tests. Ran on FB's codebase. No false positives noticed but a lot of cases caught. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley, jack Differential Revision: https://secure.phabricator.com/D1409
2012-01-16 06:28:58 +01:00
'ArcanistSpellingLinter' => 'ArcanistLinter',
'ArcanistSpellingLinterTestCase' => 'ArcanistLinterTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistSubversionAPI' => 'ArcanistRepositoryAPI',
[arc svn-hook-pre-commit] Access working copy Summary: Creates a new hook API that can be used to interface with SVN/Git/Mercurial in the context of a commit hook. Currently only adds a function to read the modified file data in a Subversion commit hook. An object of this API is created in the SvnHookPreCommitWorkflow and passed on the Lint Engine which then uses it to access current file data, of the way the APIs seem to be structured); linters use the getData function which is essentially a wrapper around the engine's call, with another layer of caching. Task ID: #770556 Blame Rev: Test Plan: - Create a local svn repository and add a minimal hook to run the local version of arc to test commits (http://phabricator.com/docs/arcanist/article/Installing_Arcanist_SVN_Hooks.html) - Create a temporary repository that can trigger any of the linters available, and test against a temporary linter by committing against the test repository: the linter should be able to access all required files by using loadData/getData in the LintEngine and Linter. Revert Plan: Tags: lint, svn-hook-pre-commit Reviewers: jungejason, asukhachev, epriestley, aran Reviewed By: epriestley CC: aran, jungejason, epriestley, kunalb, asukhachev Differential Revision: https://secure.phabricator.com/D1256
2011-12-21 05:26:05 +01:00
'ArcanistSubversionHookAPI' => 'ArcanistHookAPI',
Add SVN pre-commit hook support. Summary: Basic support for an SVN pre-commit hook. Still very skeletal. Test Plan: Reviewers: CC:
2011-01-12 10:49:48 +01:00
'ArcanistSvnHookPreCommitWorkflow' => 'ArcanistBaseWorkflow',
Add arc tasks command Summary: Added `arc tasks`: %%%arc tasks arc tasks --view-all // View Open and Closed Tasks arc tasks --by-status // Group By Status arc tasks --by-priority // Group By Priority%%% Test Plan: Connect to conduit and run arc tasks >> make sure you have tasks =p Reviewers: epriestley, indiefan Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T749 Differential Revision: https://secure.phabricator.com/D1943
2012-04-08 02:40:25 +02:00
'ArcanistTasksWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistTextLinter' => 'ArcanistLinter',
Add @nocommit and tests to Text linter. Summary: Test Plan: Reviewers: CC:
2011-02-17 02:26:51 +01:00
'ArcanistTextLinterTestCase' => 'ArcanistLinterTestCase',
When a mercurial working copy has uncommitted changes, prompt to include them in "arc diff" Summary: See task. Allow mercurial users to diff with uncommitted changes. - By default, commit range is merge-base of `hg outgoing` to `.` (dirstate). - You can get JUST dirstate with `arc diff tip` or similar. - This ended up being a giant mess various other changes to deal with empty `hg outgoing` and empty dirstate. Test Plan: Diffed with uncommitted changes, got sensible prompts and results. Reviewers: Makinde, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T998 Differential Revision: https://secure.phabricator.com/D1954
2012-03-20 03:17:10 +01:00
'ArcanistUncommittedChangesException' => 'ArcanistUsageException',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistUnitWorkflow' => 'ArcanistBaseWorkflow',
Add 'arc upload' and 'arc download' Summary: Mechanisms for interacting with Files via Arcanist. Test Plan: - Ran 'arc upload x', 'arc upload x y z' - Ran 'arc download' with --as and --show. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 742
2011-07-29 19:05:07 +02:00
'ArcanistUploadWorkflow' => 'ArcanistBaseWorkflow',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistUserAbortException' => 'ArcanistUsageException',
Add 'arc which', and ArcanistRepositoryAPI->loadWorkingCopyDifferentialRevisions() Summary: - See T787. - @cpiro has an immediate use case for this, which is ##arc amend --revision `arc which --id` --show master## for "git merge --autosquash" or similar. - For T614, we need this to choose "--create" vs "--update". - Other workflows should also use this to improve how often we automatically get things right, particularly in Mercurial and SVN. Test Plan: Ran "arc which" in SVN, Git and HG working copies with various flags; results seemed reasonable. Reviewers: btrahan, cpiro, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T787 Differential Revision: https://secure.phabricator.com/D1478
2012-01-24 17:07:38 +01:00
'ArcanistWhichWorkflow' => 'ArcanistBaseWorkflow',
Improve Arcanist symbol name linter Summary: - Move name helper functions to ArcanistXHPASTLintNamingHook to make it easier to write custom linters. - Add test coverage for name functions. - Add 'variable' and 'global' naming convention tests. - Expand test cases. - Improve lint message error when an unexpected message is raised during a test. - Remove a defunct XHP lint message. Test Plan: - Ran unit tests. - Ran "arc lint --lintall" on arcanist/. Reviewers: btrahan, nh, jungejason Reviewed By: btrahan CC: johnduhart, aran, epriestley, arudolph Differential Revision: https://secure.phabricator.com/D1506
2012-01-28 20:17:45 +01:00
'ArcanistXHPASTLintNamingHookTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'ArcanistXHPASTLinter' => 'ArcanistLinter',
Fix greediness in Apache License linter. Summary: The multi-line comment regexp was potentially too greedy. See "greedy.lint-test". - Made it less greedy. - Added test coverage. - Fixed an issue with the Apache license getting applied with too much whitespace against C files. Test Plan: Ran unit tests. Reviewers: aran CC: Differential Revision: 36
2011-02-13 20:57:14 +01:00
'ArcanistXHPASTLinterTestCase' => 'ArcanistLinterTestCase',
Rebuild phutil library map for arc Summary: D1439 added a new class which had the wrong name in the map from D1439. Whoopsiepoos! Test Plan: unit tests now pass Reviewers: epriestley, zeeg Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1441
2012-01-17 23:54:27 +01:00
'ComprehensiveLintEngine' => 'ArcanistLintEngine',
Provide better documentation for lint engines, linters, and the PyLint linter Summary: Document the relationship between lint engines and linters. Provide an example linter. Improve the documentation of PyLintLinter, which has a bunch of configuration stuff which you had to dig into the code to get. Test Plan: Ran "arc lint --engine ExampleLintEngine --lintall derp.py" on a file with a Python syntax error in it. Read documentation. Reviewed By: j3kuntz Reviewers: j3kuntz, andrewjcg CC: aran, j3kuntz Differential Revision: 557
2011-06-30 04:32:03 +02:00
'ExampleLintEngine' => 'ArcanistLintEngine',
Initial commit.
2011-01-10 00:22:25 +01:00
'PhutilLintEngine' => 'ArcanistLintEngine',
'PhutilUnitTestEngine' => 'ArcanistBaseUnitTestEngine',
Ship unresolved unit test information to Differential. Summary: Test Plan: Reviewers: CC:
2011-01-12 07:13:31 +01:00
'PhutilUnitTestEngineTestCase' => 'ArcanistPhutilTestCase',
Initial commit.
2011-01-10 00:22:25 +01:00
'UnitTestableArcanistLintEngine' => 'ArcanistLintEngine',
),
'requires_interface' =>
array(
),
));
Copy permalink